[pgadmin-hackers] [pgAdmin4][Patch]: RM1119 - Add proper validations in fields before processing

Hi Issues fixed: 1) Add proper validation checks for fields. 2) Fixed wrong sql generation due to incorrect conditions in template. Please find attached patch and review. Thanks, Surinder Kumar RM1119.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@p

Re: [pgadmin-hackers] [pgAdmin 4 - Bug #1523] Messages pane showing incomplete info

Hi Not sure if I'm missing an email with this patch - I only seem to have received the Redmine notification Anyway; I don't believe this is the best way to fix this (and making the notices unique is most definitely wrong). First, I was thinking of something like the following, to auto-clear t

[pgadmin-hackers] pgAdmin 4 commit: Prevent the user attempting to run external commands

Prevent the user attempting to run external commands if the bin path is not configured. Fixes #1177 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f78024808e80fef67de1aef5c97d1756c6771c0e Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] patch for RM1177 [pgadmin4]

Thanks, applied with some minor wording tweaks. On Fri, Aug 5, 2016 at 4:25 PM, Harshal Dhumal wrote: > Hi, > > PFA patch for RM1177. > > Issue fixed: Added a check to warn the user if the binary path is not set > before running external commands. > > -- > Harshal Dhumal > Software Engineer > > E

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type

Hi Surinder, This looks very promising, but it only covers the query tool at present. We need the shortcuts to apply to all codemirror instances. Do the others work anyway, because we're invoking in a different way, or is more work needed there? On Fri, Aug 5, 2016 at 6:42 PM, Surinder Kumar wro

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1524 - Reverse engineered SQL for Trigger Functions missing "AS"

Thanks - applied. On Fri, Aug 5, 2016 at 7:48 PM, Surinder Kumar wrote: > Hi > > Issue: > Keyword "AS" should be written outside the endif clause, it was written > inside. > > Please find attached patch and review. > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pga

[pgadmin-hackers] pgAdmin 4 commit: Fix RE-SQL for Trigger Functions which was missing an

Fix RE-SQL for Trigger Functions which was missing an 'AS'. Fixes #1524 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7cf4ac2474c9ed111519929ff54f55522ad54768 Author: Surinder Kumar Modified Files -- .../functions/templates/trigg

[pgadmin-hackers] pgAdmin 4 commit: Sequence related validation/fixes. Fixes #1119

Sequence related validation/fixes. Fixes #1119 1) Add proper validation checks for fields. 2) Fixed wrong sql generation due to incorrect conditions in template. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5900848842496c41288a9b54fb560d093a

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1119 - Add proper validations in fields before processing

Thanks, applied. On Mon, Aug 8, 2016 at 9:48 AM, Surinder Kumar wrote: > Hi > > Issues fixed: > 1) Add proper validation checks for fields. > 2) Fixed wrong sql generation due to incorrect conditions in template. > > Please find attached patch and review. > > > Thanks, > Surinder Kumar > > > > --

Re: [pgadmin-hackers] RM #1250 Collection node counts

Hi On Mon, Aug 8, 2016 at 11:39 AM, Akshay Joshi wrote: > Hi All > > I have fixed the RM#1250 "Collection node counts". To fix this RM I need > to do following changes > >- Move "check_precondition" function from module's view class to >global level within that python file itself, so tha

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type

On Mon, Aug 8, 2016 at 4:43 PM, Dave Page wrote: > Hi Surinder, > > This looks very promising, but it only covers the query tool at > present. We need the shortcuts to apply to all codemirror instances. > Do the others work anyway, because we're invoking in a different way, > or is more work need

Re: [pgadmin-hackers] RM #1250 Collection node counts

On Mon, Aug 8, 2016 at 5:33 PM, Dave Page wrote: > Hi > > On Mon, Aug 8, 2016 at 11:39 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> I have fixed the RM#1250 "Collection node counts". To fix this RM I need >> to do following changes >> >>- Move "check_preconditi

Re: [pgadmin-hackers] RM #1250 Collection node counts

On Mon, Aug 8, 2016 at 1:18 PM, Akshay Joshi wrote: > > > On Mon, Aug 8, 2016 at 5:33 PM, Dave Page wrote: > >> Hi >> >> On Mon, Aug 8, 2016 at 11:39 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>> I have fixed the RM#1250 "Collection node counts". To fix this R

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type

On Mon, Aug 8, 2016 at 1:15 PM, Surinder Kumar wrote: > On Mon, Aug 8, 2016 at 4:43 PM, Dave Page wrote: >> >> Hi Surinder, >> >> This looks very promising, but it only covers the query tool at >> present. We need the shortcuts to apply to all codemirror instances. >> Do the others work anyway, b

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type

On Mon, Aug 8, 2016 at 5:52 PM, Dave Page wrote: > On Mon, Aug 8, 2016 at 1:15 PM, Surinder Kumar > wrote: > > On Mon, Aug 8, 2016 at 4:43 PM, Dave Page wrote: > >> > >> Hi Surinder, > >> > >> This looks very promising, but it only covers the query tool at > >> present. We need the shortcuts to

[pgadmin-hackers] [pgAdmin4][runtime][patch]: Runtime not working in all platform

Hi, Please find attached patch file to fix the below issue. *Issue:-* Runtime was not working in all platform due to syntax error in javascript. This issue was introduced due to below commit. Prevent the user attempting to run external commands if the bin path is not configured. Fixes #1177 f78

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type

Hi Dave, This patch contains following changes: 1. Add "*editor_shortcut_keys*" variable to *pgAdmin.Browser* in *browser.js* object to make it accessible to all pgAdmin modules. 2. Apply shortcuts keys to following code mirror instances: a) Query tool, Query filter & Datagri

[pgadmin-hackers] pgAdmin 4 commit: Fix a JS error in the runtime caused by f78024808e80f

Fix a JS error in the runtime caused by f78024808e80fef67de1aef5c97d1756c6771c0e (#1177) Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=37ca3579f3c7be201c3e8e2a07450e8fb99dd63b Author: Neel Patel Modified Files -- web/pgadmin/bro

Re: [pgadmin-hackers] [pgAdmin4][runtime][patch]: Runtime not working in all platform

Thanks, applied. On Mon, Aug 8, 2016 at 2:11 PM, Neel Patel wrote: > Hi, > > Please find attached patch file to fix the below issue. > > Issue:- > Runtime was not working in all platform due to syntax error in javascript. > This issue was introduced due to below commit. > > Prevent the user attem

[pgadmin-hackers] pgAdmin 4 commit: Fix more of the funky keyboard shortcuts.

Fix more of the funky keyboard shortcuts. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1bcac0b67cff286442c1a5a055d6b5f97293d074 Author: Surinder Kumar Modified Files -- .../browser/templates/browser/js/browser.js| 35 +++

[pgadmin-hackers] pgAdmin 4 commit: Fix titles of help pages.

Fix titles of help pages. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2aea97b79843c7df69907219c4ee06dcc07cd2e3 Modified Files -- docs/en_US/backup_globals_dialog.rst | 8 docs/en_US/backup_server_dialog.rst | 13 ++

[pgadmin-hackers] pgAdmin 4 commit: Missing comma. Sigh.

Missing comma. Sigh. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a025c0ebf05f67e4e4d556d8767f44efb582e286 Modified Files -- web/pgadmin/browser/templates/browser/js/browser.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type

Thanks, applied with minor changes per our discussion on skype. On Mon, Aug 8, 2016 at 2:34 PM, Surinder Kumar wrote: > Hi Dave, > > This patch contains following changes: > > Add "editor_shortcut_keys" variable to pgAdmin.Browser in browser.js object > to make it accessible to all pgAdmin module

[pgadmin-hackers] [pgadmin4] fix for RM1417

Hi, PFA patch for issue RM1417. Changes: Fixed privileges parsing issue while editing privileges of exiting object. Additional Note: This was general issue and was not related to runtime or pg 9.6. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The E

[pgadmin-hackers] pgAdmin 4 as Web application

I'm trying to follow https://www.pgadmin.org/docs4/dev/server_deployment.html to install pgAdmin 4 as web application on RHEL 6, but I didn't get very far: There is no file "pgAdmin4.wsgi" available for download. Did I miss something obvious? So I tried to build from source, and failed immediate

[pgadmin-hackers] pgAdmin 4 commit: Fixed privileges parsing issue while editing privileg

Fixed privileges parsing issue while editing privileges of existing object. Fixes #1417 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8918b8894dfa0f4392667b84635bd64ef83521ae Author: Harshal Dhumal Modified Files -- .../server_g

Re: [pgadmin-hackers] [pgadmin4] fix for RM1417

Thanks - patch applied. On Mon, Aug 8, 2016 at 3:59 PM, Harshal Dhumal wrote: > Hi, > > PFA patch for issue RM1417. > > Changes: Fixed privileges parsing issue while editing privileges of exiting > object. > > Additional Note: This was general issue and was not related to runtime or pg > 9.6. > >

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi I guess you need to test if tablespace_path is omitted, not just empty? This function test the add tablespace scenario (Check Tablespace Node) ... ERROR == ERROR: setUpClass (pgadmin.browser.server_groups.servers.tablespaces.

[pgadmin-hackers] pgAdmin 4 commit: Bump version.

Bump version. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48384cd6cd0634b11937df1a3e11a7ccf0213406 Modified Files -- web/config.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) -- Sent via pgadmin-hackers mailin

[pgadmin-hackers] pgAdmin 4 commit: Update message catalog.

Update message catalog. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33457e6a90617d44f9ef3bd1d973fff2787c46e0 Modified Files -- web/pgadmin/messages.pot | 2701 +- 1 file changed, 1479 i

Re: [pgadmin-hackers] pgAdmin 4 as Web application

Hi, >From the logs, it looks like - Qt webkit component is missing in Qt4 installation. Are you building Qt from source, If yes then there will be option in configure script to build Qt4 with webkit. If you are not using source code, try installing webkit with yum (e.g. yum install libqt4-webkit).

Re: [pgadmin-hackers] pgAdmin 4 as Web application

On Mon, Aug 8, 2016 at 4:07 PM, Albe Laurenz wrote: > I'm trying to follow > https://www.pgadmin.org/docs4/dev/server_deployment.html > to install pgAdmin 4 as web application on RHEL 6, but I didn't get very far: > > There is no file "pgAdmin4.wsgi" available for download. > Did I miss something

[pgadmin-hackers] Error while running pgAdmin4 with apache wsgi - Ubuntu

HI, I am trying to run the pgadmin4 in apache with wsgi module ( Ubuntu 14.04 ). I am getting the below error in the apache error log. [Wed Aug 03 02:27:33.552337 2016] [:error] [pid 25054:tid 140070015198976] ' (HEAD, POST, OPTIONS, GET) -> security.reset_password>, [Wed Aug 03 02:27:33.552340