Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1789 Column width of data output panel should fit to data (as pgAdmin III)

2016-12-09 Thread Akshay Joshi
Hi Dave On Fri, Oct 28, 2016 at 8:43 PM, Dave Page wrote: > Hi > > On Fri, Oct 28, 2016 at 7:04 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> Please find the attached patch to fix the RM #1789 Column width of data >> output panel should fit to data (as pgAdmin III)

[pgadmin-hackers] PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

2016-12-09 Thread Ashesh Vashi
Hi Dave, Please find the patch to resolve the issue reported in RM #1679 This will take care of: - Find the appropriate available Python interpreter to execute the process_executor.py. In case of WSGI or Runtime, it was not properly find the interpre

[pgadmin-hackers] [pgAdmin4]: RM-1910 - Remember last used directory in the file manager

2016-12-09 Thread Neel Patel
Hi, Please find attached patch file which contains the fix of last used directory in file manager. Now file manager will remember last used directory per user basis and will be store in SQLite database. Do review it and let us know for comments. Thanks, Neel Patel RM_1910.patch Description: Bi

[pgadmin-hackers] [pgAdmin4][Patch]: RM 1780: Rendering glitches in the query editor line number column when editing many lines

2016-12-09 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 1780: Rendering glitches in the query editor line number column when editing many lines. Some codemirror css were overwritten to increase the width of the line number column in sql editor. Due to those changes this issue was coming, I have removed

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

2016-12-09 Thread Dave Page
Thanks, patch applied. On Fri, Dec 9, 2016 at 5:32 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Mon, Dec 5, 2016 at 11:09 PM, Dave Page wrote: >> >> Hi >> >> On Friday, December 2, 2016, Khushboo Vashi >> wrote: >>> >>> Hi. >>> >>> Pl

[pgadmin-hackers] pgAdmin 4 commit: Treat databases with datallowconn=false appropriately

2016-12-09 Thread Dave Page
Treat databases with datallowconn=false appropriately. Fixes #1801 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=81841cdb3c23141b08de4c5ca2d8d21847470035 Author: Khushboo Vashi Modified Files -- web/pgadmin/browser/collection.py

[pgadmin-hackers] pgAdmin 4 commit: Don't cast data when saving in the edit grid, so erro

2016-12-09 Thread Dave Page
Don't cast data when saving in the edit grid, so errors are seen and data doesn't get silently modified. Fixes #1994 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b8d03d5dc23afa3f52810ab056d646f43a21ab91 Author: Akshay Joshi Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1994 Insert / update are truncating if column is character

2016-12-09 Thread Dave Page
Thanks, patch applied. On Fri, Dec 9, 2016 at 6:37 AM, Akshay Joshi wrote: > Hi Dave > > I have remove the type casting while inserting/updating data. Attached is > the patch file to fixe the issue, I have tested this patch with following > data types: > > "serial, integer, interger[], numeric,

Re: [pgadmin-hackers] [pgAdmin4]: RM-1910 - Remember last used directory in the file manager

2016-12-09 Thread Dave Page
Hi On Fri, Dec 9, 2016 at 10:23 AM, Neel Patel wrote: > Hi, > > Please find attached patch file which contains the fix of last used > directory in file manager. > Now file manager will remember last used directory per user basis and will > be store in SQLite database. > > Do review it and let us

[pgadmin-hackers] pgAdmin 4 commit: Only show the filename in query tool tabs, not the wh

2016-12-09 Thread Dave Page
Only show the filename in query tool tabs, not the whole path. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a280b251755091af9bf56bcdee964601df104ae Modified Files -- web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.j

[pgadmin-hackers] [pgAdmin4][Patch]: RM 2007: View Last 100 rows not working with Pgadmin4

2016-12-09 Thread Khushboo Vashi
Hi, Please find the attached patch to fix RM 2007: View Last 100 rows not working with Pgadmin4. To fix this issue I have changed the query which fetches the last 100 rows. The issue is reproducible when we have more than one primary keys; because the order by clause in the query was not applied

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1789 Column width of data output panel should fit to data (as pgAdmin III)

2016-12-09 Thread Akshay Joshi
Hi Dave I have tried to get the width of the content but we are sending complete data as collection to the SlickGrid. We will have to fetch the content of each column and figure out the maximum length for that column by iterating all the rows is too expensive. Apart from that to set the width in '