[pgadmin-hackers] pgAdmin 4 commit: Remember the last used directory in the file manager.

2017-01-08 Thread Dave Page
Remember the last used directory in the file manager. Fixes #1910 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8d71e888b4f02cd96bed3fecbc6e52e796d41c49 Author: Neel Patel Modified Files -- web/pgadmin/misc/file_manager/__init__.

[pgadmin-hackers] pgAdmin 4 commit: Allow setting of effective_io_concurrency on tablespa

2017-01-08 Thread Dave Page
Allow setting of effective_io_concurrency on tablespaces in 9.6+. Fixes #2000 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07e1c61eea471397fd98186af3f39cc278a0a8e5 Author: Surinder Kumar Modified Files -- .../browser/server_grou

[pgadmin-hackers] pgAdmin 4 commit: Show icons for unique and exclusion constraints in th

2017-01-08 Thread Dave Page
Show icons for unique and exclusion constraints in the dependency/dependents panels. Fixes #2033 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e14bef801f539c95a21daaf17632392f356acbb Author: Surinder Kumar Modified Files -- web

Re: [pgadmin-hackers] Driver Module

2017-01-08 Thread Dave Page
Hi On Friday, January 6, 2017, George Gelashvili wrote: > Hi there, > > We are working on connecting Greenplum to pgAdmin4. Currently we are > exploring how modules work in pgAdmin. In an earlier off-thread email it > was suggested we look at "the EDB PPAS" as an example of a driver class. We >

Re: [pgadmin-hackers] PATCH: Table dialogue column specification issues (pgAdmin4)

2017-01-08 Thread Dave Page
Thanks, patch applied. On Friday, December 23, 2016, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > Hi, > > PFA patch to fix one last pending issue from RM#1394, Now user can change > the value of SwitchCell when they goto SwitchCell using Tab key press, > earlier it was not w

[pgadmin-hackers] pgAdmin 4 commit: Reset the column list properly if the access method i

2017-01-08 Thread Dave Page
Reset the column list properly if the access method is changed on an index to ensure error handling works correctly. Fixes #2009 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2787c5c207e3f5ed45834285e6f8318ec8d2059d Author: Neel Patel Modif

[pgadmin-hackers] pgAdmin 4 commit: Properly detect when files have changed in the query

2017-01-08 Thread Dave Page
Properly detect when files have changed in the query tool and set the dirty flag accordingly. Fixes #1807 Note that (like pgAdmin 3) we don't make any attempt to detect if all changes have been undone and completely reverted as that could be very expensive with large scripts. Branch -- mas

[pgadmin-hackers] pgAdmin 4 commit: Prevent attempts to create server groups with no name

2017-01-08 Thread Dave Page
Prevent attempts to create server groups with no name. Fixes #2012 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e3c8cb2706a1e4e7ccdba2506d1f28d399141acd Author: Surinder Kumar Modified Files -- .../templates/server_groups/server

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM2000 - Add support for "effective_io_concurrency" tablespace option under parameter tab in tablespace

2017-01-08 Thread Dave Page
Thanks, patch applied. On Friday, December 23, 2016, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > As per docs, for postgres version 9.5 , only two tablespaces options are > supported "*seq_page_cost and random_page_cost*" > > And for 9.6 , the support for "*effective_io_conc

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2012 - Disable Save button if name is empty in Server-group

2017-01-08 Thread Dave Page
Thanks, patch applied. On Friday, December 23, 2016, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > The issue is with validation which is now fixed. > > Please find attached patch and review. > > > Thanks, > Surinder Kumar > -- Dave Page Blog: http://pgsnake.blogspot.com Tw

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #1807 Query Tool Does Not Recognize When File Changes Have Been Saved

2017-01-08 Thread Dave Page
Thanks, patch applied. On Friday, December 23, 2016, Akshay Joshi wrote: > Hi Dave > > I have fixed all the comments given by you. Attached is the modified patch > file. Please review it. > > On Fri, Dec 16, 2016 at 7:08 PM, Dave Page > wrote: > >> >> >> On Fri, Dec 16, 2016 at 1:24 PM, Akshay

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-01-08 Thread Dave Page
Hi On Friday, December 23, 2016, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Forgot to attach patch in last thread. please find patch. > It looks good for the most part, except: 1) You missed the part we discussed about being able to set a value to '' (the literal string containi

Re: [pgadmin-hackers] [pgAdmin4][patch]: RM#2026 - Debugger enabled when pldbgapi extension not loaded

2017-01-08 Thread Dave Page
Thanks, patch applied. On Friday, December 23, 2016, Neel Patel wrote: > Hi, > > Please find attached patch file with the fix of RM #2026. > > *Issue :- * > When debugger plugin is configured but doesn't have extension loaded in > database then user allowed to launch the debugger. > > *Solution:

[pgadmin-hackers] pgAdmin 4 commit: Fix keyboard control of switches in the column grid.

2017-01-08 Thread Dave Page
Fix keyboard control of switches in the column grid. Fixes #1394 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=879a6bef5374f8ab1d409706b49d930ead51a2ac Author: Murtuza Zabuawala Modified Files -- .../tables/column/templates/colum

[pgadmin-hackers] pgAdmin 4 commit: Allow selection of message box contents for ease of e

2017-01-08 Thread Dave Page
Allow selection of message box contents for ease of error message copy/paste. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5d0a0e57e77d2a50c34bbda5ec82e89d3290192c Modified Files -- web/pgadmin/static/css/overrides.css | 2 +- 1 f

[pgadmin-hackers] pgAdmin 4 commit: Improve detection of the pldbgapi extension and funct

2017-01-08 Thread Dave Page
Improve detection of the pldbgapi extension and functions before allowing debugging. Fixes #2026 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a33ee2ae32aa45a86b117f0d6352f21313079c11 Author: Neel Patel Modified Files -- web/pga

Re: [pgadmin-hackers] PATCH: Dialogue control buttons should be consistent (pgAdmin4)

2017-01-08 Thread Dave Page
Thanks, patch applied. On Friday, January 6, 2017, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where some dialogue control buttons were not > consistent with others dialogs. > RM#1364 > > Patch fixes, > 1) Preferences: Close, Maximise, Pin

Re: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2017-01-08 Thread Dave Page
Hi Can you rebase this please? It no longer applies :-( On Wednesday, December 28, 2016, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > Here is updated (V4) patch. > > Changes: 1] Now can enter both type of slashes ( / and \ ) and all will > get replaced with the platform

[pgadmin-hackers] new acquaintances

2017-01-08 Thread sin
Dear friend! I've recently met some new people who have shown me something really cool, please take a look http://gianpaolo.dannyboy.me/2c2d Sincerely, sin

[pgadmin-hackers] pgAdmin 4 commit: Improve consistency of dialogue controls offered. Fix

2017-01-08 Thread Dave Page
Improve consistency of dialogue controls offered. Fixes #1364 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bdf9761472c215b84e49ed82ee481e237e151b7b Author: Murtuza Zabuawala Modified Files -- .../servers/templates/servers/server

[pgadmin-hackers] pgAdmin 4 commit: Various improvements to the regression tests, notably

2017-01-08 Thread Dave Page
Various improvements to the regression tests, notably avoiding use of signals unavailable on Windows. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1325b30e0bcbfd951ded5ba754813251621604e2 Author: Navnath Gadakh Modified Files -

Re: [pgadmin-hackers] pgAdmin IV: Minor code changes in API test cases

2017-01-08 Thread Dave Page
Thanks, patch applied. On Wednesday, December 28, 2016, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > Please find the patch with some minor code changes in API test cases > in packages, synonyms, databases, resource groups. > Code changes for: > - In some scenarios i

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1730 - Role membership control display needs improvement

2017-01-08 Thread Dave Page
Hi On Friday, January 6, 2017, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix RM 1730 - Role membership control > display needs improvement > > *Fixed items:* > > - An alternate note is needed when shown on the properties panel > - Remove the border > - Align the label and

[pgadmin-hackers] pgAdmin 4 commit: Ensure breakpoints are cleared properly when clearing

2017-01-08 Thread Dave Page
Ensure breakpoints are cleared properly when clearing all of them. Fixes #1745 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d87345ef52657662ee936df759cd2a93bf9d80c0 Author: Neel Patel Modified Files -- .../tools/debugger/templat

Re: [pgadmin-hackers] [pgAdmin4][patch]: RM #1745 - Fixed Clear breakpoint issue

2017-01-08 Thread Dave Page
Thanks, patch applied. On Friday, December 23, 2016, Neel Patel wrote: > Hi, > > Please find attached patch file for the fix of RM #1745. > > *Issue:-* > Line number was set properly when user set the breakpoint so clear > breakpoint was not working properly. > > Do review it and let us know for

Re: [pgadmin-hackers] PATCH: To fix the issue in exclusion constraint (pgAdmin4)

2017-01-08 Thread Dave Page
Hi On Friday, December 30, 2016, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where we were fetching wrong OID while > generating node which was causing "index out of range". error when user > try to access that exclusion constraint . > RM#18

Fwd: [pgadmin-hackers] Patch for RM1911 Direct file navigation [pgAdmin4] [Feature]

2017-01-08 Thread Harshal Dhumal
Hi Dave, Please find attached rebased patch. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sun, Jan 8, 2017 at 4:07 PM, Dave Page wrote: > Hi > > Can you rebase this please? It no longer applies :-( > > > On Wed