Re: [pgadmin-hackers] Feature test issues

On Mon, Feb 27, 2017 at 7:51 PM, Atira Odhner wrote: > The team here at Pivotal is doing TDD already. Running so many > configurations sounds like it belongs in a CI not in a TDD cycle. It is in a CI - that doesn't mean I don't want us to aim towards the point where we're doing TDD as well. > I

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

Hi Dave, PFA updated patch for the same. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Feb 27, 2017 at 8:34 PM, Dave Page wrote: > Hi > > On Mon, Feb 27, 2017 at 10:25 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA patch

[pgadmin-hackers] pgAdmin 4 commit: Various fixes and cleanups to the Windows build scrip

Various fixes and cleanups to the Windows build script. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bc521dfc49a6d74bf4df8ec41db2f4c54616866d Modified Files -- Make.bat | 116 +++---

Re: [pgadmin-hackers] Patch from RM1983 [pgAdmin4]

Thanks Harshal. Ashesh, can you please review/commit this by EOD tomorrow please, making any required changes as needed? My queue is just too long at the moment - and we need it in as soon as possible to maximise testing time. Thanks. On Tue, Feb 28, 2017 at 7:54 AM, Harshal Dhumal wrote: > Hi,

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

Thanks Murtuza. Akshay, can you please review/commit this by EOD tomorrow please, making any required changes as needed? My queue is just too long at the moment - and we need it in as soon as possible to maximise testing time. Thanks. On Tue, Feb 28, 2017 at 10:33 AM, Murtuza Zabuawala wrote: >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] SlickGrid result set format efficiency

[Adding Akshay] On Tue, Feb 28, 2017 at 1:37 PM, Dave Page wrote: > Thanks Murtuza. > > Akshay, can you please review/commit this by EOD tomorrow please, > making any required changes as needed? My queue is just too long at > the moment - and we need it in as soon as possible to maximise testing

[pgadmin-hackers] pgAdmin 4 commit: Testsuite fixes for 9.3 and 9.2 support.

Testsuite fixes for 9.3 and 9.2 support. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f935d699e040f53a2bfb201ff54427c43974a26 Author: Navnath Gadakh Modified Files -- .../databases/casts/tests/test_cast_delete.py | 4 +- .

[pgadmin-hackers] pgAdmin 4 commit: Remove a debug message.

Remove a debug message. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2e000a371b60491f1aae06d4e01098d07f647b6 Author: Murtuza Zabuawala Modified Files -- .../servers/pgagent/schedules/templates/pga_schedule/js/pga_schedule.js |

Re: [pgadmin-hackers] [PATCH][pgAdmin4] Move Bootstrap fonts to 'vendor/fonts' folder

Hi On Tue, Feb 28, 2017 at 1:32 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to move bootstrap fonts to 'vender/fonts' folder as bootstrap.css > looking for them as > > > murtuza@vm:~/projects/pgadmin4$ grep -nr 'glyphicons' > *web/pgadmin/static/vendor/bootstrap/bootstrap.css:270: src: > ur

[pgadmin-hackers] pgAdmin 4 commit: Improve visibility of syntax highlighting colours. Fi

Improve visibility of syntax highlighting colours. Fixes #2215 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0cd914f3f9f9d28b14077e0b17bcc2d04175e0a0 Author: Atira Odhner Modified Files -- web/pgadmin/static/css/bootstrap.overrid

Re: [pgadmin-hackers][patch] Syntax Highlighting Color Change RM #2215

Thanks, patch applied. On Mon, Feb 27, 2017 at 11:04 PM, Atira Odhner wrote: > Hi Hackers, > > Here is a small css change to make the syntax highlighting more visible > color-wise. > > https://redmine.postgresql.org/issues/2215 >> >> As a query writer I want to be able to see the syntax highlight

Re: [pgadmin-hackers] Feature test issues

> > On my top-of-the-range-last-year Mac, startup takes about 14 seconds > per test - that's from the start of the test, until the point at which > the "Loading pgAdmin..." spinner vanishes. That includes the time it takes to load the page, not just app startup time. The spinner doesn't appear u

[pgadmin-hackers][patch] Use TEST_SQLITE_PATH for tests

Hi Hackers, Here is a change to ensure that the sqlite test instance is used for all the tests. This should help tests clean up server connections properly and prevent interference with running the app. Credit to Dave for pointing this issue out. Tira & Joao 0001-Use-TEST_SQLITE_PATH-for-tests

Re: [pgadmin-hackers] Feature test issues

On Tue, Feb 28, 2017 at 4:50 PM, Atira Odhner wrote: >> On my top-of-the-range-last-year Mac, startup takes about 14 seconds >> per test - that's from the start of the test, until the point at which >> the "Loading pgAdmin..." spinner vanishes. > > > That includes the time it takes to load the pag

[pgadmin-hackers] pgAdmin 4 commit: Further fixes and cleanups to the Windows build scrip

Further fixes and cleanups to the Windows build script, including some Python 3 compatibility changes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=76d5dccc46eb0ba6ceaa8e3765bede001e9df623 Modified Files -- Make.bat | 30 +++

[pgadmin-hackers] pgAdmin 4 commit: Ensure feature tests use the TEST_SQLITE_PATH, not SQ

Ensure feature tests use the TEST_SQLITE_PATH, not SQLITE_PATH. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5fa1e83f0a5d764152c35f76500e04bad1994923 Author: Atira Odhner Modified Files -- web/config.py

Re: [pgadmin-hackers][patch] Use TEST_SQLITE_PATH for tests

Thanks, patch applied. On Tue, Feb 28, 2017 at 4:56 PM, Atira Odhner wrote: > Hi Hackers, > > Here is a change to ensure that the sqlite test instance is used for all the > tests. This should help tests clean up server connections properly and > prevent interference with running the app. > > Cred

[pgadmin-hackers][patch] Make feature test app teardown more reliable, and tests faster

Hi Hackers, We made the following improvements to the test suite: Make feature test app teardown more reliable, and tests faster - don't spin up app and chromedriver between each test - catching signals also tears down the app - do layout reset between tests, but assume that tests wi