Hi Dave
On Mon, Mar 27, 2017 at 7:11 AM, Dave Page wrote:
> Hi
>
> I've found a bug with this. When you set either of the options to True
> for the very first time, then hit OK on the Preferences dialogue, the
> setting is not stored. You have to go back into Preferences and set it
> a second ti
Hi Dave,
I have fixed the issue and the patch for the same is attached, but the
Binary path options are not translated properly.
We register the preferences before the first request of the app. In this
case we don't have any language loaded, so it will take only English.
To fix this issue, I had
Hi,
The ascending/descending order is not working in the backgrid while
clicking on the headers.
If this functionality is required then please find the attached fix for the
same.
Thanks,
Khushboo
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
in
Hi
On Mon, Mar 27, 2017 at 12:15 AM, Navnath Gadakh
wrote:
> Hello Dave,
>
> On Fri, Mar 24, 2017 at 9:10 PM, Dave Page wrote:
>>
>> Hi
>>
>> On Fri, Mar 24, 2017 at 3:13 PM, Navnath Gadakh
>> wrote:
>> >
>> >> When running with the patch:
>> >>
>> >> 1) The browser isn't closed, and the script
Hi Khushboo,
Matt and I took a look at your patch and noticed that there is code
duplication between the lines you added and the preceding block of code.
Instead of repeating the code in the else block, why not just remove the if
condition?
Also, the BigNumber casting in the previous block seems
Hi Hackers!
We updated the documentation and included the ability to generate the
messages.pot files again. We changed the file and function from
translate.js to gettext.js to be consistent with Python and also to have it
automatically picked up without having to add extensions to Pybabel. See
pat
>
>
> Tira's various patches all seem to be flakey :-(:
Yes, that's because the way it was working before was to arbitrarily wait a
full second. My intent with the patches was not to apply them to the code,
but to demonstrate that the issue was not related to time spent loading js
files through r
On Mon, Mar 27, 2017 at 11:47 AM, Atira Odhner wrote:
>>
>> Tira's various patches all seem to be flakey :-(:
>
>
> Yes, that's because the way it was working before was to arbitrarily wait a
> full second. My intent with the patches was not to apply them to the code,
> but to demonstrate that the
>
> A change as large as moving to React will be for v2.x, not v1.x, so we
> cannot really wait unless we want to write off the feature tests as
> unusable for the forseeable future.
I don't think we should wait on moving the entire codebase to react before
releasing features that use it. React a
On Mon, Mar 27, 2017 at 12:05 PM, Atira Odhner wrote:
>> A change as large as moving to React will be for v2.x, not v1.x, so we
>> cannot really wait unless we want to write off the feature tests as
>> unusable for the forseeable future.
>
>
> I don't think we should wait on moving the entire code
Ensure preferences are properly saved the first time they're set.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=757500c478b170150afeb2dbd95254e695b34b5a
Author: Akshay Joshi
Modified Files
--
web/pgadmin/utils/preferences.py | 3
Thanks, committed.
On Mon, Mar 27, 2017 at 5:09 AM, Akshay Joshi wrote:
> Hi Dave
>
> On Mon, Mar 27, 2017 at 7:11 AM, Dave Page wrote:
>
>> Hi
>>
>> I've found a bug with this. When you set either of the options to True
>> for the very first time, then hit OK on the Preferences dialogue, the
>
Fix the bin path preferences.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=633d2ad28c22cddeb0281e6408135f41086600ce
Author: Khushboo Vashi
Modified Files
--
web/pgadmin/browser/server_groups/servers/types.py | 34 ++-
On Mon, Mar 27, 2017 at 7:49 AM, Khushboo Vashi
wrote:
> Hi Dave,
>
> I have fixed the issue and the patch for the same is attached, but the
> Binary path options are not translated properly.
Thanks - committed.
> We register the preferences before the first request of the app. In this
> case we
Ensure client-side translations are correctly extracted into the message
templates.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82bd97aed0be5f1c69c21dc1ac88570c0153e6bc
Author: Sarah McAlear
Modified Files
--
docs/en_US/transl
Hi
On Mon, Mar 27, 2017 at 11:33 AM, Sarah McAlear wrote:
> Hi Hackers!
>
> We updated the documentation and included the ability to generate the
> messages.pot files again. We changed the file and function from translate.js
> to gettext.js to be consistent with Python and also to have it automat
Hi Hackers,
Sorry about that, we attached the wrong patch file. Attaching the correct
one
Thanks
Joao & Sarah
On Mon, Mar 27, 2017 at 1:58 PM, Dave Page wrote:
> Hi
>
> On Mon, Mar 27, 2017 at 11:33 AM, Sarah McAlear
> wrote:
> > Hi Hackers!
> >
> > We updated the documentation and included th
>
>
> Maybe - I'd need to see a viable patch with minimal impact first though.
Sure, makes sense.
That'll only work to a point. What happens if the user installs a
> plugin to get some additional functionality? We still need the ability
> to ensure code can be added to an existing installation.
Hi
On Mon, Mar 27, 2017 at 2:06 PM, Sarah McAlear wrote:
> Hi Hackers,
> Sorry about that, we attached the wrong patch file. Attaching the correct
> one
It no longer errors, but it's still not working correctly - after
running an extract, there are no strings from about.js or dashboard.js
in the
Revert code cleanup that wasn't 2.6 compatible.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7450c2df0dc517c4ab6360a8fc2101fd63426844
Modified Files
--
web/pgadmin/utils/sqlautocomplete/function_metadata.py | 2 +-
1 file changed,
Revert "Ensure client-side translations are correctly extracted into the
message templates."
This reverts commit 82bd97aed0be5f1c69c21dc1ac88570c0153e6bc.
There are still issues extracting with these changes.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;
Treat doc build warnings as errors for CI purposes and correctness.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f19fc307b1955a8c17ca151376586f02557f65b3
Modified Files
--
docs/en_US/Makefile.sphinx | 2 +-
1 file changed, 1 inser
Hi Tira,
On Mon, Mar 27, 2017 at 9:00 PM, Atira Odhner wrote:
> Hi Khushboo,
>
> Matt and I took a look at your patch and noticed that there is code
> duplication between the lines you added and the preceding block of code.
>
> Instead of repeating the code in the else block, why not just remove
23 matches
Mail list logo
