Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

2017-06-09 Thread Surinder Kumar
Hi As the patch "Improvements to Query Results" ​ is merged, the columns width in edit grid needs some adjustments as 'checkboxes' are removed from columns. ​PFA patch.​ On Thu, Jun 8, 2017 at 5:12 PM, Dave Page wrote: > Nice! Thanks, patch applied. > > On Wed, Jun 7, 2017 at 4:03 PM, Surinder

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-09 Thread Dave Page
On Thu, Jun 8, 2017 at 7:31 PM, Sarah McAlear wrote: >> Thanks. When I run the tests my browser opens in some default size >> that's always consistent, but doesn't match my normal Chrome sessions, >> or the 1024x1024 default set in app_starter.py. > > > This looks like an issue with string edit bo

[pgadmin-hackers] pgAdmin 4 commit: Use the correct font for the treeview.

2017-06-09 Thread Dave Page
Use the correct font for the treeview. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee4a84778457e3ca022be4e2c7f730c98a5e3422 Author: Sarah McAlear Modified Files -- web/pgadmin/static/css/aci_tree.overrides.css | 4 web/pga

Re: [pgadmin-hackers][patch] Changing the ACI tree font to Helvetica

2017-06-09 Thread Dave Page
Thanks - I'm not 100% sure it's as easy to read as it was. Oddly, I wonder if the size needs reducing a little (to increase the whitespace around each label), but I think we need more eyes on it to decide if I'm just imagining that so I've committed it for now, and we can tweak later if needed. On

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-09 Thread Dave Page
Hi Ahh, now we have a bug. In the properties dialogues, if you edit a comment, as soon as the Save button gets enabled, hitting Return will Save the changes instead of adding a newline to the comment. That's clearly not right :-( On Fri, Jun 9, 2017 at 7:48 AM, Surinder Kumar wrote: > Hi > > Ple

[pgadmin-hackers] pgAdmin 4 commit: Fine tune result grid column sizing now we don't have

2017-06-09 Thread Dave Page
Fine tune result grid column sizing now we don't have checkboxes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=49976b193476c7626c305853c23cbf9a98af68e8 Author: Surinder Kumar Modified Files -- web/pgadmin/static/js/sqleditor_ut

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

2017-06-09 Thread Dave Page
Thanks, applied. On Fri, Jun 9, 2017 at 8:39 AM, Surinder Kumar wrote: > Hi > > As the patch "Improvements to Query Results" > is merged, the columns width in edit grid needs some adjustments as > 'checkboxes' are removed from columns. > > PFA patch. > > On Thu, Jun 8, 2017 at 5:12 PM, Dave Page

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-09 Thread Surinder Kumar
Hi PFA patch and review. On Fri, Jun 9, 2017 at 1:47 PM, Dave Page wrote: > Hi > > Ahh, now we have a bug. In the properties dialogues, if you edit a > comment, as soon as the Save button gets enabled, hitting Return will > Save the changes instead of adding a newline to the comment. That's >

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-09 Thread Surinder Kumar
Ignore previous patch as it doesn't contains new changes. Please find attached patch. On Fri, Jun 9, 2017 at 3:06 PM, Surinder Kumar wrote: > Hi > > PFA patch and review. > > > On Fri, Jun 9, 2017 at 1:47 PM, Dave Page wrote: > >> Hi >> >> Ahh, now we have a bug. In the properties dialogues, i

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server

2017-06-09 Thread Atul Sharma
Hi Dave, I have made the template search code to work for 10_plus directory name. Please review the attached patch Regards, Atul. On Thu, Jun 8, 2017 at 7:55 PM, Dave Page wrote: > Hi Atul, > > On Thu, Jun 8, 2017 at 3:03 PM, Atul Sharma > wrote: > > Hi, > > > > The issue is fixed now. Adde

Re: [pgadmin-hackers][patch] Changing the ACI tree font to Helvetica

2017-06-09 Thread Shirley Wang
I'm with you on that. I had to use the browser with Helvetica for about day before I could make a comparison with using Verdana. On Fri, Jun 9, 2017 at 4:11 AM Dave Page wrote: > Thanks - I'm not 100% sure it's as easy to read as it was. Oddly, I > wonder if the size needs reducing a little (to