Re: [pgadmin-support] pgAgent reports failure upon success

2012-07-10 Thread Martin French
Hipgadmin-support-ow...@postgresql.org wrote on 10/07/2012 16:05:18:> From: Dave Page > To: Martin French , > Cc: pgadmin-support@postgresql.org, pgadmin-support-ow...@postgresql.org> Date: 10/07/2012 19:12> Subject: Re: [pgadmin-support] pgAgent reports failure upon success> Sent by: pgadmin-suppo

Re: [pgadmin-support] pgAgent reports failure upon success

2012-07-10 Thread Dave Page
On Tue, Jul 10, 2012 at 1:57 PM, Martin French wrote: > Hi > > Thanks for the feedback. I certainly won't be discouraged by it! :) :-) >> - You have member name of [Get|Set]LastResult which set/return a >> member variable called lastStatus. These should be consistent to avoid >> confusion. > > W

Re: [pgadmin-support] pgAgent reports failure upon success

2012-07-10 Thread Martin French
HiThanks for the feedback. I certainly won't be discouraged by it! :)> - You have member name of [Get|Set]LastResult which set/return a> member variable called lastStatus. These should be consistent to avoid> confusion.Will amend accordingly.> - Rather than setting lastStatus to 0 or -1, why not se

Re: [pgadmin-support] pgAgent reports failure upon success

2012-07-10 Thread Dave Page
Hi On Mon, Jul 9, 2012 at 10:30 AM, Martin French wrote: > Apologies wrong files attached! It is Monday after all... ;o) > > > (See attached file: connection.cpp.patch)(See attached file: > connection.h.patch)(See attached file: job.cpp.patch) OK, first of all, thanks for the patch. Second; plea