Re: [PATCHES] [BUGS] BUG #2569: statement_timeout bug on Windows

2006-08-09 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Seems like this probably ought to round up not down: > I thought about that, but because statement_timeout is in millis, and > not micros, we can't have a value that gets rounded down. I am > thinking a cleaner solution is to check f

Re: [PATCHES] [BUGS] BUG #2569: statement_timeout bug on Windows

2006-08-09 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > ! /* WaitForSingleObjectEx() uses milliseconds */ > > ! waittime = timerCommArea.value.it_value.tv_usec > > / 1000 + timerCommArea.value.it_value.tv_sec * 1000; > > Seems like this

Re: [PATCHES] [BUGS] BUG #2569: statement_timeout bug on Windows

2006-08-09 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: ! /* WaitForSingleObjectEx() uses milliseconds */ > ! waittime = timerCommArea.value.it_value.tv_usec > / 1000 + timerCommArea.value.it_value.tv_sec * 1000; Seems like this probably ought to round

Re: [BUGS] BUG #2569: statement_timeout bug on Windows

2006-08-09 Thread Bruce Momjian
I have a big "Oops" for this item. Seems in 8.0, we used the Win32 call SetWaitableTimer(), which takes its timeout in 100 nanosecond intervals. This was changed to use WaitForSingleObjectEx() in 8.1, but not properly. The 8.0 code works fine. The attached patch will fix the problem, and will b

[BUGS] BUG #2569: statement_timeout bug on Windows

2006-08-08 Thread James
The following bug has been logged online: Bug reference: 2569 Logged by: James Email address: [EMAIL PROTECTED] PostgreSQL version: 8.1.4 Operating system: Windows 200 Pro SP4 Description:statement_timeout bug on Windows Details: I'm using the latest version of post