Re: [BUGS] BUG #5275: validate_exec in port/exec.c only reads u/g/o, not ACLs

2010-01-13 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> But we force those to be the same in main.c. Anyway there are several >> other uses of access() in the code ... > Yea, I am not saying the text is right, but rather why it was not > considered for use in that case. Actually, since that code has been un

Re: [BUGS] BUG #5275: validate_exec in port/exec.c only reads u/g/o, not ACLs

2010-01-13 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > I think access's reputation as something to avoid caused us not to look > > at it. My old BSD manual says about access(): > > > CAVEAT > > The access() function should be used rarely, if ever. Specifically, > > access() should never be used

Re: [BUGS] BUG #5275: validate_exec in port/exec.c only reads u/g/o, not ACLs

2010-01-13 Thread Tom Lane
Bruce Momjian writes: > I think access's reputation as something to avoid caused us not to look > at it. My old BSD manual says about access(): > CAVEAT > The access() function should be used rarely, if ever. Specifically, > access() should never be used by any program whose user real

Re: [BUGS] BUG #5275: validate_exec in port/exec.c only reads u/g/o, not ACLs

2010-01-13 Thread Bruce Momjian
Tom Lane wrote: > "James Bellinger" writes: > > I'm not certain of the actual *purpose* for this function even checking in > > the first place, but the result is that, if Postgres gets its access via an > > ACL, it will say 'invalid binary' here and there, will not be able to find > > its own exec

Re: [BUGS] BUG #5275: validate_exec in port/exec.c only reads u/g/o, not ACLs

2010-01-13 Thread Tom Lane
"James Bellinger" writes: > I'm not certain of the actual *purpose* for this function even checking in > the first place, but the result is that, if Postgres gets its access via an > ACL, it will say 'invalid binary' here and there, will not be able to find > its own executables, etc. I can see no

[BUGS] BUG #5275: validate_exec in port/exec.c only reads u/g/o, not ACLs

2010-01-13 Thread James Bellinger
The following bug has been logged online: Bug reference: 5275 Logged by: James Bellinger Email address: j...@zer7.com PostgreSQL version: 8.4.2 Operating system: Ubuntu 9.10 Description:validate_exec in port/exec.c only reads u/g/o, not ACLs Details: Howdy, I'm not