Re: [BUGS] BUG #5394: invalid declspec for PG_MODULE_MAGIC

2010-04-07 Thread Magnus Hagander
On Tue, Apr 6, 2010 at 21:55, Tom Lane wrote: > Magnus Hagander writes: >> On Mon, Mar 29, 2010 at 11:47 AM, Takahiro Itagaki >> wrote: >>> A patch attached. The name of "PGMODULEEXPORT" might be arguable. > >> I agree with this in principle, but won't this break every single >> add-on module ou

Re: [BUGS] BUG #5394: invalid declspec for PG_MODULE_MAGIC

2010-04-06 Thread Tom Lane
Magnus Hagander writes: > On Mon, Mar 29, 2010 at 11:47 AM, Takahiro Itagaki > wrote: >> A patch attached. The name of "PGMODULEEXPORT" might be arguable. > I agree with this in principle, but won't this break every single > add-on module out there that supports Win32? The patch didn't touch th

Re: [BUGS] BUG #5394: invalid declspec for PG_MODULE_MAGIC

2010-04-06 Thread Magnus Hagander
On Mon, Mar 29, 2010 at 11:47 AM, Takahiro Itagaki wrote: > > "Vladimir Barzionov" wrote: > >> Same problem was already discussed for example here >> http://dbaspot.com/forums/postgresql/393683-re-general-custom-c-function-palloc-broken.html >> >> Looks like the simplest way for correcting the is

Re: [BUGS] BUG #5394: invalid declspec for PG_MODULE_MAGIC

2010-03-29 Thread Takahiro Itagaki
"Vladimir Barzionov" wrote: > Same problem was already discussed for example here > http://dbaspot.com/forums/postgresql/393683-re-general-custom-c-function-palloc-broken.html > > Looks like the simplest way for correcting the issue is declaring additional > macro (something like PGMODULEEXPORT