Re: [BUGS] BUG #5952: SetRWConflict assertion failure

2011-04-05 Thread Robert Haas
On Tue, Apr 5, 2011 at 12:13 PM, Kevin Grittner wrote: > I wrote: >> Robert Haas wrote: >> >>> If you could send a revised patch, that would be great. >> >> Attached.  I put it in the same spot relative to the lock >> acquisition that was used earlier in the function. > > And version 3 which migh

Re: [BUGS] BUG #5952: SetRWConflict assertion failure

2011-04-05 Thread Kevin Grittner
I wrote: > Robert Haas wrote: > >> If you could send a revised patch, that would be great. > > Attached. I put it in the same spot relative to the lock > acquisition that was used earlier in the function. And version 3 which might actually work. [sigh] -Kevin *** a/src/backend/storage/l

Re: [BUGS] BUG #5952: SetRWConflict assertion failure

2011-04-05 Thread Kevin Grittner
Robert Haas wrote: > If you could send a revised patch, that would be great. Attached. I put it in the same spot relative to the lock acquisition that was used earlier in the function. -Kevin *** a/src/backend/storage/lmgr/predicate.c --- b/src/backend/storage/lmgr/predicate.c

Re: [BUGS] BUG #5952: SetRWConflict assertion failure

2011-04-05 Thread Robert Haas
On Tue, Apr 5, 2011 at 11:18 AM, Kevin Grittner wrote: > Robert Haas wrote: >> This patch looks reasonable, but I'm a bit concerned about the >> chunk immediately preceding the patched area. >> >> When we do this: >> >>     LWLockRelease(SerializableXactHashLock); >>     LWLockRelease(partitionLo

Re: [BUGS] BUG #5952: SetRWConflict assertion failure

2011-04-05 Thread Kevin Grittner
Robert Haas wrote: > This patch looks reasonable, but I'm a bit concerned about the > chunk immediately preceding the patched area. > > When we do this: > > LWLockRelease(SerializableXactHashLock); > LWLockRelease(partitionLock); > LWLockRelease(SerializablePredicateLockListLock);

Re: [BUGS] BUG #5952: SetRWConflict assertion failure

2011-04-05 Thread Robert Haas
On Sun, Mar 27, 2011 at 3:18 PM, Kevin Grittner wrote: > "YAMAMOTO Takashi"  wrote: > >> Description: SetRWConflict assertion failure > >> SerializableXactHashLock relocking in CheckTargetForConflictsIn() >> seems racy to me. > > You're right.  The attached patch should fix the assertion you hit.

Re: [BUGS] BUG #5952: SetRWConflict assertion failure

2011-03-27 Thread Kevin Grittner
"YAMAMOTO Takashi" wrote: > Description: SetRWConflict assertion failure > SerializableXactHashLock relocking in CheckTargetForConflictsIn() > seems racy to me. You're right. The attached patch should fix the assertion you hit. I will take a close look at the code above the patched area (

[BUGS] BUG #5952: SetRWConflict assertion failure

2011-03-26 Thread YAMAMOTO Takashi
The following bug has been logged online: Bug reference: 5952 Logged by: YAMAMOTO Takashi Email address: y...@mwd.biglobe.ne.jp PostgreSQL version: 9.1devel Operating system: NetBSD Description:SetRWConflict assertion failure Details: i got the following assertion f