Noah Misch escribió:
Following an off-list ack from Alexander, here is that version. No functional
differences from Alexander's latest version, and I have verified that it still
fixes the original test case. I'm marking this Ready for Committer.
This seems good to me, but I'm not
On Sun, Oct 14, 2012 at 10:35:04AM +0400, Alexander Law wrote:
I agree with you, CONOUT$ way is much simpler. Please look at the patch.
See comments below.
Regarding msys - yes, that check was not correct.
In fact you can use con with msys, if you run sh.exe, not a graphical
terminal.
So
On Sun, Oct 14, 2012 at 12:10:42PM -0400, Tom Lane wrote:
Alexander Law exclus...@gmail.com writes:
+#ifdef WIN32
+ termin = fopen(CONIN$, r);
+ termout = fopen(CONOUT$, w+);
+#else
termin = fopen(DEVTTY, r);
termout = fopen(DEVTTY, w);
+#endif
if (!termin ||
On Mon, Oct 15, 2012 at 05:41:36AM -0400, Noah Misch wrote:
--- a/src/port/sprompt.c
+++ b/src/port/sprompt.c
@@ -60,8 +60,13 @@ simple_prompt(const char *prompt, int maxlen, bool echo)
* Do not try to collapse these into one w+ mode file. Doesn't work on
* some platforms (eg,
Hi Noah,
Thank you for your review.
I agree with you, CONOUT$ way is much simpler. Please look at the patch.
Regarding msys - yes, that check was not correct.
In fact you can use con with msys, if you run sh.exe, not a graphical
terminal.
So the issue with con not related to msys, but to some
Alexander Law exclus...@gmail.com writes:
+#ifdef WIN32
+ termin = fopen(CONIN$, r);
+ termout = fopen(CONOUT$, w+);
+#else
termin = fopen(DEVTTY, r);
termout = fopen(DEVTTY, w);
+#endif
if (!termin || !termout
My immediate reaction to this patch is that's a
Hi Alexander,
I was able to reproduce the problem based on your description and test case,
and your change does resolve it for me.
On Tue, Mar 20, 2012 at 11:50:14PM +0400, Alexander LAW wrote:
Thanks, I've understood your point.
Please look at the patch. It implements the first way and it
Excerpts from Alexander LAW's message of mar mar 20 16:50:14 -0300 2012:
Thanks, I've understood your point.
Please look at the patch. It implements the first way and it makes psql
work too.
Great, thanks. Hopefully somebody with Windows-compile abilities will
have a look at this.
--
Thanks, I've understood your point.
Please look at the patch. It implements the first way and it makes psql
work too.
Regards,
Alexander
20.03.2012 00:05, Alvaro Herrera пишет:
Excerpts from Alexander LAW's message of dom mar 18 06:04:51 -0300 2012:
I see two ways to resolve the issue.
Excerpts from Alexander LAW's message of dom mar 18 06:04:51 -0300 2012:
I see two ways to resolve the issue.
First is to use CharToOemBuff when writing a string to the con and
OemToCharBuff when reading an input from it.
The other is to always use stderr/stdin for Win32 as it was done for
I see two ways to resolve the issue.
First is to use CharToOemBuff when writing a string to the con and
OemToCharBuff when reading an input from it.
The other is to always use stderr/stdin for Win32 as it was done for
msys before. I think it's more straightforward.
I tested the attached patch
Excerpts from exclusion's message of sáb mar 03 15:44:37 -0300 2012:
I'm using postgresSQL in Windows with Russian locale and get unreadable
messages when the postgres utilities prompting me for input.
Please look at the screenshot:
http://oi44.tinypic.com/aotje8.jpg
(The psql writes the
The following bug has been logged on the website:
Bug reference: 6510
Logged by: Alexander LAW
Email address: exclus...@gmail.com
PostgreSQL version: 9.1.3
Operating system: Windows
Description:
I'm using postgresSQL in Windows with Russian locale and get unreadable
13 matches
Mail list logo
