Re: [BUGS] setseed accepts bad seeds

2008-03-10 Thread Kris Jurka
On Mon, 10 Mar 2008, Tom Lane wrote: I'd be inclined to leave the mapping alone and just insert a warning (or hard error) for inputs outside the range -1 to 1. Here's a patch that errors out for out of range values. Kris JurkaIndex: doc/src/sgml/func.sgml

Re: [BUGS] setseed accepts bad seeds

2008-03-10 Thread Tom Lane
Kris Jurka [EMAIL PROTECTED] writes: On Mon, 10 Mar 2008, Tom Lane wrote: I'd be inclined to leave the mapping alone and just insert a warning (or hard error) for inputs outside the range -1 to 1. Here's a patch that errors out for out of range values. Applied, thanks.

Re: [BUGS] setseed accepts bad seeds

2008-03-09 Thread Tom Lane
Kris Jurka [EMAIL PROTECTED] writes: On Wed, 11 Apr 2007, Tom Lane wrote: It's not really possible to use it incorrectly, AFAICS. Any value you might pass to it will result in a specific new seed value. Nowhere is there any guarantee of what the mapping is, and it's obviously impossible to

Re: [BUGS] setseed accepts bad seeds

2007-04-26 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Kris Jurka wrote: On Wed, 11 Apr 2007, Tom Lane wrote: It's not really possible to use it incorrectly,

Re: [BUGS] setseed accepts bad seeds

2007-04-11 Thread Tom Lane
Kris Jurka [EMAIL PROTECTED] writes: Why doesn't setseed complain when given a seed value outside of its expected range? Why should it complain? The use of the value is totally unspecified anyway. regards, tom lane ---(end of

Re: [BUGS] setseed accepts bad seeds

2007-04-11 Thread Kris Jurka
On Wed, 11 Apr 2007, Tom Lane wrote: Kris Jurka [EMAIL PROTECTED] writes: Why doesn't setseed complain when given a seed value outside of its expected range? Why should it complain? The use of the value is totally unspecified anyway. Because the user is likely using it incorrectly.

Re: [BUGS] setseed accepts bad seeds

2007-04-11 Thread Tom Lane
Kris Jurka [EMAIL PROTECTED] writes: On Wed, 11 Apr 2007, Tom Lane wrote: Kris Jurka [EMAIL PROTECTED] writes: Why doesn't setseed complain when given a seed value outside of its expected range? Why should it complain? The use of the value is totally unspecified anyway. Because the user

Re: [BUGS] setseed accepts bad seeds

2007-04-11 Thread Kris Jurka
On Wed, 11 Apr 2007, Tom Lane wrote: It's not really possible to use it incorrectly, AFAICS. Any value you might pass to it will result in a specific new seed value. Nowhere is there any guarantee of what the mapping is, and it's obviously impossible to guarantee that the mapping is