pgsql: Update postgresql.conf.sample comment for bgwriter_lru_maxpages

2017-11-17 Thread Robert Haas
Update postgresql.conf.sample comment for bgwriter_lru_maxpages Commit 14ca9abfbe4643408ad6ed3279f2f6366cafb3f1 should have done this, but did not. Jeff Janes Discussion: http://postgr.es/m/CAMkU=1ywovl+yfyzgm9yxsowjxr_5_ny78ppzlkqckfgb7h...@mail.gmail.com Branch -- master Details ---

Re: pgsql: Remove BufFile's isTemp flag.

2017-11-17 Thread Tom Lane
Andres Freund writes: > On 2017-11-17 11:23:54 -0500, Tom Lane wrote: >> Or maybe we should revert 11e264517. It doesn't seem to be buying >> much to make up for the loss of flexibility. > There's a bunch of work adding new functionality to buffile.c > pending. And having code paths that have be

Re: pgsql: Remove BufFile's isTemp flag.

2017-11-17 Thread Andres Freund
Hi, On 2017-11-17 11:23:54 -0500, Tom Lane wrote: > OK, after looking through the history, the reason for isTemp = false > is indeed to allow BufFileCreate() to maintain its old semantics, > wherein you could attach a BufFile to an already-existing, possibly > non-temp file. There have not been a

pgsql: Remove contrib/start-scripts/osx/.

2017-11-17 Thread Tom Lane
Remove contrib/start-scripts/osx/. Since those scripts haven't worked at all in macOS releases of 2014 and later, and aren't the recommended way to do it on any release since 2005, there seems little point carrying them into the future. It's very unlikely that anyone would be installing PG >= 11 o

Re: pgsql: Remove BufFile's isTemp flag.

2017-11-17 Thread Peter Geoghegan
On Fri, Nov 17, 2017 at 8:23 AM, Tom Lane wrote: > We should flat-out remove the function, since this change makes it > impossible to resurrect with its old semantics. I wonder whether > we should then rename BufFileCreateTemp to just BufFileCreate, > since it's no longer possible to have a BufFi

pgsql: Provide modern examples of how to auto-start Postgres on macOS.

2017-11-17 Thread Tom Lane
Provide modern examples of how to auto-start Postgres on macOS. The scripts in contrib/start-scripts/osx don't work at all on macOS 10.10 (Yosemite) or later, because they depend on SystemStarter which Apple deprecated long ago and removed in 10.10. Add a new subdirectory contrib/start-scripts/ma

pgsql: Provide modern examples of how to auto-start Postgres on macOS.

2017-11-17 Thread Tom Lane
Provide modern examples of how to auto-start Postgres on macOS. The scripts in contrib/start-scripts/osx don't work at all on macOS 10.10 (Yosemite) or later, because they depend on SystemStarter which Apple deprecated long ago and removed in 10.10. Add a new subdirectory contrib/start-scripts/ma

pgsql: Provide modern examples of how to auto-start Postgres on macOS.

2017-11-17 Thread Tom Lane
Provide modern examples of how to auto-start Postgres on macOS. The scripts in contrib/start-scripts/osx don't work at all on macOS 10.10 (Yosemite) or later, because they depend on SystemStarter which Apple deprecated long ago and removed in 10.10. Add a new subdirectory contrib/start-scripts/ma

pgsql: Provide modern examples of how to auto-start Postgres on macOS.

2017-11-17 Thread Tom Lane
Provide modern examples of how to auto-start Postgres on macOS. The scripts in contrib/start-scripts/osx don't work at all on macOS 10.10 (Yosemite) or later, because they depend on SystemStarter which Apple deprecated long ago and removed in 10.10. Add a new subdirectory contrib/start-scripts/ma

pgsql: Provide modern examples of how to auto-start Postgres on macOS.

2017-11-17 Thread Tom Lane
Provide modern examples of how to auto-start Postgres on macOS. The scripts in contrib/start-scripts/osx don't work at all on macOS 10.10 (Yosemite) or later, because they depend on SystemStarter which Apple deprecated long ago and removed in 10.10. Add a new subdirectory contrib/start-scripts/ma

pgsql: Provide modern examples of how to auto-start Postgres on macOS.

2017-11-17 Thread Tom Lane
Provide modern examples of how to auto-start Postgres on macOS. The scripts in contrib/start-scripts/osx don't work at all on macOS 10.10 (Yosemite) or later, because they depend on SystemStarter which Apple deprecated long ago and removed in 10.10. Add a new subdirectory contrib/start-scripts/ma

pgsql: Prevent to_number() from losing data when template doesn't match

2017-11-17 Thread Tom Lane
Prevent to_number() from losing data when template doesn't match exactly. Non-data template patterns would consume characters whether or not those characters were what the pattern expected, for example SELECT TO_NUMBER('1234', '9,999'); produced 134 because the '2' got eaten by the comma p

pgsql: Set proargmodes for satisfies_hash_partition.

2017-11-17 Thread Robert Haas
Set proargmodes for satisfies_hash_partition. It appears that proargmodes should always be set for variadic functions, but satifies_hash_partition had it as NULL. In addition to fixing the problem, add a regression test to guard against future mistakes of this type. Branch -- master Details

Re: pgsql: Remove BufFile's isTemp flag.

2017-11-17 Thread Tom Lane
I wrote: > Andres Freund writes: >> On 2017-11-16 21:58:14 -0500, Tom Lane wrote: >>> [ squint... ] That used to have an actual purpose connected to >>> transaction-abort cleanup, IIRC. It disturbs me that this seems >>> to have been lost. >> I've not found any such use, searching through buffi