Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Simon Riggs
On 19 November 2017 at 20:30, Tom Lane wrote: > Andres Freund writes: >> On 2017-11-19 19:49:01 -0500, Tom Lane wrote: >>> TBH, I would just remove those test cases. Even if they were stable >>> across platforms, they don't directly prove anything at all about >>> whether the feature does what i

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Simon Riggs
On 19 November 2017 at 19:52, Andres Freund wrote: > On 2017-11-19 19:49:01 -0500, Tom Lane wrote: >> Andres Freund writes: >> > On 2017-11-19 19:08:48 -0500, Simon Riggs wrote: >> >> Am investigating the few buildfarm failures >> >> > The tests look very sensitive to differences in tuple size du

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Tom Lane
Andres Freund writes: > On 2017-11-19 19:49:01 -0500, Tom Lane wrote: >> TBH, I would just remove those test cases. Even if they were stable >> across platforms, they don't directly prove anything at all about >> whether the feature does what it's supposed to. > I think it might make sense to re

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Simon Riggs
On 19 November 2017 at 19:49, Tom Lane wrote: > Andres Freund writes: >> On 2017-11-19 19:08:48 -0500, Simon Riggs wrote: >>> Am investigating the few buildfarm failures > >> The tests look very sensitive to differences in tuple size due to >> different alignment requirements. Dependant on what M

pgsql: Reduce test variability for toast_tuple_target test

2017-11-19 Thread Simon Riggs
Reduce test variability for toast_tuple_target test Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/56f34686220731eef72dfd129519b25f28406db1 Modified Files -- src/test/regress/expected/strings.out | 50 ++- src/test/regress

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Andres Freund
On 2017-11-19 19:49:01 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2017-11-19 19:08:48 -0500, Simon Riggs wrote: > >> Am investigating the few buildfarm failures > > > The tests look very sensitive to differences in tuple size due to > > different alignment requirements. Dependant on wh

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Tom Lane
Andres Freund writes: > On 2017-11-19 19:08:48 -0500, Simon Riggs wrote: >> Am investigating the few buildfarm failures > The tests look very sensitive to differences in tuple size due to > different alignment requirements. Dependant on what MAXALIGN (and some > others) is the number of tuples fi

Re: pgsql: Remove BufFile's isTemp flag.

2017-11-19 Thread Tom Lane
Andres Freund writes: > On 2017-11-19 17:00:36 -0500, Tom Lane wrote: >> No, but if you're concerned about it, we could maintain API compatibility >> for extensions with something like >> #define BufFileCreateTemp(interXact) BufFileCreate(interXact) > I don't really see a point in doing this rena

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Andres Freund
On 2017-11-19 19:08:48 -0500, Simon Riggs wrote: > On 19 November 2017 at 17:52, Simon Riggs wrote: > > Parameter toast_tuple_target controls TOAST for new rows > > > > Specifies the point at which we try to move long column values > > into TOAST tables. > > > > No effect on existing rows. > > > >

Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Simon Riggs
On 19 November 2017 at 17:52, Simon Riggs wrote: > Parameter toast_tuple_target controls TOAST for new rows > > Specifies the point at which we try to move long column values > into TOAST tables. > > No effect on existing rows. > > Discussion: > https://postgr.es/m/CANP8+jKsVmw6CX6YP9z7zqkTzcKV1+

Re: pgsql: Remove BufFile's isTemp flag.

2017-11-19 Thread Andres Freund
On 2017-11-19 17:00:36 -0500, Tom Lane wrote: > Thomas Munro writes: > >> On 2017-11-17 11:23:54 -0500, Tom Lane wrote: > >>> I wonder whether we should then rename BufFileCreateTemp to just > >>> BufFileCreate, since it's no longer possible to have a BufFile that > >>> isn't temp. > > > Here's a

pgsql: Parameter toast_tuple_target controls TOAST for new rows

2017-11-19 Thread Simon Riggs
Parameter toast_tuple_target controls TOAST for new rows Specifies the point at which we try to move long column values into TOAST tables. No effect on existing rows. Discussion: https://postgr.es/m/CANP8+jKsVmw6CX6YP9z7zqkTzcKV1+Uzr3XjKcZW=2ya00o...@mail.gmail.com Author: Simon Riggs Reviewe

Re: pgsql: Remove BufFile's isTemp flag.

2017-11-19 Thread Tom Lane
Thomas Munro writes: >> On 2017-11-17 11:23:54 -0500, Tom Lane wrote: >>> I wonder whether we should then rename BufFileCreateTemp to just >>> BufFileCreate, since it's no longer possible to have a BufFile that >>> isn't temp. > Here's a patch that does those things. I'm slightly surprised by th

Re: pgsql: Remove BufFile's isTemp flag.

2017-11-19 Thread Thomas Munro
On Sat, Nov 18, 2017 at 6:58 AM, Andres Freund wrote: > On 2017-11-17 11:23:54 -0500, Tom Lane wrote: >> OK, after looking through the history, the reason for isTemp = false >> is indeed to allow BufFileCreate() to maintain its old semantics, >> wherein you could attach a BufFile to an already-exi