pgsql: Tweak tests to support Python 3.7

2018-05-05 Thread Peter Eisentraut
Tweak tests to support Python 3.7 Python 3.7 removes the trailing comma in the repr() of BaseException (see ), leading to test output differences. Work around that by composing the equivalent test output in a more manual way. Branch -- REL9_3_STABLE

pgsql: Tweak tests to support Python 3.7

2018-05-05 Thread Peter Eisentraut
Tweak tests to support Python 3.7 Python 3.7 removes the trailing comma in the repr() of BaseException (see ), leading to test output differences. Work around that by composing the equivalent test output in a more manual way. Branch -- REL9_6_STABLE

pgsql: Tweak tests to support Python 3.7

2018-05-05 Thread Peter Eisentraut
Tweak tests to support Python 3.7 Python 3.7 removes the trailing comma in the repr() of BaseException (see ), leading to test output differences. Work around that by composing the equivalent test output in a more manual way. Branch -- REL9_4_STABLE

pgsql: Tweak tests to support Python 3.7

2018-05-05 Thread Peter Eisentraut
Tweak tests to support Python 3.7 Python 3.7 removes the trailing comma in the repr() of BaseException (see ), leading to test output differences. Work around that by composing the equivalent test output in a more manual way. Branch -- REL9_5_STABLE

pgsql: Tweak tests to support Python 3.7

2018-05-05 Thread Peter Eisentraut
Tweak tests to support Python 3.7 Python 3.7 removes the trailing comma in the repr() of BaseException (see ), leading to test output differences. Work around that by composing the equivalent test output in a more manual way. Branch -- REL_10_STABLE

pgsql: Fix bootstrap parser so that its keywords are unreserved words.

2018-05-05 Thread Tom Lane
Fix bootstrap parser so that its keywords are unreserved words. Mark Dilger pointed out that the bootstrap parser does not allow any of its keywords to appear as column values unless they're quoted, and proposed dealing with that by quoting such values in genbki.pl. Looking closer, though, we

Re: pgsql: Test conversion of NaN between float4 and float8.

2018-05-05 Thread Tom Lane
Glyn Astill writes: > Apologies Tom, I missed this; opossum is running one of its infrequent build > runs now. Thanks! I've pushed something I think will fix it, so please launch another HEAD run, if you're scheduling that manually. regards, tom

pgsql: Revert "Test conversion of NaN between float4 and float8."

2018-05-05 Thread Tom Lane
Revert "Test conversion of NaN between float4 and float8." This reverts commit 55e0e458170c76c1a0074cd550a13ec47e38a3fa. It's served its purpose of demonstrating what was wrong on buildfarm member opossum. We could consider putting some kind of single-purpose hack into ftod() to make the test

pgsql: Remove extra newlines after PQerrorMessage()

2018-05-05 Thread Peter Eisentraut
Remove extra newlines after PQerrorMessage() Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3a934331722a8d65242e9a39aa5533a58f3b7d17 Modified Files -- src/bin/pg_basebackup/streamutil.c | 2 +- src/bin/pg_dump/pg_dumpall.c | 2 +- 2 files

pgsql: Remove extra newlines after PQerrorMessage()

2018-05-05 Thread Peter Eisentraut
Remove extra newlines after PQerrorMessage() Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7ff50cf60b20fa8c333e427f5e61b59f913844fe Modified Files -- src/bin/pg_basebackup/streamutil.c | 2 +- src/bin/pg_dump/pg_dumpall.c | 2 +- 2 files

pgsql: Remove extra newlines after PQerrorMessage()

2018-05-05 Thread Peter Eisentraut
Remove extra newlines after PQerrorMessage() Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4f90e0ffe7a5c9c8b22a22e1caf05b6a3cbdbae6 Modified Files -- src/bin/pg_dump/pg_dumpall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Remove extra newlines after PQerrorMessage()

2018-05-05 Thread Peter Eisentraut
Remove extra newlines after PQerrorMessage() Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2f52518773bb01384ef20831fd9d8c76dbd59dc5 Modified Files -- src/bin/pg_basebackup/streamutil.c | 6 +++--- src/bin/pg_dump/pg_dumpall.c | 2 +- 2 files

pgsql: Remove extra newlines after PQerrorMessage()

2018-05-05 Thread Peter Eisentraut
Remove extra newlines after PQerrorMessage() Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0ebb3a4e16d246c8749a1e6e3e59e9db3e408200 Modified Files -- src/bin/pg_basebackup/streamutil.c | 2 +- src/bin/pg_dump/pg_dumpall.c | 2 +- 2 files

pgsql: Remove extra newlines after PQerrorMessage()

2018-05-05 Thread Peter Eisentraut
Remove extra newlines after PQerrorMessage() Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/280cf0fe789d8ea2fdc3b8e374bfd82f674264de Modified Files -- src/bin/pg_basebackup/streamutil.c | 2 +- src/bin/pg_dump/pg_dumpall.c | 2 +- 2 files

Re: pgsql: Fix precedence problem in new Perl code.

2018-05-05 Thread Andrew Dunstan
On Fri, May 4, 2018 at 5:28 PM, Mike Blackwell wrote: > I didn't see a .perlcriticrc file in the project, so ran with our local > settings. > > With those, perlcritic is pretty unhappy, even at -4, though I don't see > anything that pops out as potentially bug-inducing.