pgsql: Improve jsonb cast error message

2018-05-09 Thread Teodor Sigaev
Improve jsonb cast error message Initial variant of error message didn't follow style of another casting error messages and wasn't informative. Per gripe from Robert Haas. Reviewer: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/CA%2BTgmob08StTV9yu04D0idRFNMh%2BUoyKax5Otvrix7rEZ

pgsql: Add a script and a config file to run perlcritic

2018-05-09 Thread Andrew Dunstan
Add a script and a config file to run perlcritic This is similar to what we do to run perltidy. For now we only run at severity level 5. Over time we can improve our perl code and reduce the severity level. Discussion: https://postgr.es/m/86aa2a3a-0c68-21fb-9560-84ad6914d...@2ndquadrant.com Bra

pgsql: Remove useless 'default' clause

2018-05-09 Thread Alvaro Herrera
Remove useless 'default' clause Author: Michael Paquier Reviewed-by: Amit Langote Reviewed-by: Álvaro Herrera Discussion: https://postgr.es/m/20180424012042.gd1...@paquier.xyz Discussion: https://postgr.es/m/20180509061039.gc11...@paquier.xyz Branch -- master Details --- https://git.post

pgsql: Make gen_partprune_steps static

2018-05-09 Thread Alvaro Herrera
Make gen_partprune_steps static There's no need to export this function, so don't. Michaël didn't actually write the patch, but we list him as first author because with a trivial one like this, intellectual authorship is as important (if not more) as bit shovelling. Author: Michaël Paquier, Amit

pgsql: Restrict vertical tightness to parentheses in Perl code

2018-05-09 Thread Andrew Dunstan
Restrict vertical tightness to parentheses in Perl code The vertical tightness settings collapse vertical whitespace between opening and closing brackets (parentheses, square brakets and braces). This can make data structures in particular harder to read, and is not very consistent with our style

pgsql: perltidy some recent code changes before changing perltidy setti

2018-05-09 Thread Andrew Dunstan
perltidy some recent code changes before changing perltidy settings Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/286bb240e1c8e279efa2d805c7f700abfb771925 Modified Files -- src/backend/catalog/Catalog.pm | 2 +- src/tools/msvc/Install.pm | 10

pgsql: Fix assorted partition pruning bugs

2018-05-09 Thread Alvaro Herrera
Fix assorted partition pruning bugs match_clause_to_partition_key failed to consider COERCION_PATH_ARRAYCOERCE cases in scalar-op-array expressions, so it was possible to crash the server easily. To handle this case properly (ie. prune partitions) we would need to run a bit of executor code durin

pgsql: pgstatindex: HASH -> hash

2018-05-09 Thread Alvaro Herrera
pgstatindex: HASH -> hash Fix the lone error message in the whole source tree to use capitalized HASH when referring to hash indexes, making it look like all the other messages. Someday it would be good to standardize 'B-Tree', 'B-tree', 'btree', and random other spellings, too, but that's a larg

pgsql: Add relkind 'I' to catalog.sgml's list relkinds

2018-05-09 Thread Alvaro Herrera
Add relkind 'I' to catalog.sgml's list relkinds Commit 8b08f7d4820f added a relkind for local partitioned indexes, but failed to add it to pg_class's list of possible relkinds. Repair. Author: Peter Geoghegan, Michaël Paquier Discussion: https://postgr.es/m/cah2-wzkokptqie51bh4_xeehhabwhkzkgtki

pgsql: pgstatindex, pageinspect: handle partitioned indexes

2018-05-09 Thread Alvaro Herrera
pgstatindex, pageinspect: handle partitioned indexes Commit 8b08f7d4820f failed to update these modules to at least give non-broken error messages for partitioned indexes. Add appropriate error support to them. Peter G. was complaining about a problem of unfriendly error messages; while we haven

pgsql: Update time zone data files to tzdata release 2018e.

2018-05-09 Thread Tom Lane
Update time zone data files to tzdata release 2018e. DST law changes in North Korea. Redefinition of "daylight savings" in Ireland, as well as for some past years in Namibia and Czechoslovakia. Additional historical corrections for Czechoslovakia. With this change, the IANA database models Irish

pgsql: Update time zone data files to tzdata release 2018e.

2018-05-09 Thread Tom Lane
Update time zone data files to tzdata release 2018e. DST law changes in North Korea. Redefinition of "daylight savings" in Ireland, as well as for some past years in Namibia and Czechoslovakia. Additional historical corrections for Czechoslovakia. With this change, the IANA database models Irish

pgsql: Update time zone data files to tzdata release 2018e.

2018-05-09 Thread Tom Lane
Update time zone data files to tzdata release 2018e. DST law changes in North Korea. Redefinition of "daylight savings" in Ireland, as well as for some past years in Namibia and Czechoslovakia. Additional historical corrections for Czechoslovakia. With this change, the IANA database models Irish

pgsql: Update time zone data files to tzdata release 2018e.

2018-05-09 Thread Tom Lane
Update time zone data files to tzdata release 2018e. DST law changes in North Korea. Redefinition of "daylight savings" in Ireland, as well as for some past years in Namibia and Czechoslovakia. Additional historical corrections for Czechoslovakia. With this change, the IANA database models Irish

pgsql: Update time zone data files to tzdata release 2018e.

2018-05-09 Thread Tom Lane
Update time zone data files to tzdata release 2018e. DST law changes in North Korea. Redefinition of "daylight savings" in Ireland, as well as for some past years in Namibia and Czechoslovakia. Additional historical corrections for Czechoslovakia. With this change, the IANA database models Irish

pgsql: Update time zone data files to tzdata release 2018e.

2018-05-09 Thread Tom Lane
Update time zone data files to tzdata release 2018e. DST law changes in North Korea. Redefinition of "daylight savings" in Ireland, as well as for some past years in Namibia and Czechoslovakia. Additional historical corrections for Czechoslovakia. With this change, the IANA database models Irish

pgsql: doc: Restrictions on InitPlans in parallel queries relaxed.

2018-05-09 Thread Robert Haas
doc: Restrictions on InitPlans in parallel queries relaxed. This updates the documentation for changes originally made in commit e89a71fb449af2ef74f47be1175f99956cf21524. Patch by me, reviewed (but not entirely endorsed) by Amit Kapila. Discussion: http://postgr.es/m/CA+Tgmoa+vupW8V_gBonz6hU7Ww