Re: pgsql: Fix crash when ALTER TABLE recreates indexes on partitions

2018-06-29 Thread Tom Lane
Alvaro Herrera writes: > Fix crash when ALTER TABLE recreates indexes on partitions So ... buildfarm member skink has been reporting a valgrind failure during initdb since this patch went in. However, I'm unable to reproduce such a failure here, and it's less than obvious how this particular pat

Re: Tips on committing

2018-06-29 Thread Bruce Momjian
On Thu, Jun 28, 2018 at 09:46:17AM -0700, Peter Geoghegan wrote: > * Don't assume that you haven't broken the doc build if you make even > a trivial doc change. Removing a GUC can break instances in the > release notes where they're referenced. Even grep can miss this, since > references to the GUC

pgsql: Documentation spell checking and markup improvements

2018-06-29 Thread Peter Eisentraut
Documentation spell checking and markup improvements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f7481d2c3c52042030269b91bfeb00f120adb618 Modified Files -- doc/src/sgml/config.sgml| 4 ++-- doc/src/sgml/func.sgml | 4

pgsql: doc: Replace non-ASCII lines in psql example output

2018-06-29 Thread Peter Eisentraut
doc: Replace non-ASCII lines in psql example output Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/539f32bdd6915e950d225e732959a1b068598993 Modified Files -- doc/src/sgml/ddl.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-06-29 Thread Alvaro Herrera
On 2018-Jun-28, Tom Lane wrote: > Alvaro Herrera writes: > > Fix "base" snapshot handling in logical decoding > > According to buildfarm member friarbird, and as confirmed here, > the contrib/test_decoding/specs/oldest_xmin.spec test added by this > commit fails under CLOBBER_CACHE_ALWAYS. Than

pgsql: psql: show cloned triggers in partitions

2018-06-29 Thread Alvaro Herrera
psql: show cloned triggers in partitions In a partition, row triggers that had been cloned from their parent partitioned table would not be listed at all in psql's \d, which could surprise users, per insistent complaint from Ashutosh Bapat (though his aim was elsewhere). The simplest possible fix

pgsql: Fix crash when ALTER TABLE recreates indexes on partitions

2018-06-29 Thread Alvaro Herrera
Fix crash when ALTER TABLE recreates indexes on partitions The skip_build flag was not being passed correctly when recursing to indexes on partitions, leading to attempts to rebuild indexes when they were not yet ready to be rebuilt. Reported-by: Rajkumar Raghuwanshi Discussion: https://postgr.e

pgsql: Replace search.cpan.org with metacpan.org

2018-06-29 Thread Michael Paquier
Replace search.cpan.org with metacpan.org search.cpan.org has been EOL'd, with metacpan.org being the official replacement to which URLs now redirect. Update links to match the new URL. Also update links to CPAN to use https as it will redirect from http. Author: Daniel Gustafsson Discussion: ht

pgsql: Replace search.cpan.org with metacpan.org

2018-06-29 Thread Michael Paquier
Replace search.cpan.org with metacpan.org search.cpan.org has been EOL'd, with metacpan.org being the official replacement to which URLs now redirect. Update links to match the new URL. Also update links to CPAN to use https as it will redirect from http. Author: Daniel Gustafsson Discussion: ht

pgsql: Replace search.cpan.org with metacpan.org

2018-06-29 Thread Michael Paquier
Replace search.cpan.org with metacpan.org search.cpan.org has been EOL'd, with metacpan.org being the official replacement to which URLs now redirect. Update links to match the new URL. Also update links to CPAN to use https as it will redirect from http. Author: Daniel Gustafsson Discussion: ht

pgsql: Replace search.cpan.org with metacpan.org

2018-06-29 Thread Michael Paquier
Replace search.cpan.org with metacpan.org search.cpan.org has been EOL'd, with metacpan.org being the official replacement to which URLs now redirect. Update links to match the new URL. Also update links to CPAN to use https as it will redirect from http. Author: Daniel Gustafsson Discussion: ht

pgsql: Replace search.cpan.org with metacpan.org

2018-06-29 Thread Michael Paquier
Replace search.cpan.org with metacpan.org search.cpan.org has been EOL'd, with metacpan.org being the official replacement to which URLs now redirect. Update links to match the new URL. Also update links to CPAN to use https as it will redirect from http. Author: Daniel Gustafsson Discussion: ht

pgsql: Replace search.cpan.org with metacpan.org

2018-06-29 Thread Michael Paquier
Replace search.cpan.org with metacpan.org search.cpan.org has been EOL'd, with metacpan.org being the official replacement to which URLs now redirect. Update links to match the new URL. Also update links to CPAN to use https as it will redirect from http. Author: Daniel Gustafsson Discussion: ht

Re: Tips on committing

2018-06-29 Thread Tomas Vondra
On 06/29/2018 02:19 PM, Michael Paquier wrote: On Fri, Jun 29, 2018 at 02:04:07PM +0200, Peter Eisentraut wrote: On 6/28/18 17:14, Alvaro Herrera wrote: 2 Reported-by: 5 Author: 6 Reviewed-by: 7 Tested-by: Should these include email addresses? One reason I include

Re: Tips on committing

2018-06-29 Thread Michael Paquier
On Thu, Jun 28, 2018 at 10:52:42AM -0700, Peter Geoghegan wrote: > On Thu, Jun 28, 2018 at 9:52 AM, Alvaro Herrera > I'll try to do that, but I'd still recommend personalizing it. A lot > of the stuff in there is specific to my own workflow and tool > preferences, and my own personal working style.

Re: Tips on committing

2018-06-29 Thread Michael Paquier
On Fri, Jun 29, 2018 at 02:04:07PM +0200, Peter Eisentraut wrote: > On 6/28/18 17:14, Alvaro Herrera wrote: >>> 2 Reported-by: >>> 5 Author: >>> 6 Reviewed-by: >>> 7 Tested-by: >> Should these include email addresses? > > One reason I include emails is that sometimes the na

Re: Tips on committing

2018-06-29 Thread Peter Eisentraut
On 6/28/18 17:14, Alvaro Herrera wrote: >> 2 Reported-by: >> 5 Author: >> 6 Reviewed-by: >> 7 Tested-by: > Should these include email addresses? One reason I include emails is that sometimes the names are spelled in inconsistent ways or don't include ASCII characters at all

Re: pgsql: Clarify use of temporary tables within partition trees

2018-06-29 Thread David Rowley
On 20 June 2018 at 13:53, Michael Paquier wrote: > Clarify use of temporary tables within partition trees Hi, Thanks for committing this fix. I think slightly more should have been done. There's still some dead code in expand_partitioned_rtentry that I think should be removed. The code won't c