pgsql: Add application_name to connection authorized msg

2018-09-28 Thread Stephen Frost
Add application_name to connection authorized msg The connection authorized message has quite a bit of useful information in it, but didn't include the application_name (when provided), so let's add that as it can be very useful. Note that at the point where we're emitting the connection authoriz

pgsql: Improve error reporting for unsupported effective_io_concurrency

2018-09-28 Thread Tom Lane
Improve error reporting for unsupported effective_io_concurrency setting. Give a specific error complaining about lack of posix_fadvise() when someone tries to set effective_io_concurrency > 0 on platforms without that. This probably isn't worth extensive back-patching, but I (tgl) felt cramming

pgsql: Improve error reporting for unsupported effective_io_concurrency

2018-09-28 Thread Tom Lane
Improve error reporting for unsupported effective_io_concurrency setting. Give a specific error complaining about lack of posix_fadvise() when someone tries to set effective_io_concurrency > 0 on platforms without that. This probably isn't worth extensive back-patching, but I (tgl) felt cramming

pgsql: Tweak MSVC build system to match changes in 7143b3e82.

2018-09-28 Thread Tom Lane
Tweak MSVC build system to match changes in 7143b3e82. Looks like we need to pull in $libpgcommon in a couple more places than before. Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/61f14cc8c85b5e6186c3b86c2c929821d7b33589 Modified Files --

pgsql: Tweak MSVC build system to match changes in 7143b3e82.

2018-09-28 Thread Tom Lane
Tweak MSVC build system to match changes in 7143b3e82. Also try to make the comment suggesting that this might be needed more intelligible. Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/97c6852ff7c54d5b44426ceae9e3215d13157c10 Modified Files -

Re: pgsql: Build src/common files as a library with -fPIC.

2018-09-28 Thread Tom Lane
Andres Freund writes: > Looks like Mkvcbuild.pm needs some tweaking, too. Yeah, I was kinda surprised that the first round of changes didn't seem to require anything there. I'll take a look. regards, tom lane

Re: pgsql: Build src/common files as a library with -fPIC.

2018-09-28 Thread Andres Freund
On 2018-09-28 18:28:30 +, Tom Lane wrote: > Build src/common files as a library with -fPIC. > > Build a third version of libpgcommon.a, with -fPIC and -DFRONTEND, > as commit ea53100d5 did for src/port. Use that in libpq to avoid > symlinking+rebuilding source files retail. > > Also adjust e

pgsql: Build src/common files as a library with -fPIC.

2018-09-28 Thread Tom Lane
Build src/common files as a library with -fPIC. Build a third version of libpgcommon.a, with -fPIC and -DFRONTEND, as commit ea53100d5 did for src/port. Use that in libpq to avoid symlinking+rebuilding source files retail. Also adjust ecpg to use the new src/port and src/common libraries. Arran

pgsql: Remove pqsignal() from libpq's official exports list.

2018-09-28 Thread Tom Lane
Remove pqsignal() from libpq's official exports list. Client applications should get this function, if they need it, from libpgport. The fact that it's exported from libpq is a hack left over from before we set up libpgport. It's never been documented, and there's no good reason for non-PG code

Re: pgsql: Build src/port files as a library with -fPIC, and use that in li

2018-09-28 Thread Tom Lane
Andrew Dunstan writes: > Looks like we have a bunch of failures, including prairiedog. Yeah, please see discussion, in this thread and also at https://www.postgresql.org/message-id/19581.1538077...@sss.pgh.pa.us regards, tom lane

Re: pgsql: Build src/port files as a library with -fPIC, and use that in li

2018-09-28 Thread Andrew Dunstan
On 09/27/2018 11:23 AM, Tom Lane wrote: Build src/port files as a library with -fPIC, and use that in libpq. libpq and ecpg need shared-library-friendly versions of assorted src/port/ and src/common/ modules. Up to now, they got those by symlinking the individual source files and compiling t

pgsql: Fix assertion failure when updating full_page_writes for checkpo

2018-09-28 Thread Amit Kapila
Fix assertion failure when updating full_page_writes for checkpointer. When the checkpointer receives a SIGHUP signal to update its configuration, it may need to update the shared memory for full_page_writes and need to write a WAL record for it. Now, it is quite possible that the XLOG machinery

pgsql: Fix assertion failure when updating full_page_writes for checkpo

2018-09-28 Thread Amit Kapila
Fix assertion failure when updating full_page_writes for checkpointer. When the checkpointer receives a SIGHUP signal to update its configuration, it may need to update the shared memory for full_page_writes and need to write a WAL record for it. Now, it is quite possible that the XLOG machinery

pgsql: Fix assertion failure when updating full_page_writes for checkpo

2018-09-28 Thread Amit Kapila
Fix assertion failure when updating full_page_writes for checkpointer. When the checkpointer receives a SIGHUP signal to update its configuration, it may need to update the shared memory for full_page_writes and need to write a WAL record for it. Now, it is quite possible that the XLOG machinery

pgsql: Fix assertion failure when updating full_page_writes for checkpo

2018-09-28 Thread Amit Kapila
Fix assertion failure when updating full_page_writes for checkpointer. When the checkpointer receives a SIGHUP signal to update its configuration, it may need to update the shared memory for full_page_writes and need to write a WAL record for it. Now, it is quite possible that the XLOG machinery

pgsql: Fix assertion failure when updating full_page_writes for checkpo

2018-09-28 Thread Amit Kapila
Fix assertion failure when updating full_page_writes for checkpointer. When the checkpointer receives a SIGHUP signal to update its configuration, it may need to update the shared memory for full_page_writes and need to write a WAL record for it. Now, it is quite possible that the XLOG machinery