pgsql: pg_archivecleanup: Update file header comment a bit

2018-11-18 Thread Peter Eisentraut
pg_archivecleanup: Update file header comment a bit Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fc47e99a157a56a92dea679a74d546e28b253bb7 Modified Files -- src/bin/pg_archivecleanup/pg_archivecleanup.c | 10 +++--- 1 file changed, 3 insertions(+),

pgsql: Don't forget about failed fsync() requests.

2018-11-18 Thread Thomas Munro
Don't forget about failed fsync() requests. If fsync() fails, md.c must keep the request in its bitmap, so that future attempts will try again. Back-patch to all supported releases. Author: Thomas Munro Reviewed-by: Amit Kapila Reported-by: Andrew Gierth Discussion: https://postgr.es/m/87y3i1ia4

pgsql: PANIC on fsync() failure.

2018-11-18 Thread Thomas Munro
PANIC on fsync() failure. On some operating systems, it doesn't make sense to retry fsync(), because dirty data cached by the kernel may have been dropped on write-back failure. In that case the only remaining copy of the data is in the WAL. A subsequent fsync() could appear to succeed, but not

pgsql: Don't forget about failed fsync() requests.

2018-11-18 Thread Thomas Munro
Don't forget about failed fsync() requests. If fsync() fails, md.c must keep the request in its bitmap, so that future attempts will try again. Back-patch to all supported releases. Author: Thomas Munro Reviewed-by: Amit Kapila Reported-by: Andrew Gierth Discussion: https://postgr.es/m/87y3i1ia4

pgsql: PANIC on fsync() failure.

2018-11-18 Thread Thomas Munro
PANIC on fsync() failure. On some operating systems, it doesn't make sense to retry fsync(), because dirty data cached by the kernel may have been dropped on write-back failure. In that case the only remaining copy of the data is in the WAL. A subsequent fsync() could appear to succeed, but not

pgsql: PANIC on fsync() failure.

2018-11-18 Thread Thomas Munro
PANIC on fsync() failure. On some operating systems, it doesn't make sense to retry fsync(), because dirty data cached by the kernel may have been dropped on write-back failure. In that case the only remaining copy of the data is in the WAL. A subsequent fsync() could appear to succeed, but not

pgsql: Don't forget about failed fsync() requests.

2018-11-18 Thread Thomas Munro
Don't forget about failed fsync() requests. If fsync() fails, md.c must keep the request in its bitmap, so that future attempts will try again. Back-patch to all supported releases. Author: Thomas Munro Reviewed-by: Amit Kapila Reported-by: Andrew Gierth Discussion: https://postgr.es/m/87y3i1ia4

pgsql: PANIC on fsync() failure.

2018-11-18 Thread Thomas Munro
PANIC on fsync() failure. On some operating systems, it doesn't make sense to retry fsync(), because dirty data cached by the kernel may have been dropped on write-back failure. In that case the only remaining copy of the data is in the WAL. A subsequent fsync() could appear to succeed, but not

pgsql: PANIC on fsync() failure.

2018-11-18 Thread Thomas Munro
PANIC on fsync() failure. On some operating systems, it doesn't make sense to retry fsync(), because dirty data cached by the kernel may have been dropped on write-back failure. In that case the only remaining copy of the data is in the WAL. A subsequent fsync() could appear to succeed, but not

pgsql: Don't forget about failed fsync() requests.

2018-11-18 Thread Thomas Munro
Don't forget about failed fsync() requests. If fsync() fails, md.c must keep the request in its bitmap, so that future attempts will try again. Back-patch to all supported releases. Author: Thomas Munro Reviewed-by: Amit Kapila Reported-by: Andrew Gierth Discussion: https://postgr.es/m/87y3i1ia4

pgsql: Don't forget about failed fsync() requests.

2018-11-18 Thread Thomas Munro
Don't forget about failed fsync() requests. If fsync() fails, md.c must keep the request in its bitmap, so that future attempts will try again. Back-patch to all supported releases. Author: Thomas Munro Reviewed-by: Amit Kapila Reported-by: Andrew Gierth Discussion: https://postgr.es/m/87y3i1ia4

pgsql: Don't forget about failed fsync() requests.

2018-11-18 Thread Thomas Munro
Don't forget about failed fsync() requests. If fsync() fails, md.c must keep the request in its bitmap, so that future attempts will try again. Back-patch to all supported releases. Author: Thomas Munro Reviewed-by: Amit Kapila Reported-by: Andrew Gierth Discussion: https://postgr.es/m/87y3i1ia4

pgsql: PANIC on fsync() failure.

2018-11-18 Thread Thomas Munro
PANIC on fsync() failure. On some operating systems, it doesn't make sense to retry fsync(), because dirty data cached by the kernel may have been dropped on write-back failure. In that case the only remaining copy of the data is in the WAL. A subsequent fsync() could appear to succeed, but not

pgsql: Rework documentation of pg_promote

2018-11-18 Thread Michael Paquier
Rework documentation of pg_promote This clarifies the behavior of how the "wait" flag works, which is something that the previous version of the documentation failed to do. Author: Ian Barwick Discussion: https://postgr.es/m/cbd38450-2295-10a1-1f73-591a692ae...@2ndquadrant.com Branch -- mas

pgsql: Remove unnecessary memcpy when reading WAL record fitting on pag

2018-11-18 Thread Michael Paquier
Remove unnecessary memcpy when reading WAL record fitting on page When reading a WAL record, its contents are copied into an intermediate buffer. However, doing so is not necessary if the record fits fully into the current page, saving one memcpy for each such record. The allocation handling of

pgsql: fix typo

2018-11-18 Thread Andrew Dunstan
fix typo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/79376e07128fbf3c92f4e1fb457be435afa2e6a6 Modified Files -- src/pl/plperl/plperl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Silence MSVC warnings about redefinition of isnan

2018-11-18 Thread Andrew Dunstan
Silence MSVC warnings about redefinition of isnan Some versions of perl.h define isnan when the compiler is MSVC. To avoid warnings about this, undefine the symbol before including perl.h and re-add the definition afterwards if it wasn't recreated. Discussion: https://postgr.es/m/caf0568e-3c1f-0