pgsql: postgres_fdw: Account for tlist eval costs in estimate_path_cost

2019-01-23 Thread Etsuro Fujita
postgres_fdw: Account for tlist eval costs in estimate_path_cost_size(). Previously, estimate_path_cost_size() didn't account for tlist eval costs, except when costing a foreign-grouping path using local statistics, but such costs should be accounted for when costing that path using remote estimat

Re: pgsql: Detach constraints when partitions are detached

2019-01-23 Thread Amit Langote
On 2019/01/24 13:58, Tom Lane wrote: > Alvaro Herrera writes: >> Detach constraints when partitions are detached > > Hm ... it looks like this fails under -DRELCACHE_FORCE_RELEASE: Oops, sorry. This is why: index_close(idx, NoLock); ... +if (!idx->rd_index->indisprimary && !id

Re: pgsql: Detach constraints when partitions are detached

2019-01-23 Thread Tom Lane
Alvaro Herrera writes: > Detach constraints when partitions are detached Hm ... it looks like this fails under -DRELCACHE_FORCE_RELEASE: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2019-01-24%2003%3A58%3A02 Core was generated by `postgres: ec2-user regression [local] ALTER

pgsql: Blind attempt to fix _configthreadlocale() failures on MinGW.

2019-01-23 Thread Tom Lane
Blind attempt to fix _configthreadlocale() failures on MinGW. Apparently, some builds of MinGW contain a version of _configthreadlocale() that always returns -1, indicating failure. Rather than treating that as a curl-up-and-die condition, soldier on as though the function didn't exist. This leav

pgsql: Blind attempt to fix _configthreadlocale() failures on MinGW.

2019-01-23 Thread Tom Lane
Blind attempt to fix _configthreadlocale() failures on MinGW. Apparently, some builds of MinGW contain a version of _configthreadlocale() that always returns -1, indicating failure. Rather than treating that as a curl-up-and-die condition, soldier on as though the function didn't exist. This leav

pgsql: Blind attempt to fix _configthreadlocale() failures on MinGW.

2019-01-23 Thread Tom Lane
Blind attempt to fix _configthreadlocale() failures on MinGW. Apparently, some builds of MinGW contain a version of _configthreadlocale() that always returns -1, indicating failure. Rather than treating that as a curl-up-and-die condition, soldier on as though the function didn't exist. This leav

pgsql: Blind attempt to fix _configthreadlocale() failures on MinGW.

2019-01-23 Thread Tom Lane
Blind attempt to fix _configthreadlocale() failures on MinGW. Apparently, some builds of MinGW contain a version of _configthreadlocale() that always returns -1, indicating failure. Rather than treating that as a curl-up-and-die condition, soldier on as though the function didn't exist. This leav

pgsql: Blind attempt to fix _configthreadlocale() failures on MinGW.

2019-01-23 Thread Tom Lane
Blind attempt to fix _configthreadlocale() failures on MinGW. Apparently, some builds of MinGW contain a version of _configthreadlocale() that always returns -1, indicating failure. Rather than treating that as a curl-up-and-die condition, soldier on as though the function didn't exist. This leav

pgsql: Blind attempt to fix _configthreadlocale() failures on MinGW.

2019-01-23 Thread Tom Lane
Blind attempt to fix _configthreadlocale() failures on MinGW. Apparently, some builds of MinGW contain a version of _configthreadlocale() that always returns -1, indicating failure. Rather than treating that as a curl-up-and-die condition, soldier on as though the function didn't exist. This leav

pgsql: Detach constraints when partitions are detached

2019-01-23 Thread Alvaro Herrera
Detach constraints when partitions are detached I (Álvaro) forgot to do this in eb7ed3f30634, leading to undroppable constraints after partitions are detached. Repair. Reported-by: Amit Langote Author: Amit Langote Discussion: https://postgr.es/m/c1c9b688-b886-84f7-4048-1e4ebe9b1...@lab.ntt.co.

pgsql: Detach constraints when partitions are detached

2019-01-23 Thread Alvaro Herrera
Detach constraints when partitions are detached I (Álvaro) forgot to do this in eb7ed3f30634, leading to undroppable constraints after partitions are detached. Repair. Reported-by: Amit Langote Author: Amit Langote Discussion: https://postgr.es/m/c1c9b688-b886-84f7-4048-1e4ebe9b1...@lab.ntt.co.

pgsql: Remove argument isprimary from index_build()

2019-01-23 Thread Michael Paquier
Remove argument isprimary from index_build() The flag was introduced in 3fdeb18, but f66e8bf actually forgot to finish the cleanup as index_update_stats() has simplified its interface. Author: Michael Paquier Discussion: https://postgr.es/m/20190122080852.gb3...@paquier.xyz Branch -- master

pgsql: Fix misc typos in comments.

2019-01-23 Thread Heikki Linnakangas
Fix misc typos in comments. Spotted mostly by Fabien Coelho. Discussion: https://www.postgresql.org/message-id/alpine.DEB.2.21.1901230947050.16643@lancre Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e46a475718680db3afa7fd343a2a75ae3e5d0d8e Modified File

pgsql: Fix misc typos in comments.

2019-01-23 Thread Heikki Linnakangas
Fix misc typos in comments. Spotted mostly by Fabien Coelho. Discussion: https://www.postgresql.org/message-id/alpine.DEB.2.21.1901230947050.16643@lancre Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0359d832128485840bd7dcf0b09646ad752f6a72 Modified File

pgsql: Fix misc typos in comments.

2019-01-23 Thread Heikki Linnakangas
Fix misc typos in comments. Spotted mostly by Fabien Coelho. Discussion: https://www.postgresql.org/message-id/alpine.DEB.2.21.1901230947050.16643@lancre Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2146718b3cf99f32cc0b09d9b7c0a14463f25fd4 Modified File

pgsql: Fix misc typos in comments.

2019-01-23 Thread Heikki Linnakangas
Fix misc typos in comments. Spotted mostly by Fabien Coelho. Discussion: https://www.postgresql.org/message-id/alpine.DEB.2.21.1901230947050.16643@lancre Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6bf9f4e6e38b0b8d6f4ba26da473d6d5bb7fa49d Modified File

pgsql: Fix misc typos in comments.

2019-01-23 Thread Heikki Linnakangas
Fix misc typos in comments. Spotted mostly by Fabien Coelho. Discussion: https://www.postgresql.org/message-id/alpine.DEB.2.21.1901230947050.16643@lancre Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/95931133a959404cf7320b49058b2f1c2e4606b9 Modified Files -

pgsql: Fix misc typos in comments.

2019-01-23 Thread Heikki Linnakangas
Fix misc typos in comments. Spotted mostly by Fabien Coelho. Discussion: https://www.postgresql.org/message-id/alpine.DEB.2.21.1901230947050.16643@lancre Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a5e48d1ed42940e64a5f862e319fd4ff8329edb8 Modified File