pgsql: Do not filter by relkind in vacuumdb's catalog query if --table

2019-01-29 Thread Michael Paquier
Do not filter by relkind in vacuumdb's catalog query if --table is used If a user specifies a relation name which cannot be processed, then the backend can warn directly about what is wrong with it. This fixes an oversight from e0c2933. Author: Nathan Bossart Discussion: https://postgr.es/m/3204

pgsql: Rename nodes/relation.h to nodes/pathnodes.h.

2019-01-29 Thread Tom Lane
Rename nodes/relation.h to nodes/pathnodes.h. The old name of this file was never a very good indication of what it was for. Now that there's also access/relation.h, we have a potential confusion hazard as well, so let's rename it to something more apropos. Per discussion, "pathnodes.h" is reason

pgsql: Refactor planner's header files.

2019-01-29 Thread Tom Lane
Refactor planner's header files. Create a new header optimizer/optimizer.h, which exposes just the planner functions that can be used "at arm's length", without need to access Paths or the other planner-internal data structures defined in nodes/relation.h. This is intended to provide the whole pl

pgsql: Make some small planner API cleanups.

2019-01-29 Thread Tom Lane
Make some small planner API cleanups. Move a few very simple node-creation and node-type-testing functions from the planner's clauses.c to nodes/makefuncs and nodes/nodeFuncs. There's nothing planner-specific about them, as evidenced by the number of other places that were using them. While at it

pgsql: Make SSL tests more robust

2019-01-29 Thread Peter Eisentraut
Make SSL tests more robust Someone running these test could have key or certificate files in their ~/.postgresql/, which would interfere with the tests. The way to override that is to specify sslcert=invalid and/or sslrootcert=invalid if no actual certificate is used for a particular test. Docum

pgsql: Add tests for pg_stat_ssl system view

2019-01-29 Thread Peter Eisentraut
Add tests for pg_stat_ssl system view Reviewed-by: Kyotaro HORIGUCHI Discussion: https://www.postgresql.org/message-id/flat/398754d8-6bb5-c5cf-e7b8-22e5f0983...@2ndquadrant.com/ Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/18059543e76aeb6b3cf3a5513e69daf222d355

pgsql: Fix pg_stat_ssl.clientdn

2019-01-29 Thread Peter Eisentraut
Fix pg_stat_ssl.clientdn Return null if there is no client certificate. This is how it has always been documented, but in reality it returned an empty string. Reviewed-by: Kyotaro HORIGUCHI Discussion: https://www.postgresql.org/message-id/flat/398754d8-6bb5-c5cf-e7b8-22e5f0983...@2ndquadrant.

pgsql: Improve wording about WAL files in tar mode of pg_basebackup

2019-01-29 Thread Magnus Hagander
Improve wording about WAL files in tar mode of pg_basebackup Author: Alex Kliukin Reviewed-By: Michael Paquier, Magnus Hagander Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ff9e63c7d33a92503895b3c8acc8d96cb8116220 Modified Files -- doc/src/sgm

pgsql: Improve wording about WAL files in tar mode of pg_basebackup

2019-01-29 Thread Magnus Hagander
Improve wording about WAL files in tar mode of pg_basebackup Author: Alex Kliukin Reviewed-By: Michael Paquier, Magnus Hagander Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/11b63452814ca011c271d484ee2be56b72f34d1f Modified Files -- doc/src/sgm

pgsql: Improve wording about WAL files in tar mode of pg_basebackup

2019-01-29 Thread Magnus Hagander
Improve wording about WAL files in tar mode of pg_basebackup Author: Alex Kliukin Reviewed-By: Michael Paquier, Magnus Hagander Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9745b528f7cb03be3afad0f91a634072c13ea91f Modified Files -- doc/src/sgml/ref/p