pgsql: Allow some recovery parameters to be changed with reload

2019-02-06 Thread Peter Eisentraut
Allow some recovery parameters to be changed with reload Change archive_cleanup_command promote_trigger_file recovery_end_command recovery_min_apply_delay from PGC_POSTMASTER to PGC_SIGHUP. This did not require any further changes. Reviewed-by: Michael Paquier Discussion: https://www.postgre

pgsql: Add collation assignment to CALL statement

2019-02-06 Thread Peter Eisentraut
Add collation assignment to CALL statement Otherwise functions that require collation information will not have it if they are called in arguments to a CALL statement. Reported-by: Jean-Marc Voillequin Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/1EC8157EB499BF4

pgsql: Add collation assignment to CALL statement

2019-02-06 Thread Peter Eisentraut
Add collation assignment to CALL statement Otherwise functions that require collation information will not have it if they are called in arguments to a CALL statement. Reported-by: Jean-Marc Voillequin Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/1EC8157EB499BF4

pgsql: Doc: Update the documentation for row movement behavior across p

2019-02-06 Thread Amit Kapila
Doc: Update the documentation for row movement behavior across partitions. In commit f16241bef7c, we have changed the behavior for concurrent updates that move row to a different partition, but forgot to update the docs. Previously when an UPDATE command causes a row to move from one partition to

pgsql: Doc: Update the documentation for row movement behavior across p

2019-02-06 Thread Amit Kapila
Doc: Update the documentation for row movement behavior across partitions. In commit f16241bef7c, we have changed the behavior for concurrent updates that move row to a different partition, but forgot to update the docs. Previously when an UPDATE command causes a row to move from one partition to

pgsql: Align better test output regex with grammar in pg_dump TAP tests

2019-02-06 Thread Michael Paquier
Align better test output regex with grammar in pg_dump TAP tests This enforces one-or-more character matches in the regular expressions for pg_dump testing on SQL syntax output where zero-or-more matches implies a syntax error. Author: Daniel Gustafsson Reviewed-by: David G. Johnston, Michael Paq

pgsql: Add more tests for CREATE TABLE AS with WITH NO DATA

2019-02-06 Thread Michael Paquier
Add more tests for CREATE TABLE AS with WITH NO DATA The relation creation is done at executor startup, however the main regression test suite is lacking scenarios where no data is inserted which is something that can happen when using EXECUTE or EXPLAIN with CREATE TABLE AS and WITH NO DATA. Som

pgsql: Avoid amcheck inline compression false positives.

2019-02-06 Thread Peter Geoghegan
Avoid amcheck inline compression false positives. The previous tacit assumption that index_form_tuple() hides differences in the TOAST state of its input datums was wrong. Normalize input varlena datums by decompressing compressed values, and forming a new index tuple for fingerprinting using unc

pgsql: Avoid amcheck inline compression false positives.

2019-02-06 Thread Peter Geoghegan
Avoid amcheck inline compression false positives. The previous tacit assumption that index_form_tuple() hides differences in the TOAST state of its input datums was wrong. Normalize input varlena datums by decompressing compressed values, and forming a new index tuple for fingerprinting using unc

pgsql: Hide cascade messages in collate tests

2019-02-06 Thread Peter Eisentraut
Hide cascade messages in collate tests These are not relevant to the tests and would just uselessly bloat patches. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/727921f466a5234e41b27d34f8e859ca39a93f9e Modified Files -- src/test/regress/expected/colla

pgsql: Propagate lateral-reference information to indirect descendant r

2019-02-06 Thread Tom Lane
Propagate lateral-reference information to indirect descendant relations. create_lateral_join_info() computes a bunch of information about lateral references between base relations, and then attempts to propagate those markings to appendrel children of the original base relations. But the origina

pgsql: Propagate lateral-reference information to indirect descendant r

2019-02-06 Thread Tom Lane
Propagate lateral-reference information to indirect descendant relations. create_lateral_join_info() computes a bunch of information about lateral references between base relations, and then attempts to propagate those markings to appendrel children of the original base relations. But the origina

pgsql: Propagate lateral-reference information to indirect descendant r

2019-02-06 Thread Tom Lane
Propagate lateral-reference information to indirect descendant relations. create_lateral_join_info() computes a bunch of information about lateral references between base relations, and then attempts to propagate those markings to appendrel children of the original base relations. But the origina

pgsql: Propagate lateral-reference information to indirect descendant r

2019-02-06 Thread Tom Lane
Propagate lateral-reference information to indirect descendant relations. create_lateral_join_info() computes a bunch of information about lateral references between base relations, and then attempts to propagate those markings to appendrel children of the original base relations. But the origina

pgsql: Propagate lateral-reference information to indirect descendant r

2019-02-06 Thread Tom Lane
Propagate lateral-reference information to indirect descendant relations. create_lateral_join_info() computes a bunch of information about lateral references between base relations, and then attempts to propagate those markings to appendrel children of the original base relations. But the origina

pgsql: Propagate lateral-reference information to indirect descendant r

2019-02-06 Thread Tom Lane
Propagate lateral-reference information to indirect descendant relations. create_lateral_join_info() computes a bunch of information about lateral references between base relations, and then attempts to propagate those markings to appendrel children of the original base relations. But the origina

pgsql: Unify searchpath and do file logic in MSVC build scripts.

2019-02-06 Thread Andrew Dunstan
Unify searchpath and do file logic in MSVC build scripts. Commit f83419b739 failed to notice that mkvcbuild.pl and build.pl use different searchpath and do-file logic, breaking the latter, so it is adjusted to use the same logic as mkvcbuild.pl. Branch -- REL_10_STABLE Details --- https:

pgsql: Unify searchpath and do file logic in MSVC build scripts.

2019-02-06 Thread Andrew Dunstan
Unify searchpath and do file logic in MSVC build scripts. Commit f83419b739 failed to notice that mkvcbuild.pl and build.pl use different searchpath and do-file logic, breaking the latter, so it is adjusted to use the same logic as mkvcbuild.pl. Branch -- REL9_5_STABLE Details --- https:

pgsql: Unify searchpath and do file logic in MSVC build scripts.

2019-02-06 Thread Andrew Dunstan
Unify searchpath and do file logic in MSVC build scripts. Commit f83419b739 failed to notice that mkvcbuild.pl and build.pl use different searchpath and do-file logic, breaking the latter, so it is adjusted to use the same logic as mkvcbuild.pl. Branch -- REL9_6_STABLE Details --- https:

pgsql: Unify searchpath and do file logic in MSVC build scripts.

2019-02-06 Thread Andrew Dunstan
Unify searchpath and do file logic in MSVC build scripts. Commit f83419b739 failed to notice that mkvcbuild.pl and build.pl use different searchpath and do-file logic, breaking the latter, so it is adjusted to use the same logic as mkvcbuild.pl. Branch -- REL_11_STABLE Details --- https:

pgsql: Unify searchpath and do file logic in MSVC build scripts.

2019-02-06 Thread Andrew Dunstan
Unify searchpath and do file logic in MSVC build scripts. Commit f83419b739 failed to notice that mkvcbuild.pl and build.pl use different searchpath and do-file logic, breaking the latter, so it is adjusted to use the same logic as mkvcbuild.pl. Branch -- REL9_4_STABLE Details --- https:

pgsql: Unify searchpath and do file logic in MSVC build scripts.

2019-02-06 Thread Andrew Dunstan
Unify searchpath and do file logic in MSVC build scripts. Commit f83419b739 failed to notice that mkvcbuild.pl and build.pl use different searchpath and do-file logic, breaking the latter, so it is adjusted to use the same logic as mkvcbuild.pl. Branch -- master Details --- https://git.p

Re: pgsql: Fix included file path for modern perl

2019-02-06 Thread Andrew Dunstan
On 2/6/19 4:27 AM, Andres Freund wrote: > Hi, > > On 2019-02-06 00:36:07 +, Andrew Dunstan wrote: >> Fix included file path for modern perl >> >> Contrary to the comment on 772d4b76, only paths starting with "./" or >> "../" are considered relative to the current working directory by perl's >

Re: pgsql: Fix included file path for modern perl

2019-02-06 Thread Andres Freund
Hi, On 2019-02-06 00:36:07 +, Andrew Dunstan wrote: > Fix included file path for modern perl > > Contrary to the comment on 772d4b76, only paths starting with "./" or > "../" are considered relative to the current working directory by perl's > "do" function. So this patch converts all the rel

pgsql: Fix heap_getattr() handling of fast defaults.

2019-02-06 Thread Andres Freund
Fix heap_getattr() handling of fast defaults. Previously heap_getattr() returned NULL for attributes with a fast default value (c.f. 16828d5c0273), as it had no handling whatsoever for that case. A previous fix, 7636e5c60f, attempted to fix issues caused by this oversight, but just expanding OLD

pgsql: Fix heap_getattr() handling of fast defaults.

2019-02-06 Thread Andres Freund
Fix heap_getattr() handling of fast defaults. Previously heap_getattr() returned NULL for attributes with a fast default value (c.f. 16828d5c0273), as it had no handling whatsoever for that case. A previous fix, 7636e5c60f, attempted to fix issues caused by this oversight, but just expanding OLD

pgsql: Tighten some regexes with proper character escaping in pg_dump T

2019-02-06 Thread Michael Paquier
Tighten some regexes with proper character escaping in pg_dump TAP tests Some tests have been using regular expressions which have been lax in escaping dots, which may cause tests to pass when they should not. This make the whole set of tests more robust where needed. Author: David Rowley Review