Re: pgsql: pg_regress: Don't use absolute paths for the diff

2019-02-22 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Fri, Feb 22, 2019 at 03:26:35PM -0800, Andres Freund wrote: > > that's useless, because I can't trivially copy the result file into the > > expected file anymore. I have to figure out where in the tree it > > is. Which isn't exactly pr

pgsql: Fix incorrect function reference in comment of twophase.c

2019-02-22 Thread Michael Paquier
Fix incorrect function reference in comment of twophase.c The header block of TwoPhaseGetDummyBackendId mentioned incorrectly TwoPhaseGetDummyProc. Reported-by: Oleksii Kliukin Discussion: https://postgr.es/m/d8336e40-bbe1-4954-98bb-7830d3f5c...@hintbits.com Branch -- master Details --

Re: pgsql: pg_regress: Don't use absolute paths for the diff

2019-02-22 Thread Michael Paquier
On Fri, Feb 22, 2019 at 03:26:35PM -0800, Andres Freund wrote: > that's useless, because I can't trivially copy the result file into the > expected file anymore. I have to figure out where in the tree it > is. Which isn't exactly predictable, between the different tests we > have as they locate the

Re: pgsql: pg_regress: Don't use absolute paths for the diff

2019-02-22 Thread Andres Freund
On 2019-02-22 15:18:51 -0800, Peter Geoghegan wrote: > On Thu, Feb 21, 2019 at 10:01 AM Peter Eisentraut > wrote: > > pg_regress: Don't use absolute paths for the diff > > > > Don't expand inputfile and outputfile to absolute paths globally, just > > where needed. In particular, pass them as is

pgsql: Add TAP tests for 2PC post-commit callbacks of multixacts at rec

2019-02-22 Thread Michael Paquier
Add TAP tests for 2PC post-commit callbacks of multixacts at recovery The current set of TAP tests for two-phase transactions include some coverage for post-commit callbacks of multixact, but it lacked tests for testing the recovery of those callbacks. This commit adds some tests with soft and ha

Re: pgsql: pg_regress: Don't use absolute paths for the diff

2019-02-22 Thread Peter Geoghegan
On Thu, Feb 21, 2019 at 10:01 AM Peter Eisentraut wrote: > pg_regress: Don't use absolute paths for the diff > > Don't expand inputfile and outputfile to absolute paths globally, just > where needed. In particular, pass them as is to the file name > arguments of the diff command, so that we don't

pgsql: Fix plan created for inherited UPDATE/DELETE with all tables exc

2019-02-22 Thread Tom Lane
Fix plan created for inherited UPDATE/DELETE with all tables excluded. In the case where inheritance_planner() finds that every table has been excluded by constraints, it thought it could get away with making a plan consisting of just a dummy Result node. While certainly there's no updating or de

pgsql: Fix plan created for inherited UPDATE/DELETE with all tables exc

2019-02-22 Thread Tom Lane
Fix plan created for inherited UPDATE/DELETE with all tables excluded. In the case where inheritance_planner() finds that every table has been excluded by constraints, it thought it could get away with making a plan consisting of just a dummy Result node. While certainly there's no updating or de

pgsql: Fix plan created for inherited UPDATE/DELETE with all tables exc

2019-02-22 Thread Tom Lane
Fix plan created for inherited UPDATE/DELETE with all tables excluded. In the case where inheritance_planner() finds that every table has been excluded by constraints, it thought it could get away with making a plan consisting of just a dummy Result node. While certainly there's no updating or de

pgsql: Fix plan created for inherited UPDATE/DELETE with all tables exc

2019-02-22 Thread Tom Lane
Fix plan created for inherited UPDATE/DELETE with all tables excluded. In the case where inheritance_planner() finds that every table has been excluded by constraints, it thought it could get away with making a plan consisting of just a dummy Result node. While certainly there's no updating or de

pgsql: Fix plan created for inherited UPDATE/DELETE with all tables exc

2019-02-22 Thread Tom Lane
Fix plan created for inherited UPDATE/DELETE with all tables excluded. In the case where inheritance_planner() finds that every table has been excluded by constraints, it thought it could get away with making a plan consisting of just a dummy Result node. While certainly there's no updating or de

pgsql: Fix plan created for inherited UPDATE/DELETE with all tables exc

2019-02-22 Thread Tom Lane
Fix plan created for inherited UPDATE/DELETE with all tables excluded. In the case where inheritance_planner() finds that every table has been excluded by constraints, it thought it could get away with making a plan consisting of just a dummy Result node. While certainly there's no updating or de

pgsql: Report correct name in autovacuum "work items" activity

2019-02-22 Thread Alvaro Herrera
Report correct name in autovacuum "work items" activity We were reporting the database name instead of the relation name to pg_stat_activity. Repair. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20190220185552.gr28...@telsasoft.com Branch -- REL_11_STABLE Details --- http

pgsql: Report correct name in autovacuum "work items" activity

2019-02-22 Thread Alvaro Herrera
Report correct name in autovacuum "work items" activity We were reporting the database name instead of the relation name to pg_stat_activity. Repair. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20190220185552.gr28...@telsasoft.com Branch -- REL_10_STABLE Details --- http

pgsql: Report correct name in autovacuum "work items" activity

2019-02-22 Thread Alvaro Herrera
Report correct name in autovacuum "work items" activity We were reporting the database name instead of the relation name to pg_stat_activity. Repair. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20190220185552.gr28...@telsasoft.com Branch -- master Details --- https://git

pgsql: Add const qualifier

2019-02-22 Thread Peter Eisentraut
Add const qualifier New code introduced in 050710b36964dee7e1b2bf6b5ef00041fd5d2787. The lack of const is not currently a compiler warning, but it's nice to have for consistency with surrounding code. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1373ba55c9b9c9a5