pgsql: Run catalog reindexing test from 3dbb317d32 serially, to avoid d

Run catalog reindexing test from 3dbb317d32 serially, to avoid deadlocks. The tests turn out to cause deadlocks in some circumstances. Fairly reproducibly so with -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE. Some of the deadlocks may be hard to fix without disproportionate measures, but oth

pgsql: Fix unused variable compiler warning in !debug builds.

Fix unused variable compiler warning in !debug builds. Introduced in 3dbb317d3. Fix by using the new local variable in more places. Reported-By: Bruce Momjian (off-list) Backpatch: 9.4-, like 3dbb317d3 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d18f5ff

pgsql: Fix unused variable compiler warning in !debug builds.

Fix unused variable compiler warning in !debug builds. Introduced in 3dbb317d3. Fix by using the new local variable in more places. Reported-By: Bruce Momjian (off-list) Backpatch: 9.4-, like 3dbb317d3 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5409e35

pgsql: Run catalog reindexing test from 3dbb317d32 serially, to avoid d

Run catalog reindexing test from 3dbb317d32 serially, to avoid deadlocks. The tests turn out to cause deadlocks in some circumstances. Fairly reproducibly so with -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE. Some of the deadlocks may be hard to fix without disproportionate measures, but oth

pgsql: Fix unused variable compiler warning in !debug builds.

Fix unused variable compiler warning in !debug builds. Introduced in 3dbb317d3. Fix by using the new local variable in more places. Reported-By: Bruce Momjian (off-list) Backpatch: 9.4-, like 3dbb317d3 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4b40d40b30ae04

pgsql: Fix unused variable compiler warning in !debug builds.

Fix unused variable compiler warning in !debug builds. Introduced in 3dbb317d3. Fix by using the new local variable in more places. Reported-By: Bruce Momjian (off-list) Backpatch: 9.4-, like 3dbb317d3 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/40230f0

pgsql: Run catalog reindexing test from 3dbb317d32 serially, to avoid d

Run catalog reindexing test from 3dbb317d32 serially, to avoid deadlocks. The tests turn out to cause deadlocks in some circumstances. Fairly reproducibly so with -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE. Some of the deadlocks may be hard to fix without disproportionate measures, but oth

pgsql: Run catalog reindexing test from 3dbb317d32 serially, to avoid d

Run catalog reindexing test from 3dbb317d32 serially, to avoid deadlocks. The tests turn out to cause deadlocks in some circumstances. Fairly reproducibly so with -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE. Some of the deadlocks may be hard to fix without disproportionate measures, but oth

pgsql: Run catalog reindexing test from 3dbb317d32 serially, to avoid d

Run catalog reindexing test from 3dbb317d32 serially, to avoid deadlocks. The tests turn out to cause deadlocks in some circumstances. Fairly reproducibly so with -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE. Some of the deadlocks may be hard to fix without disproportionate measures, but oth

pgsql: Run catalog reindexing test from 3dbb317d32 serially, to avoid d

Run catalog reindexing test from 3dbb317d32 serially, to avoid deadlocks. The tests turn out to cause deadlocks in some circumstances. Fairly reproducibly so with -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE. Some of the deadlocks may be hard to fix without disproportionate measures, but oth

pgsql: Fix unused variable compiler warning in !debug builds.

Fix unused variable compiler warning in !debug builds. Introduced in 3dbb317d3. Fix by using the new local variable in more places. Reported-By: Bruce Momjian (off-list) Backpatch: 9.4-, like 3dbb317d3 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d8d5e1a

pgsql: Fix unused variable compiler warning in !debug builds.

Fix unused variable compiler warning in !debug builds. Introduced in 3dbb317d3. Fix by using the new local variable in more places. Reported-By: Bruce Momjian (off-list) Backpatch: 9.4-, like 3dbb317d3 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d264bb5

pgsql: docs: Fix small copy & paste mistake.

docs: Fix small copy & paste mistake. Author: Justin Pryzby Discussion: https://postgr.es/m/20190418005115.r4mat75wvlski...@alap3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b06a354e381d30e13cef28904bb923896aa4719b Modified Files -- doc

pgsql: Improve comment spelling and style in llvmjit_deform.c.

Improve comment spelling and style in llvmjit_deform.c. Author: Justin Pryzby Discussion: https://postgr.es/m/20190408141828.ge10...@telsasoft.com https://postgr.es/m/20181127184133.gm10...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a0b5bb

pgsql: Improve code inferring length of bitmap for JITed tuple deformin

Improve code inferring length of bitmap for JITed tuple deforming. While discussing comment improvements (see next commit) by Justin Pryzby, Tom complained about a few details of the logic to infer the length of the NULL bitmap when building the JITed tuple deforming function. That bitmap allows t

Re: pgsql: Track block level checksum failures in pg_stat_database

On Tue, Apr 30, 2019 at 11:56 PM Tom Lane wrote: > > Julien Rouhaud writes: > > On Tue, Apr 30, 2019 at 6:33 PM Tomas Vondra > > wrote: > >> It seems this commit forgot to add PgStat_MsgChecksumFailure to the > >> PgStat_Msg union. > > > Oops, indeed. That's embarrassing. Trivial fix attached

Re: pgsql: Track block level checksum failures in pg_stat_database

Julien Rouhaud writes: > On Tue, Apr 30, 2019 at 6:33 PM Tomas Vondra > wrote: >> It seems this commit forgot to add PgStat_MsgChecksumFailure to the >> PgStat_Msg union. > Oops, indeed. That's embarrassing. Trivial fix attached if that helps. Seems like this exposes a generic weakness in the

Re: pgsql: Track block level checksum failures in pg_stat_database

On Tue, Apr 30, 2019 at 6:33 PM Tomas Vondra wrote: > > On Sat, Mar 09, 2019 at 06:48:11PM +, Magnus Hagander wrote: > >Track block level checksum failures in pg_stat_database > > > >This adds a column that counts how many checksum failures have occurred > >on files belonging to a specific dat

pgsql: Clean up handling of constraint_exclusion and enable_partition_p

Clean up handling of constraint_exclusion and enable_partition_pruning. The interaction of these parameters was a bit confused/confusing, and in fact v11 entirely misses the opportunity to apply partition constraints when a partition is accessed directly (rather than indirectly from its parent).

pgsql: Clean up handling of constraint_exclusion and enable_partition_p

Clean up handling of constraint_exclusion and enable_partition_pruning. The interaction of these parameters was a bit confused/confusing, and in fact v11 entirely misses the opportunity to apply partition constraints when a partition is accessed directly (rather than indirectly from its parent).

pgsql: doc: improve PG 12 to_timestamp()/to_date() wording

doc: improve PG 12 to_timestamp()/to_date() wording Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ad23adc5a169b114f9ff325932cbf2ce1c5e69c1 Modified Files -- doc/src/sgml/func.sgml | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)

pgsql: doc: move "only" to a more appropriate place in the sentence

doc: move "only" to a more appropriate place in the sentence Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/345473862571d5b2c63849f6472828bdc5b49320 Modified Files -- doc/src/sgml/func.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: pgsql: Track block level checksum failures in pg_stat_database

On Sat, Mar 09, 2019 at 06:48:11PM +, Magnus Hagander wrote: Track block level checksum failures in pg_stat_database This adds a column that counts how many checksum failures have occurred on files belonging to a specific database. Both checksum failures during normal backend processing and

pgsql: Message style fixes

Message style fixes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9f8b717a80c59e4a8e8091a8ff6c6f7666a69c33 Modified Files -- src/backend/access/table/tableamapi.c | 6 +++--- src/backend/access/transam/twophase.c | 4 ++-- src/backend/commands/in

pgsql: Widen tuple counter variables from long to int64

Widen tuple counter variables from long to int64 Mistake in ab0dfc961b6a; progress reporting would have wrapped around for indexes created with more than 2^31 tuples. Reported-by: Peter Geoghegan Discussion: https://postgr.es/m/CAH2-Wz=wbnxc5ob5nj9yqo2rmj0q4hxds30gvcobecvc9a1...@mail.gmail.com

Re: pgsql: Fix potential assertion failure when reindexing a pg_class index

Andrew Dunstan writes: > There seem to be a number of regression test failures involving deadlock > resulting from this. e.g. on prion: Yeah, see -hackers thread: <20190430070552.jzqgcy4ihalx7...@alap3.anarazel.de> regards, tom lane

Re: pgsql: Fix potential assertion failure when reindexing a pg_class index

On 4/29/19 11:04 PM, Andres Freund wrote: > Fix potential assertion failure when reindexing a pg_class index. > There seem to be a number of regression test failures involving deadlock resulting from this. e.g. on prion: 2019-04-30 03:20:12.772 UTC [15476:388] pg_regress/create_view LOG: stat