Re: pgsql: Revert "Avoid the creation of the free space map for small heap

2019-05-06 Thread Amit Kapila
On Tue, May 7, 2019 at 10:03 AM Amit Kapila wrote: > > On Tue, May 7, 2019 at 9:51 AM Tom Lane wrote: > > > I'm just worried that that's an untested scenario. > > > > I can test it. Basically, without revert of the patch, I can create a > table with a few records (so as to ensure that there is n

pgsql: Remove some code related to 7.3 and older servers from tools of

2019-05-06 Thread Michael Paquier
Remove some code related to 7.3 and older servers from tools of src/bin/ This code was broken as of 582edc3, and is most likely not used anymore. Note that pg_dump supports servers down to 8.0, and psql has code to support servers down to 7.4. Author: Julien Rouhaud Reviewed-by: Tom Lane Discussi

pgsql: Remove some code related to 7.3 and older servers from tools of

2019-05-06 Thread Michael Paquier
Remove some code related to 7.3 and older servers from tools of src/bin/ This code was broken as of 582edc3, and is most likely not used anymore. Note that pg_dump supports servers down to 8.0, and psql has code to support servers down to 7.4. Author: Julien Rouhaud Reviewed-by: Tom Lane Discussi

pgsql: Remove some code related to 7.3 and older servers from tools of

2019-05-06 Thread Michael Paquier
Remove some code related to 7.3 and older servers from tools of src/bin/ This code was broken as of 582edc3, and is most likely not used anymore. Note that pg_dump supports servers down to 8.0, and psql has code to support servers down to 7.4. Author: Julien Rouhaud Reviewed-by: Tom Lane Discussi

pgsql: Remove some code related to 7.3 and older servers from tools of

2019-05-06 Thread Michael Paquier
Remove some code related to 7.3 and older servers from tools of src/bin/ This code was broken as of 582edc3, and is most likely not used anymore. Note that pg_dump supports servers down to 8.0, and psql has code to support servers down to 7.4. Author: Julien Rouhaud Reviewed-by: Tom Lane Discussi

pgsql: Remove some code related to 7.3 and older servers from tools of

2019-05-06 Thread Michael Paquier
Remove some code related to 7.3 and older servers from tools of src/bin/ This code was broken as of 582edc3, and is most likely not used anymore. Note that pg_dump supports servers down to 8.0, and psql has code to support servers down to 7.4. Author: Julien Rouhaud Reviewed-by: Tom Lane Discussi

Re: pgsql: Revert "Avoid the creation of the free space map for small heap

2019-05-06 Thread Amit Kapila
On Tue, May 7, 2019 at 9:51 AM Tom Lane wrote: > > Amit Kapila writes: > > On Tue, May 7, 2019 at 9:44 AM Tom Lane wrote: > >> Shouldn't there be a catversion bump in this? > > > Won't the next vacuum run will create the FSM? > > If that's true, and if we don't throw any errors meanwhile, it's f

Re: pgsql: Revert "Avoid the creation of the free space map for small heap

2019-05-06 Thread Tom Lane
Amit Kapila writes: > On Tue, May 7, 2019 at 9:44 AM Tom Lane wrote: >> Shouldn't there be a catversion bump in this? > Won't the next vacuum run will create the FSM? If that's true, and if we don't throw any errors meanwhile, it's fine. I'm just worried that that's an untested scenario.

Re: pgsql: Revert "Avoid the creation of the free space map for small heap

2019-05-06 Thread Amit Kapila
On Tue, May 7, 2019 at 9:44 AM Tom Lane wrote: > > Amit Kapila writes: > > Revert "Avoid the creation of the free space map for small heap relations". > > Shouldn't there be a catversion bump in this? I doubt that an existing > v12 DB (with some missing FSM files) is going to work with the updat

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-06 Thread Amit Kapila
On Tue, May 7, 2019 at 5:00 AM Bruce Momjian wrote: > > On Mon, May 6, 2019 at 07:03:39PM -0400, Bruce Momjian wrote: > > On Mon, May 6, 2019 at 11:02:37PM +, Bruce Momjian wrote: > > > docs: fist draft version of the PG 12 release notes > > > > > > Still needs text markup, links, word wrap

Re: pgsql: Revert "Avoid the creation of the free space map for small heap

2019-05-06 Thread Tom Lane
Amit Kapila writes: > Revert "Avoid the creation of the free space map for small heap relations". Shouldn't there be a catversion bump in this? I doubt that an existing v12 DB (with some missing FSM files) is going to work with the updated backend. Also, will pg_upgrade work across that boundar

pgsql: Revert "Avoid the creation of the free space map for small heap

2019-05-06 Thread Amit Kapila
Revert "Avoid the creation of the free space map for small heap relations". This feature was using a process local map to track the first few blocks in the relation. The map was reset each time we get the block with enough freespace. It was discussed that it would be better to track this map on

pgsql: Remove some code related to 7.3 and older servers from tools of

2019-05-06 Thread Michael Paquier
Remove some code related to 7.3 and older servers from tools of src/bin/ This code was broken as of 582edc3, and is most likely not used anymore. Note that pg_dump supports servers down to 8.0, and psql has code to support servers down to 7.4. Author: Julien Rouhaud Reviewed-by: Tom Lane Discussi

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-06 Thread Bruce Momjian
On Mon, May 6, 2019 at 07:03:39PM -0400, Bruce Momjian wrote: > On Mon, May 6, 2019 at 11:02:37PM +, Bruce Momjian wrote: > > docs: fist draft version of the PG 12 release notes > > > > Still needs text markup, links, word wrap, and indenting. > > You can see the browser version at: > So

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-06 Thread Bruce Momjian
On Mon, May 6, 2019 at 11:02:37PM +, Bruce Momjian wrote: > docs: fist draft version of the PG 12 release notes > > Still needs text markup, links, word wrap, and indenting. You can see the browser version at: http://momjian.us/tmp/pgsql/release-12.html I will be away tomorrow/Tue

pgsql: docs: fist draft version of the PG 12 release notes

2019-05-06 Thread Bruce Momjian
docs: fist draft version of the PG 12 release notes Still needs text markup, links, word wrap, and indenting. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bdf595adbca195fa54a909c74a5233ebc30641a1 Modified Files -- doc/src/sgml/release-12.sgml | 2842

pgsql: Stamp 9.4.22.

2019-05-06 Thread Tom Lane
Stamp 9.4.22. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/30b1e1ac4cea9ab32f2912e503589cda09e535aa Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

pgsql: Stamp 9.5.17.

2019-05-06 Thread Tom Lane
Stamp 9.5.17. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b221b78f83f5bc337b596170d70ab0a9d72a2951 Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

pgsql: Stamp 9.6.13.

2019-05-06 Thread Tom Lane
Stamp 9.6.13. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d22ca701a39dfd03cdfa1ca238370d34f4bc4ac4 Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

pgsql: Stamp 10.8.

2019-05-06 Thread Tom Lane
Stamp 10.8. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/441190289892c4ae870d0781175aa8edd0ec528e Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

pgsql: Stamp 11.3.

2019-05-06 Thread Tom Lane
Stamp 11.3. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0616aed243b23e68b5c06ceb3df3e4ec35e731b7 Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

pgsql: Revert "Make pg_dump emit ATTACH PARTITION instead of PARTITION

2019-05-06 Thread Alvaro Herrera
Revert "Make pg_dump emit ATTACH PARTITION instead of PARTITION OF" ... and fallout (from branches 10, 11 and master). The change was ill-considered, and it broke a few normal use cases; since we don't have time to fix it, we'll try again after this week's minor releases. Reported-by: Rushabh La

pgsql: Revert "Make pg_dump emit ATTACH PARTITION instead of PARTITION

2019-05-06 Thread Alvaro Herrera
Revert "Make pg_dump emit ATTACH PARTITION instead of PARTITION OF" ... and fallout (from branches 10, 11 and master). The change was ill-considered, and it broke a few normal use cases; since we don't have time to fix it, we'll try again after this week's minor releases. Reported-by: Rushabh La

pgsql: Revert "Make pg_dump emit ATTACH PARTITION instead of PARTITION

2019-05-06 Thread Alvaro Herrera
Revert "Make pg_dump emit ATTACH PARTITION instead of PARTITION OF" ... and fallout (from branches 10, 11 and master). The change was ill-considered, and it broke a few normal use cases; since we don't have time to fix it, we'll try again after this week's minor releases. Reported-by: Rushabh La

pgsql: Translation updates

2019-05-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 883c344840ce605f4c9e56453c77190b0d4dcffc Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f578efc97eebd48bc8833a3eb0a89f386b92733f Modified Files --

pgsql: Translation updates

2019-05-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 07a92cdb0f05a078521d8464c99cd654409cd0af Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/54ff9fa588fb85f3e192bb7fe365d9db2eeed8a9 Modified Files --

pgsql: Translation updates

2019-05-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 499248e4e6cd0dea44450fb13352e7a03fccb00e Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1fa14a1a24994bc1de6501952f63b8d8807bf225 Modified Files --

pgsql: Translation updates

2019-05-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: f80b00b1a9a01653acd9f814badda4b2ed0e48f1 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f4540a9c9ca163c8afee2259c6425d82e1aea595 Modified Files --

pgsql: Translation updates

2019-05-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 96d81aab04631d76c9ca90a3b12885100c061775 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dcbdd1a8d55a4fd8a2b318fd5a2647ba4dbb4275 Modified Files --

pgsql: Use checkAsUser for selectivity estimator checks, if it's set.

2019-05-06 Thread Dean Rasheed
Use checkAsUser for selectivity estimator checks, if it's set. In examine_variable() and examine_simple_variable(), when checking the user's table and column privileges to determine whether to grant access to the pg_statistic data, use checkAsUser for the privilege checks, if it's set. This will b

pgsql: Use checkAsUser for selectivity estimator checks, if it's set.

2019-05-06 Thread Dean Rasheed
Use checkAsUser for selectivity estimator checks, if it's set. In examine_variable() and examine_simple_variable(), when checking the user's table and column privileges to determine whether to grant access to the pg_statistic data, use checkAsUser for the privilege checks, if it's set. This will b

pgsql: Use checkAsUser for selectivity estimator checks, if it's set.

2019-05-06 Thread Dean Rasheed
Use checkAsUser for selectivity estimator checks, if it's set. In examine_variable() and examine_simple_variable(), when checking the user's table and column privileges to determine whether to grant access to the pg_statistic data, use checkAsUser for the privilege checks, if it's set. This will b

pgsql: Use checkAsUser for selectivity estimator checks, if it's set.

2019-05-06 Thread Dean Rasheed
Use checkAsUser for selectivity estimator checks, if it's set. In examine_variable() and examine_simple_variable(), when checking the user's table and column privileges to determine whether to grant access to the pg_statistic data, use checkAsUser for the privilege checks, if it's set. This will b

pgsql: Use checkAsUser for selectivity estimator checks, if it's set.

2019-05-06 Thread Dean Rasheed
Use checkAsUser for selectivity estimator checks, if it's set. In examine_variable() and examine_simple_variable(), when checking the user's table and column privileges to determine whether to grant access to the pg_statistic data, use checkAsUser for the privilege checks, if it's set. This will b

pgsql: Use checkAsUser for selectivity estimator checks, if it's set.

2019-05-06 Thread Dean Rasheed
Use checkAsUser for selectivity estimator checks, if it's set. In examine_variable() and examine_simple_variable(), when checking the user's table and column privileges to determine whether to grant access to the pg_statistic data, use checkAsUser for the privilege checks, if it's set. This will b