pgsql: Clean up the behavior and API of catalog.c's is-catalog-relation

2019-05-08 Thread Tom Lane
Clean up the behavior and API of catalog.c's is-catalog-relation tests. The right way for IsCatalogRelation/Class to behave is to return true for OIDs less than FirstBootstrapObjectId (not FirstNormalObjectId), without any of the ad-hoc fooling around with schema membership. The previous code was

pgsql: Fix error status of vacuumdb when multiple jobs are used

2019-05-08 Thread Michael Paquier
Fix error status of vacuumdb when multiple jobs are used When running a batch of VACUUM or ANALYZE commands on a given database, there were cases where it is possible to have vacuumdb not report an error where it actually should, leading to incorrect status results. Author: Julien Rouhaud Reviewe

pgsql: Fix error status of vacuumdb when multiple jobs are used

2019-05-08 Thread Michael Paquier
Fix error status of vacuumdb when multiple jobs are used When running a batch of VACUUM or ANALYZE commands on a given database, there were cases where it is possible to have vacuumdb not report an error where it actually should, leading to incorrect status results. Author: Julien Rouhaud Reviewe

pgsql: Fix error status of vacuumdb when multiple jobs are used

2019-05-08 Thread Michael Paquier
Fix error status of vacuumdb when multiple jobs are used When running a batch of VACUUM or ANALYZE commands on a given database, there were cases where it is possible to have vacuumdb not report an error where it actually should, leading to incorrect status results. Author: Julien Rouhaud Reviewe

pgsql: Fix error status of vacuumdb when multiple jobs are used

2019-05-08 Thread Michael Paquier
Fix error status of vacuumdb when multiple jobs are used When running a batch of VACUUM or ANALYZE commands on a given database, there were cases where it is possible to have vacuumdb not report an error where it actually should, leading to incorrect status results. Author: Julien Rouhaud Reviewe

pgsql: Fix error status of vacuumdb when multiple jobs are used

2019-05-08 Thread Michael Paquier
Fix error status of vacuumdb when multiple jobs are used When running a batch of VACUUM or ANALYZE commands on a given database, there were cases where it is possible to have vacuumdb not report an error where it actually should, leading to incorrect status results. Author: Julien Rouhaud Reviewe

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-08 Thread Tatsuo Ishii
-- Move recovery.conf settings into postgresql.conf (Fujii Masao, Simon Riggs, Abhijit Menon-Sen, Sergei Kornilov) recovery.conf is no longer used, and recovery.signal and standby.signal are used to switch into non-primary mode. trigger_file has been renamed to pro

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-08 Thread Alvaro Herrera
On 2019-May-06, Bruce Momjian wrote: > docs: fist draft version of the PG 12 release notes Hello, thanks for doing this work once again. Typo in surname: "Golgov" is Dolgov. This entry: Allow foreign keys to reference partitioned tables (Alvaro Herrera) says "LIMITATIONS?" but I don't think

pgsql: Remove obsolete nbtree split REDO routine comment.

2019-05-08 Thread Peter Geoghegan
Remove obsolete nbtree split REDO routine comment. Commit dd299df8189, which added suffix truncation to nbtree, simplified the WAL record format used by page splits. It became necessary to explicitly WAL-log the new high key for the left half of a split in all cases, which relieved the REDO routi

pgsql: Fix error messages

2019-05-08 Thread Alvaro Herrera
Fix error messages Some messages related to foreign servers were reporting the server name without quotes, or not at all; our style is to have all names be quoted, and the server name already appears quoted in a few other messages, so just add quotes and make them all consistent. Remove an extra

pgsql: Fix documentation for the privileges required for replication fu

2019-05-08 Thread Fujii Masao
Fix documentation for the privileges required for replication functions. Previously it's documented that use of replication functions is restricted to superusers. This is true for the functions which use replication origin, but not for pg_logicl_emit_message() and functions which use replication s

pgsql: Fix documentation for the privileges required for replication fu

2019-05-08 Thread Fujii Masao
Fix documentation for the privileges required for replication functions. Previously it's documented that use of replication functions is restricted to superusers. This is true for the functions which use replication origin, but not for pg_logicl_emit_message() and functions which use replication s

pgsql: Fix documentation for the privileges required for replication fu

2019-05-08 Thread Fujii Masao
Fix documentation for the privileges required for replication functions. Previously it's documented that use of replication functions is restricted to superusers. This is true for the functions which use replication origin, but not for pg_logicl_emit_message() and functions which use replication s

pgsql: Fix documentation for the privileges required for replication fu

2019-05-08 Thread Fujii Masao
Fix documentation for the privileges required for replication functions. Previously it's documented that use of replication functions is restricted to superusers. This is true for the functions which use replication origin, but not for pg_logicl_emit_message() and functions which use replication s

pgsql: Fix documentation for the privileges required for replication fu

2019-05-08 Thread Fujii Masao
Fix documentation for the privileges required for replication functions. Previously it's documented that use of replication functions is restricted to superusers. This is true for the functions which use replication origin, but not for pg_logicl_emit_message() and functions which use replication s

pgsql: Fix documentation for the privileges required for replication fu

2019-05-08 Thread Fujii Masao
Fix documentation for the privileges required for replication functions. Previously it's documented that use of replication functions is restricted to superusers. This is true for the functions which use replication origin, but not for pg_logicl_emit_message() and functions which use replication s

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-08 Thread Michael Paquier
On Mon, May 06, 2019 at 11:02:37PM +, Bruce Momjian wrote: > docs: fist draft version of the PG 12 release notes > > Still needs text markup, links, word wrap, and indenting. I have noticed a duplicated word: $ git grep "new new" doc/src/sgml/release-12.sgml:Update unaccent rules with new ne

Re: pgsql: docs: fist draft version of the PG 12 release notes

2019-05-08 Thread Oleg Bartunov
On Tue, May 7, 2019 at 2:02 AM Bruce Momjian wrote: > > docs: fist draft version of the PG 12 release notes > > Still needs text markup, links, word wrap, and indenting. "This allows JSON values to be selected using an SQL-standard language." better "This allows to execute complex queries on JSO

pgsql: Fix table lock levels for REINDEX INDEX CONCURRENTLY

2019-05-08 Thread Peter Eisentraut
Fix table lock levels for REINDEX INDEX CONCURRENTLY REINDEX CONCURRENTLY locks tables with ShareUpdateExclusiveLock rather than the ShareLock used by a plain REINDEX. However, RangeVarCallbackForReindexIndex() was not updated for that and still used the ShareLock only. This would lead to lock u

pgsql: Probe only 127.0.0.1 when looking for ports on Unix.

2019-05-08 Thread Thomas Munro
Probe only 127.0.0.1 when looking for ports on Unix. Commit c0985099, later adjusted by commit 4ab02e81, probed 0.0.0.0 in addition to 127.0.0.1, for the benefit of Windows build farm animals. It isn't really useful on Unix systems, and turned out to be a bit inconvenient to users of some corpora

pgsql: Probe only 127.0.0.1 when looking for ports on Unix.

2019-05-08 Thread Thomas Munro
Probe only 127.0.0.1 when looking for ports on Unix. Commit c0985099, later adjusted by commit 4ab02e81, probed 0.0.0.0 in addition to 127.0.0.1, for the benefit of Windows build farm animals. It isn't really useful on Unix systems, and turned out to be a bit inconvenient to users of some corpora

pgsql: Probe only 127.0.0.1 when looking for ports on Unix.

2019-05-08 Thread Thomas Munro
Probe only 127.0.0.1 when looking for ports on Unix. Commit c0985099, later adjusted by commit 4ab02e81, probed 0.0.0.0 in addition to 127.0.0.1, for the benefit of Windows build farm animals. It isn't really useful on Unix systems, and turned out to be a bit inconvenient to users of some corpora

pgsql: Probe only 127.0.0.1 when looking for ports on Unix.

2019-05-08 Thread Thomas Munro
Probe only 127.0.0.1 when looking for ports on Unix. Commit c0985099, later adjusted by commit 4ab02e81, probed 0.0.0.0 in addition to 127.0.0.1, for the benefit of Windows build farm animals. It isn't really useful on Unix systems, and turned out to be a bit inconvenient to users of some corpora

pgsql: Fix copy-and-paste mistakes in documentation.

2019-05-08 Thread Thomas Munro
Fix copy-and-paste mistakes in documentation. Reported-by: Vik Fearing Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/098344be663f5fc0ad166e7a9e1cd37721ee34d9 Modified Files -- doc/src/sgml/ref/create_table.sgml| 2 +- doc/src/sgml/ref/create_table_

pgsql: Add missing periods to comments.

2019-05-08 Thread Etsuro Fujita
Add missing periods to comments. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b7434dc007252d7a5e5f7f85700bd7400b1db201 Modified Files -- src/include/nodes/pathnodes.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)