pgsql: Handle table_complete_speculative's succeeded argument as docume

2019-05-14 Thread Andres Freund
Handle table_complete_speculative's succeeded argument as documented. For some reason both callsite and the implementation for heapam had the meaning inverted (i.e. succeeded == true was passed in case of conflict). That's confusing. I (Andres) briefly pondered whether it'd be better to rename ta

pgsql: Add isolation test for INSERT ON CONFLICT speculative insertion

2019-05-14 Thread Andres Freund
Add isolation test for INSERT ON CONFLICT speculative insertion failure. This path previously was not reliably covered. There was some heuristic coverage via insert-conflict-toast.spec, but that test is not deterministic, and only tested for a somewhat specific bug. Backpatch, as this is a compli

pgsql: Add isolation test for INSERT ON CONFLICT speculative insertion

2019-05-14 Thread Andres Freund
Add isolation test for INSERT ON CONFLICT speculative insertion failure. This path previously was not reliably covered. There was some heuristic coverage via insert-conflict-toast.spec, but that test is not deterministic, and only tested for a somewhat specific bug. Backpatch, as this is a compli

pgsql: Add isolation test for INSERT ON CONFLICT speculative insertion

2019-05-14 Thread Andres Freund
Add isolation test for INSERT ON CONFLICT speculative insertion failure. This path previously was not reliably covered. There was some heuristic coverage via insert-conflict-toast.spec, but that test is not deterministic, and only tested for a somewhat specific bug. Backpatch, as this is a compli

pgsql: Add isolation test for INSERT ON CONFLICT speculative insertion

2019-05-14 Thread Andres Freund
Add isolation test for INSERT ON CONFLICT speculative insertion failure. This path previously was not reliably covered. There was some heuristic coverage via insert-conflict-toast.spec, but that test is not deterministic, and only tested for a somewhat specific bug. Backpatch, as this is a compli

pgsql: Fix "make clean" to clean out junk files left behind after ssl t

2019-05-14 Thread Tom Lane
Fix "make clean" to clean out junk files left behind after ssl tests. We .gitignore'd this junk, but we didn't actually remove it. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6d2fba3189608186d1a196a595f21760412ec5e8 Modified Files -- src/test/ssl/Ma

pgsql: Move logging.h and logging.c from src/fe_utils/ to src/common/.

2019-05-14 Thread Tom Lane
Move logging.h and logging.c from src/fe_utils/ to src/common/. The original placement of this module in src/fe_utils/ is ill-considered, because several src/common/ modules have dependencies on it, meaning that libpgcommon and libpgfeutils now have mutual dependencies. That makes it pointless to

pgsql: docs: Indent listitem tags in PG 12 release notes

2019-05-14 Thread Bruce Momjian
docs: Indent listitem tags in PG 12 release notes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b71dad22ce8a645a47c01e544f640f35b91bfbd3 Modified Files -- doc/src/sgml/release-12.sgml | 750 +-- 1 file changed, 3

pgsql: Remove pg_rewind's private logging.h/logging.c files.

2019-05-14 Thread Tom Lane
Remove pg_rewind's private logging.h/logging.c files. The existence of these files became rather confusing with the introduction of a widely-known logging.h header in commit cc8d41511. (Indeed, there's already some duplicative #includes here, perhaps betraying such confusion.) The only thing left

pgsql: Fix SQL-style substring() to have spec-compliant greediness beha

2019-05-14 Thread Tom Lane
Fix SQL-style substring() to have spec-compliant greediness behavior. SQL's regular-expression substring() function is defined to have a pattern argument that's separated into three subpatterns by escape- double-quote markers; the function result is the part of the input matching the second subpat

pgsql: In bootstrap mode, use default signal handling for SIGINT etc.

2019-05-14 Thread Tom Lane
In bootstrap mode, use default signal handling for SIGINT etc. Previously, the code pointed the standard process-termination signals to postgres.c's die(). That would typically result in an attempt to execute a transaction abort, which is not possible in bootstrap mode, leading to PANIC. This ch

pgsql: Update SQL features/conformance information to SQL:2016

2019-05-14 Thread Peter Eisentraut
Update SQL features/conformance information to SQL:2016 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/037165ca95d854e04c0c28cfa85f1515bd852892 Modified Files -- doc/src/sgml/features.sgml | 16 +- src/backend/catalog/information_

pgsql: Update SQL keywords list to SQL:2016

2019-05-14 Thread Peter Eisentraut
Update SQL keywords list to SQL:2016 Per previous convention (see ace397e9d24eddc56e7dffa921f506117b602d78), drop SQL:2008 and only keep the latest two standards and SQL-92. Note: SQL:2016-2 lists a large number of non-reserved keywords that are really just information_schema column names related

pgsql: Update information_schema for SQL:2016

2019-05-14 Thread Peter Eisentraut
Update information_schema for SQL:2016 This is mainly a light renumbering to match the sections in the standard. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eb3a1376c98a1d220354b468f4b09e4a1dca909a Modified Files -- src/backend/catalog/information_s

pgsql: docs: update partition item in PG 12 release notes

2019-05-14 Thread Bruce Momjian
docs: update partition item in PG 12 release notes Reported-by: Amit Langote Discussion: https://postgr.es/m/b7954643-41ef-a174-479d-1f8d4834f...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/356c83795aaa39cfd9bca588bfe4f0196710962e Modified File

pgsql: docs: fix duplicate wording in PG 12 release notes

2019-05-14 Thread Bruce Momjian
docs: fix duplicate wording in PG 12 release notes Reported-by: ni...@imap.cc Discussion: https://postgr.es/m/6b3414e1-fcef-4ad9-b123-b3ab3702d...@www.fastmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/34d40becfa7a5c7343d0079f181597d7e06122e1 Modified

pgsql: Detect internal GiST page splits correctly during index build.

2019-05-14 Thread Heikki Linnakangas
Detect internal GiST page splits correctly during index build. As we descend the GiST tree during insertion, we modify any downlinks on the way down to include the new tuple we're about to insert (if they don't cover it already). Modifying an existing downlink might cause an internal page to split

pgsql: Fix comment on when HOT update is possible.

2019-05-14 Thread Heikki Linnakangas
Fix comment on when HOT update is possible. The conditions listed in this comment have changed several times, and at some point the thing that the "if so" referred to was negated. The text was OK up to 9.6. It was differently wrong in v10, v11 and master, so fix in all those versions. Branch ---

pgsql: Fix comment on when HOT update is possible.

2019-05-14 Thread Heikki Linnakangas
Fix comment on when HOT update is possible. The conditions listed in this comment have changed several times, and at some point the thing that the "if so" referred to was negated. The text was OK up to 9.6. It was differently wrong in v10, v11 and master, so fix in all those versions. Branch ---

pgsql: Fix comment on when HOT update is possible.

2019-05-14 Thread Heikki Linnakangas
Fix comment on when HOT update is possible. The conditions listed in this comment have changed several times, and at some point the thing that the "if so" referred to was negated. The text was OK up to 9.6. It was differently wrong in v10, v11 and master, so fix in all those versions. Branch ---

pgsql: Fix typo.

2019-05-14 Thread Etsuro Fujita
Fix typo. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7d9eca59cf958eb8c8ff47c40003392681a9ce68 Modified Files -- src/backend/utils/misc/postgresql.conf.sample | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)