Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Tom Lane
Andres Freund writes: > On 2019-05-20 20:19:20 -0400, Tom Lane wrote: >> The other thing I had to do below was to suppress "NOTICE: database >> "regression" does not exist, skipping". The added createdb is a >> mighty expensive and grotty way to do that, but I didn't immediately >> see a better o

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Andres Freund
Hi, On 2019-05-20 20:19:20 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-20 14:09:40 -0400, Tom Lane wrote: > >> What I'd like, for both prove and pg_regress, is to print something > >> about failing tests and otherwise be quiet. Simple redirection won't > >> do that. Plus it'd

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Tom Lane
Andres Freund writes: > On 2019-05-20 14:09:40 -0400, Tom Lane wrote: >> What I'd like, for both prove and pg_regress, is to print something >> about failing tests and otherwise be quiet. Simple redirection won't >> do that. Plus it'd be hard to fit that in with the case where you >> don't want

pgsql: Doc: improve description of regexp character classes.

2019-05-20 Thread Tom Lane
Doc: improve description of regexp character classes. Define the meanings of the POSIX-spec character classes in line, rather than referring to the ctype(3) man page. That man page doesn't even exist on many modern systems, and if it does exist it probably says the wrong things about non-ASCII ch

pgsql: Stamp 12beta1.

2019-05-20 Thread Tom Lane
Stamp 12beta1. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a240570b1e3802d1e82da08a9d72abeade370249 Modified Files -- configure | 18 +- configure.in | 2 +- src/include/pg_config.h.win32 | 6 +++--

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Andres Freund
Hi, On 2019-05-20 14:09:40 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-20 13:46:55 -0400, Tom Lane wrote: > >> If there were a way to get prove to be absolutely quiet (its --quiet is > >> a joke unfortunately), I'd lobby for a switch to make pg_regress quiet > >> too. The amoun

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Tom Lane
Andres Freund writes: > On 2019-05-20 13:46:55 -0400, Tom Lane wrote: >> If there were a way to get prove to be absolutely quiet (its --quiet is >> a joke unfortunately), I'd lobby for a switch to make pg_regress quiet >> too. The amount of useless noise this recipe generates is annoying, >> and

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Andres Freund
Hi, On 2019-05-20 13:46:55 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-21 01:43:35 +0900, Fujii Masao wrote: > >> Thanks for the commit! And sorry, make check-world took very long time > >> and has just finished right now in my env... I'd like to confirm that > >> make check-wor

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Tom Lane
Andres Freund writes: > On 2019-05-21 01:43:35 +0900, Fujii Masao wrote: >> Thanks for the commit! And sorry, make check-world took very long time >> and has just finished right now in my env... I'd like to confirm that >> make check-world reports no error just in case. > make -j16 -s && make -Ot

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Andres Freund
Hi, On 2019-05-21 01:43:35 +0900, Fujii Masao wrote: > On Tue, May 21, 2019 at 1:36 AM Andres Freund wrote: > > On 2019-05-21 01:03:06 +0900, Fujii Masao wrote: > > > On Tue, May 21, 2019 at 12:43 AM Tom Lane wrote: > > > > > > > > Fujii Masao writes: > > > > > Make VACUUM accept 1 and 0 as a b

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Fujii Masao
On Tue, May 21, 2019 at 1:36 AM Andres Freund wrote: > > Hi, > > On 2019-05-21 01:03:06 +0900, Fujii Masao wrote: > > On Tue, May 21, 2019 at 12:43 AM Tom Lane wrote: > > > > > > Fujii Masao writes: > > > > Make VACUUM accept 1 and 0 as a boolean value. > > > > > > This was not a particularly gr

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Andres Freund
Hi, On 2019-05-21 01:03:06 +0900, Fujii Masao wrote: > On Tue, May 21, 2019 at 12:43 AM Tom Lane wrote: > > > > Fujii Masao writes: > > > Make VACUUM accept 1 and 0 as a boolean value. > > > > This was not a particularly great thing to be pushing on a release > > wrap day, and pushing it without

pgsql: Fix regression tests broken in fc7c281f87467.

2019-05-20 Thread Andres Freund
Fix regression tests broken in fc7c281f87467. This shouldn't have been committed without even running the tests (nor were the tests added that were suggested). I'm fixing up the results to get the buildfarm back to green, it's quite possible we'll want to revert this later. Branch -- master

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Fujii Masao
On Tue, May 21, 2019 at 12:43 AM Tom Lane wrote: > > Fujii Masao writes: > > Make VACUUM accept 1 and 0 as a boolean value. > > This was not a particularly great thing to be pushing on a release > wrap day, and pushing it without having even run the core regression > tests was downright negligent

pgsql: Fix comment for issue_xlog_fsync().

2019-05-20 Thread Fujii Masao
Fix comment for issue_xlog_fsync(). "segno" is the argument for the function, not "log" and "seg". Author: Antonin Houska Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b8e2170e40a151eb94079ce9cd791a712ed9

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Tom Lane
Fujii Masao writes: > Make VACUUM accept 1 and 0 as a boolean value. This was not a particularly great thing to be pushing on a release wrap day, and pushing it without having even run the core regression tests was downright negligent. Please fix or revert, NOW. regards,

pgsql: Make VACUUM accept 1 and 0 as a boolean value.

2019-05-20 Thread Fujii Masao
Make VACUUM accept 1 and 0 as a boolean value. Commit 41b54ba78e allowed existing VACUUM options to take a boolean argument. It's documented that valid boolean values that VACUUM can accept are true, false, on, off, 1, and 0. But previously the parser failed to accept 1 and 0 as a boolean value in

pgsql: Translation updates

2019-05-20 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: a20bf6b8a5b4e32450967055eb5b07cee4704edd Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3c439a58df83ae51f650cfae9878df1f9b70c4b8 Modified Files -