pgsql: Add pg_dumpall --rows-per-insert

2019-06-14 Thread Alvaro Herrera
Add pg_dumpall --rows-per-insert Commit 7e413a0f82c8 added that option to pg_dump, but neglected to teach pg_dumpall how to pass it along. Repair. Author: Fabien Coelho Reported-by: Peter Eisentraut Reviewed-by: David Rowley Discussion: https://postgr.es/m/45f50c59-ddbb-8cf2-eedb-81003f603...@2

pgsql: Tweak libpq's PQhost, PQhostaddr, and psql's \connect

2019-06-14 Thread Alvaro Herrera
Tweak libpq's PQhost, PQhostaddr, and psql's \connect Fixes some problems introduced by 6e5f8d489acc: * When reusing conninfo data from the previous connection in \connect, the host address should only be reused if it was specified as hostaddr; if it wasn't, then 'host' is resolved afresh. W

pgsql: First-draft release notes for 11.4.

2019-06-14 Thread Tom Lane
First-draft release notes for 11.4. As usual, the release notes for other branches will be made by cutting these down, but put them up for community review first. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0995cefa74510ee0e38d1bf095b2eef2c1ea37c4 Modifi

Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock

2019-06-14 Thread Alvaro Herrera
On 2019-Jun-14, Tom Lane wrote: > I wrote: > >> Hm, I don't get that warning. Does this patch silence it, please? > > > Uh, no patch attached? But initializing the variable where it's > > declared would certainly silence it. > > BTW, after looking around a bit I wonder if this complaint isn't

pgsql: Silence compiler warning

2019-06-14 Thread Alvaro Herrera
Silence compiler warning Introduced in de87a084c0a5. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1f8f144fe3a98928a026af9c2a45e57a962cc90d Modified Files -- src/backend/access/heap/heapam.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-

pgsql: Silence compiler warning

2019-06-14 Thread Alvaro Herrera
Silence compiler warning Introduced in de87a084c0a5. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/744639739c7c6a53bcbf4cd6fe765d7ebd89716a Modified Files -- src/backend/access/heap/heapam.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-

pgsql: Silence compiler warning

2019-06-14 Thread Alvaro Herrera
Silence compiler warning Introduced in de87a084c0a5. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/563357a12c9b1cdbae29a2d0d09eb9f2c01da4d6 Modified Files -- src/backend/access/heap/heapam.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-

pgsql: Silence compiler warning

2019-06-14 Thread Alvaro Herrera
Silence compiler warning Introduced in de87a084c0a5. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3da73d6839dc47f1f47ca57974bf28e5abd9b572 Modified Files -- src/backend/access/heap/heapam.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock

2019-06-14 Thread Tom Lane
I wrote: >> Hm, I don't get that warning. Does this patch silence it, please? > Uh, no patch attached? But initializing the variable where it's > declared would certainly silence it. BTW, after looking around a bit I wonder if this complaint isn't exposing an actual logic bug. Shouldn't skip_t

Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock

2019-06-14 Thread Tom Lane
Alvaro Herrera writes: > On 2019-Jun-14, Tom Lane wrote: >> I'm now getting >> heapam.c: In function 'heap_lock_tuple': >> heapam.c:4041: warning: 'skip_tuple_lock' may be used uninitialized in this >> function > Hm, I don't get that warning. Does this patch silence it, please? Uh, no patch at

pgsql: Attempt to identify system timezone by reading /etc/localtime sy

2019-06-14 Thread Tom Lane
Attempt to identify system timezone by reading /etc/localtime symlink. On many modern platforms, /etc/localtime is a symlink to a file within the IANA database. Reading the symlink lets us find out the name of the system timezone directly, without going through the brute-force search embodied in

pgsql: Attempt to identify system timezone by reading /etc/localtime sy

2019-06-14 Thread Tom Lane
Attempt to identify system timezone by reading /etc/localtime symlink. On many modern platforms, /etc/localtime is a symlink to a file within the IANA database. Reading the symlink lets us find out the name of the system timezone directly, without going through the brute-force search embodied in

pgsql: Attempt to identify system timezone by reading /etc/localtime sy

2019-06-14 Thread Tom Lane
Attempt to identify system timezone by reading /etc/localtime symlink. On many modern platforms, /etc/localtime is a symlink to a file within the IANA database. Reading the symlink lets us find out the name of the system timezone directly, without going through the brute-force search embodied in

pgsql: Attempt to identify system timezone by reading /etc/localtime sy

2019-06-14 Thread Tom Lane
Attempt to identify system timezone by reading /etc/localtime symlink. On many modern platforms, /etc/localtime is a symlink to a file within the IANA database. Reading the symlink lets us find out the name of the system timezone directly, without going through the brute-force search embodied in

pgsql: Attempt to identify system timezone by reading /etc/localtime sy

2019-06-14 Thread Tom Lane
Attempt to identify system timezone by reading /etc/localtime symlink. On many modern platforms, /etc/localtime is a symlink to a file within the IANA database. Reading the symlink lets us find out the name of the system timezone directly, without going through the brute-force search embodied in

Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock

2019-06-14 Thread Alvaro Herrera
On 2019-Jun-14, Tom Lane wrote: > Alvaro Herrera writes: > > Avoid spurious deadlocks when upgrading a tuple lock > > I'm now getting > > heapam.c: In function 'heap_lock_tuple': > heapam.c:4041: warning: 'skip_tuple_lock' may be used uninitialized in this > function Hm, I don't get that warn

Re: pgsql: Avoid spurious deadlocks when upgrading a tuple lock

2019-06-14 Thread Tom Lane
Alvaro Herrera writes: > Avoid spurious deadlocks when upgrading a tuple lock I'm now getting heapam.c: In function 'heap_lock_tuple': heapam.c:4041: warning: 'skip_tuple_lock' may be used uninitialized in this function Please fix. regards, tom lane

pgsql: doc: PG 12 relnotes, add mention of single-child optimization

2019-06-14 Thread Bruce Momjian
doc: PG 12 relnotes, add mention of single-child optimization Add mention of single-child optimization for partitions and UNION ALL. Reported-by: David Rowley Discussion: https://postgr.es/m/CAKJS1f8R8riwBXw==7ijV=UZNuhP+3qXgDBKSiM+=_ctf4m...@mail.gmail.com Branch -- master Details -

pgsql: postgres_fdw: Fix costing of pre-sorted foreign paths with local

2019-06-14 Thread Etsuro Fujita
postgres_fdw: Fix costing of pre-sorted foreign paths with local stats. Commit aa09cd242 modified estimate_path_cost_size() so that it reuses cached costs of a basic foreign path for a given foreign-base/join relation when costing pre-sorted foreign paths for that relation, but it incorrectly re-c