Re: pgsql: Fix partitioned index creation with foreign partitions

2019-06-26 Thread Amit Langote
On Thu, Jun 27, 2019 at 8:04 AM Alvaro Herrera wrote: > > On 2019-Jun-26, Alvaro Herrera wrote: > > > Fix partitioned index creation with foreign partitions > > Hmm, so this causes prion to fail, because -DFORCE_RELCACHE_RELEASE: it > reports the immediate parent of the would-be-partition rather t

pgsql: Remove remaining traces of Rand_OpenSSL() from the tree

2019-06-26 Thread Michael Paquier
Remove remaining traces of Rand_OpenSSL() from the tree fe0a0b5 has removed the last use of this routine from pgcrypto, leading to a useless symbol definition and an extra configure check. Author: Michael Paquier Reviewed-by: Daniel Gustafsson, Tom Lane Discussion: https://postgr.es/m/20190626142

Re: pgsql: Fix partitioned index creation with foreign partitions

2019-06-26 Thread Alvaro Herrera
On 2019-Jun-26, Alvaro Herrera wrote: > Fix partitioned index creation with foreign partitions Hmm, so this causes prion to fail, because -DFORCE_RELCACHE_RELEASE: it reports the immediate parent of the would-be-partition rather than the topmost ancestor. I'm not sure I understand why, since rel

pgsql: Fix partitioned index creation with foreign partitions

2019-06-26 Thread Alvaro Herrera
Fix partitioned index creation with foreign partitions When a partitioned tables contains foreign tables as partitions, it is not possible to implement unique or primary key indexes -- but when regular indexes are created, there is no reason to do anything other than ignoring such partitions. We

pgsql: Fix partitioned index creation with foreign partitions

2019-06-26 Thread Alvaro Herrera
Fix partitioned index creation with foreign partitions When a partitioned tables contains foreign tables as partitions, it is not possible to implement unique or primary key indexes -- but when regular indexes are created, there is no reason to do anything other than ignoring such partitions. We

Re: pgsql: Drop test user when done with it.

2019-06-26 Thread Stephen Frost
Greetings, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > On 2019-Jun-26, Stephen Frost wrote: > > > Isn’t this the one run from pg_upgrade’s tests? We don’t want to break that > > (and hopefully we haven’t but maybe something did...). Pretty sure we had > > nearly the same discussion this

Re: pgsql: Drop test user when done with it.

2019-06-26 Thread Alvaro Herrera
On 2019-Jun-26, Stephen Frost wrote: > Isn’t this the one run from pg_upgrade’s tests? We don’t want to break that > (and hopefully we haven’t but maybe something did...). Pretty sure we had > nearly the same discussion this past fall... https://postgr.es/m/20180904203012.gg20...@paquier.xyz ?

Re: pgsql: Drop test user when done with it.

2019-06-26 Thread Stephen Frost
Greetings, On Wed, Jun 26, 2019 at 10:51 Tom Lane wrote: > I wrote: > > Michael Paquier writes: > >> If we are on that, we still have src/test/modules/test_pg_dump/ which > >> is not repeatable with multiple installchecks: > >> > https://www.postgresql.org/message-id/20181130163728.ge3...@tamri

Re: pgsql: Drop test user when done with it.

2019-06-26 Thread Tom Lane
I wrote: > Michael Paquier writes: >> If we are on that, we still have src/test/modules/test_pg_dump/ which >> is not repeatable with multiple installchecks: >> https://www.postgresql.org/message-id/20181130163728.ge3...@tamriel.snowman.net > OK, hadn't run into that personally, but let's fix tha

pgsql: Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts

2019-06-26 Thread Michael Paquier
Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts Up to now, the MSVC build scripts are able to support only one fixed version of OpenSSL, and they lacked logic to detect the version of OpenSSL a given compilation of Postgres is linking to (currently 1.0.2, the latest LTS of upstrea

pgsql: Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts

2019-06-26 Thread Michael Paquier
Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts Up to now, the MSVC build scripts are able to support only one fixed version of OpenSSL, and they lacked logic to detect the version of OpenSSL a given compilation of Postgres is linking to (currently 1.0.2, the latest LTS of upstrea

pgsql: Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts

2019-06-26 Thread Michael Paquier
Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts Up to now, the MSVC build scripts are able to support only one fixed version of OpenSSL, and they lacked logic to detect the version of OpenSSL a given compilation of Postgres is linking to (currently 1.0.2, the latest LTS of upstrea

pgsql: Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts

2019-06-26 Thread Michael Paquier
Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts Up to now, the MSVC build scripts are able to support only one fixed version of OpenSSL, and they lacked logic to detect the version of OpenSSL a given compilation of Postgres is linking to (currently 1.0.2, the latest LTS of upstrea

pgsql: Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts

2019-06-26 Thread Michael Paquier
Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts Up to now, the MSVC build scripts are able to support only one fixed version of OpenSSL, and they lacked logic to detect the version of OpenSSL a given compilation of Postgres is linking to (currently 1.0.2, the latest LTS of upstrea

Re: pgsql: Drop test user when done with it.

2019-06-26 Thread Tom Lane
Michael Paquier writes: > On Mon, Jun 24, 2019 at 04:37:13PM +, Tom Lane wrote: >> Commit d7f8d26d9 added a test case that created a user, but forgot >> to drop it again. This is no good; for one thing, it causes repeated >> "make installcheck" runs to fail. > If we are on that, we still hav