pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by: Ashwin

pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by: Ashwin

pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by: Ashwin

pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by: Ashwin

pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by: Ashwin

pgsql: Fix misleading comment in nodeIndexonlyscan.c.

2019-06-27 Thread Thomas Munro
Fix misleading comment in nodeIndexonlyscan.c. The stated reason for acquiring predicate locks on heap pages hasn't existed since commit c01262a8, so fix the comment. Perhaps in a later release we'll also be able to change the code to use tuple locks. Back-patch all the way. Reviewed-by: Ashwin

pgsql: Update reference to sampling algorithm in analyze.c

2019-06-27 Thread Tomas Vondra
Update reference to sampling algorithm in analyze.c Commit 83e176ec1 moved row sampling functions from analyze.c to utils/misc/sampling.c, but failed to update comment referring to the sampling algorithm from Jeff Vitter's paper. Correct the comment by pointing to utils/misc/sampling.c. Author: E

pgsql: Update reference to sampling algorithm in analyze.c

2019-06-27 Thread Tomas Vondra
Update reference to sampling algorithm in analyze.c Commit 83e176ec1 moved row sampling functions from analyze.c to utils/misc/sampling.c, but failed to update comment referring to the sampling algorithm from Jeff Vitter's paper. Correct the comment by pointing to utils/misc/sampling.c. Author: E

pgsql: Update reference to sampling algorithm in analyze.c

2019-06-27 Thread Tomas Vondra
Update reference to sampling algorithm in analyze.c Commit 83e176ec1 moved row sampling functions from analyze.c to utils/misc/sampling.c, but failed to update comment referring to the sampling algorithm from Jeff Vitter's paper. Correct the comment by pointing to utils/misc/sampling.c. Author: E

pgsql: Update reference to sampling algorithm in analyze.c

2019-06-27 Thread Tomas Vondra
Update reference to sampling algorithm in analyze.c Commit 83e176ec1 moved row sampling functions from analyze.c to utils/misc/sampling.c, but failed to update comment referring to the sampling algorithm from Jeff Vitter's paper. Correct the comment by pointing to utils/misc/sampling.c. Author: E

pgsql: Update reference to sampling algorithm in analyze.c

2019-06-27 Thread Tomas Vondra
Update reference to sampling algorithm in analyze.c Commit 83e176ec1 moved row sampling functions from analyze.c to utils/misc/sampling.c, but failed to update comment referring to the sampling algorithm from Jeff Vitter's paper. Correct the comment by pointing to utils/misc/sampling.c. Author: E

pgsql: Update reference to sampling algorithm in analyze.c

2019-06-27 Thread Tomas Vondra
Update reference to sampling algorithm in analyze.c Commit 83e176ec1 moved row sampling functions from analyze.c to utils/misc/sampling.c, but failed to update comment referring to the sampling algorithm from Jeff Vitter's paper. Correct the comment by pointing to utils/misc/sampling.c. Author: E

Re: pgsql: Fix partitioned index creation with foreign partitions

2019-06-27 Thread Alvaro Herrera
On 2019-Jun-27, Amit Langote wrote: > Anyway, the problem seems to use-after-close of a Relation pointer, > which the attached patch fixes. Indeed, thanks for tracking it down. Pushed. I couldn't resist the temptation remove a no-longer-necessary tupdesc copy while at it. -- Álvaro Herrera

pgsql: Fix use-after-free introduced in 55ed3defc966

2019-06-27 Thread Alvaro Herrera
Fix use-after-free introduced in 55ed3defc966 Evidenced by failure under RELCACHE_FORCE_RELEASE (buildfarm member prion). Author: Amit Langote Discussion: https://postgr.es/m/CA+HiwqGV=k_eh4jbiqw66ivvdg+eukreyehtyl1svdj_yoy...@mail.gmail.com Branch -- REL_11_STABLE Details --- https://

pgsql: Fix use-after-free introduced in 55ed3defc966

2019-06-27 Thread Alvaro Herrera
Fix use-after-free introduced in 55ed3defc966 Evidenced by failure under RELCACHE_FORCE_RELEASE (buildfarm member prion). Author: Amit Langote Discussion: https://postgr.es/m/CA+HiwqGV=k_eh4jbiqw66ivvdg+eukreyehtyl1svdj_yoy...@mail.gmail.com Branch -- master Details --- https://git.pos

pgsql: Update comment

2019-06-27 Thread Peter Eisentraut
Update comment Function was renamed/replaced in c2fe139c201c48f1133e9fbea2dd99b8efe2fadd but the header comment was not updated. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f2f0082ef5969b57d0b52d0c2e891872ed1b0a51 Modified Files -- src/backend/acces

Re: pgsql: Drop test user when done with it.

2019-06-27 Thread Michael Paquier
On Wed, Jun 26, 2019 at 03:07:33PM -0400, Stephen Frost wrote: > Yes, thanks, and specifically this: > > https://www.postgresql.org/message-id/20181130163728.GE3415%40tamriel.snowman.net > > Adding 'DROP IF EXISTS' to the top to have things cleaned up so that the > run can be repeated is fine. R