pgsql: Remove obsolete nbtree "get root" comment.

Remove obsolete nbtree "get root" comment. Remove a very old Berkeley era comment that doesn't seem to have anything to do with the current locking considerations within _bt_getroot(). Discussion: https://postgr.es/m/cah2-wzma2h+rl-xxf5o6qhmd+9x6cjtnz2mr3li_pbpbmqo...@mail.gmail.com Branch

pgsql: Add support for Visual Studio 2019 in build scripts

Add support for Visual Studio 2019 in build scripts This fixes at the same time a set of inconsistencies in the documentation and the scripts related to the versions of Windows SDK supported. Author: Haribabu Kommi Reviewed-by: Andrew Dunstan, Juan José Santamaría Flecha, Michael Paquier Discussi

pgsql: Refactor code of reindexdb for query generation

Refactor code of reindexdb for query generation This merges the portion related to REINDEX SYSTEM into the routine already available for all the other reindex types, making the query generation cleaner. While on it, change the handling of the reindex types using an enum, which allows to get rid o

pgsql: Revert "Insert temporary debugging output in regression tests."

Revert "Insert temporary debugging output in regression tests." This reverts commit f03a9ca4366d064d89b7cf7ed75d4e43f2ed0667, in the v12 branch only. We don't want to ship v12 with that, since it causes occasional test failures (as a result of statistics transmission not being entirely reliable).

pgsql: Remove support for non-ELF BSD systems

Remove support for non-ELF BSD systems This is long obsolete. Discussion: https://www.postgresql.org/message-id/8eacdc0d-123f-dbca-bacf-0a68766a4...@2ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c72f9b9502eadb6b84c6681cdb3bff12b35d3c8a Modified

pgsql: Branch refs/heads/REL_12_STABLE was created

Branch refs/heads/REL_12_STABLE was created. View: https://git.postgresql.org/pg/shortlog/refs/heads/REL_12_STABLE

pgsql: Stamp HEAD as 13devel.

Stamp HEAD as 13devel. Let the hacking begin ... Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/615cebc94b5ef8fbe353e3c8b838b1e97bcdfd49 Modified Files -- configure| 18 +- configure.in |2 +- doc/src/sgm

pgsql: pgindent run prior to branching v12.

pgindent run prior to branching v12. pgperltidy and reformat-dat-files too, though the latter didn't find anything to change. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9e1c9f959422192bbe1b842a2a1ffaf76b080196 Modified Files -- contrib/postgres_fdw

pgsql: Doc: remove obsolete description of oid column as being "hidden"

Doc: remove obsolete description of oid column as being "hidden". Looks like one copy of this text didn't get updated. Justin Pryzby Discussion: https://postgr.es/m/20190701155932.ga22...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/145b18688c0496

Re: pgsql: Remove surplus call to table_finish_bulk_insert

On Tue, 2 Jul 2019 at 03:33, Tom Lane wrote: > > David Rowley writes: > > Remove surplus call to table_finish_bulk_insert > > This still blows up immediately with -DRELCACHE_FORCE_RELEASE > (cf prion). > > I think at this point you should revert and try again later. > This is blocking making the

pgsql: Revert fix missing call to table_finish_bulk_insert during COPY

Revert fix missing call to table_finish_bulk_insert during COPY This reverts commits 4de60244e and b2d69806d. Further thought is required to make this work properly. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f5db56fc4d6e95c582b61c99328ea0702b869fa0 Modified F

Re: pgsql: Remove surplus call to table_finish_bulk_insert

David Rowley writes: > Remove surplus call to table_finish_bulk_insert This still blows up immediately with -DRELCACHE_FORCE_RELEASE (cf prion). I think at this point you should revert and try again later. This is blocking making the v12 branch, and it obviously needs more thought.

pgsql: Remove surplus call to table_finish_bulk_insert

Remove surplus call to table_finish_bulk_insert 4de60244e added the call to table_finish_bulk_insert to the CopyMultiInsertBufferCleanup function. We use a CopyMultiInsertBuffer even for non-partitioned tables, so having the cleanup do that meant we would call table_finsh_bulk_insert twice when p

Re: pgsql: Fix missing call to table_finish_bulk_insert during COPY

On Tue, 2 Jul 2019 at 01:24, David Rowley wrote: > src/backend/commands/copy.c | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) Looking at buildfarm now. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &

pgsql: Fix missing call to table_finish_bulk_insert during COPY

Fix missing call to table_finish_bulk_insert during COPY 86b85044e abstracted calls to heap functions in COPY FROM to support a generic table AM. However, when performing a copy into a partitioned table, this commit neglected to call table_finish_bulk_insert for each partition. Before 86b85044e,

pgsql: Convert some stragglers to new frontend logging API

Convert some stragglers to new frontend logging API Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/95bbe5d82e428db342fa3ec60b95f1b9873741e5 Modified Files -- src/bin/initdb/initdb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

pgsql: Add missing serial commas

Add missing serial commas Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1b29e990e352885642149262859b83c19d362405 Modified Files -- src/backend/catalog/pg_proc.c | 2 +- src/bin/pg_checksums/pg_checksums.c | 2 +- src/bin/pg_dump/pg_dump.c