pgsql: Fix variable initialization when using buffering build with GiST

2019-07-09 Thread Michael Paquier
Fix variable initialization when using buffering build with GiST This can cause valgrind to complain, as the flag marking a buffer as a temporary copy was not getting initialized. While on it, fill in with zeros newly-created buffer pages. This does not matter when loading a block from a tempora

pgsql: Fix variable initialization when using buffering build with GiST

2019-07-09 Thread Michael Paquier
Fix variable initialization when using buffering build with GiST This can cause valgrind to complain, as the flag marking a buffer as a temporary copy was not getting initialized. While on it, fill in with zeros newly-created buffer pages. This does not matter when loading a block from a tempora

pgsql: Fix variable initialization when using buffering build with GiST

2019-07-09 Thread Michael Paquier
Fix variable initialization when using buffering build with GiST This can cause valgrind to complain, as the flag marking a buffer as a temporary copy was not getting initialized. While on it, fill in with zeros newly-created buffer pages. This does not matter when loading a block from a tempora

pgsql: Fix variable initialization when using buffering build with GiST

2019-07-09 Thread Michael Paquier
Fix variable initialization when using buffering build with GiST This can cause valgrind to complain, as the flag marking a buffer as a temporary copy was not getting initialized. While on it, fill in with zeros newly-created buffer pages. This does not matter when loading a block from a tempora

pgsql: Fix variable initialization when using buffering build with GiST

2019-07-09 Thread Michael Paquier
Fix variable initialization when using buffering build with GiST This can cause valgrind to complain, as the flag marking a buffer as a temporary copy was not getting initialized. While on it, fill in with zeros newly-created buffer pages. This does not matter when loading a block from a tempora

pgsql: Fix variable initialization when using buffering build with GiST

2019-07-09 Thread Michael Paquier
Fix variable initialization when using buffering build with GiST This can cause valgrind to complain, as the flag marking a buffer as a temporary copy was not getting initialized. While on it, fill in with zeros newly-created buffer pages. This does not matter when loading a block from a tempora

pgsql: Fix variable initialization when using buffering build with GiST

2019-07-09 Thread Michael Paquier
Fix variable initialization when using buffering build with GiST This can cause valgrind to complain, as the flag marking a buffer as a temporary copy was not getting initialized. While on it, fill in with zeros newly-created buffer pages. This does not matter when loading a block from a tempora

pgsql: Assorted fixes for jsonpath documentation

2019-07-09 Thread Alexander Korotkov
Assorted fixes for jsonpath documentation This commit contains assorted fixes for jsonpath documentation including: grammar fixes, incorrect examples fixes as well as wording improvements. Discussion: https://postgr.es/m/CAA-aLv4VVX%3Db9RK5hkfPXJczqaiTdqO04teW9i0wiQVhdKcqzw%40mail.gmail.com Auth

pgsql: Fix missing calls to table_finish_bulk_insert during COPY, take

2019-07-09 Thread David Rowley
Fix missing calls to table_finish_bulk_insert during COPY, take 2 86b85044e abstracted calls to heap functions in COPY FROM to support a generic table AM. However, when performing a copy into a partitioned table, this commit neglected to call table_finish_bulk_insert for each partition. Before 8

pgsql: Fix missing calls to table_finish_bulk_insert during COPY, take

2019-07-09 Thread David Rowley
Fix missing calls to table_finish_bulk_insert during COPY, take 2 86b85044e abstracted calls to heap functions in COPY FROM to support a generic table AM. However, when performing a copy into a partitioned table, this commit neglected to call table_finish_bulk_insert for each partition. Before 8

pgsql: Fix few typos and minor word smithing in tableam comments.

2019-07-09 Thread Amit Kapila
Fix few typos and minor word smithing in tableam comments. Reported-by: Ashwin Agrawal Author: Ashwin Agrawal Reviewed-by: Amit Kapila Backpatch-through: 12, where it was introduced Discussion: https://postgr.es/m/calfoeisgdzhydrjoukabzvxfjok2fq0szvmk7dzmcy6w93i...@mail.gmail.com Branch -- R

pgsql: Fix few typos and minor wordsmithing in tableam comments.

2019-07-09 Thread Amit Kapila
Fix few typos and minor wordsmithing in tableam comments. Reported-by: Ashwin Agrawal Author: Ashwin Agrawal Reviewed-by: Amit Kapila Backpatch-through: 12, where it was introduced Discussion: https://postgr.es/m/calfoeisgdzhydrjoukabzvxfjok2fq0szvmk7dzmcy6w93i...@mail.gmail.com Branch -- ma

pgsql: Pass QueryEnvironment down to EvalPlanQual's EState.

2019-07-09 Thread Thomas Munro
Pass QueryEnvironment down to EvalPlanQual's EState. Otherwise the executor can't see trigger transition tables during EPQ evaluation. Fixes bug #15900 and almost certainly also #15720. Back-patch to 10, where trigger transition tables landed. Author: Alex Aktsipetrov Reviewed-by: Thomas Munro,

pgsql: Pass QueryEnvironment down to EvalPlanQual's EState.

2019-07-09 Thread Thomas Munro
Pass QueryEnvironment down to EvalPlanQual's EState. Otherwise the executor can't see trigger transition tables during EPQ evaluation. Fixes bug #15900 and almost certainly also #15720. Back-patch to 10, where trigger transition tables landed. Author: Alex Aktsipetrov Reviewed-by: Thomas Munro,

pgsql: Pass QueryEnvironment down to EvalPlanQual's EState.

2019-07-09 Thread Thomas Munro
Pass QueryEnvironment down to EvalPlanQual's EState. Otherwise the executor can't see trigger transition tables during EPQ evaluation. Fixes bug #15900 and almost certainly also #15720. Back-patch to 10, where trigger transition tables landed. Author: Alex Aktsipetrov Reviewed-by: Thomas Munro,

pgsql: Pass QueryEnvironment down to EvalPlanQual's EState.

2019-07-09 Thread Thomas Munro
Pass QueryEnvironment down to EvalPlanQual's EState. Otherwise the executor can't see trigger transition tables during EPQ evaluation. Fixes bug #15900 and almost certainly also #15720. Back-patch to 10, where trigger transition tables landed. Author: Alex Aktsipetrov Reviewed-by: Thomas Munro,

pgsql: Propagate trigger arguments to partitions

2019-07-09 Thread Alvaro Herrera
Propagate trigger arguments to partitions We were creating the cloned triggers with an empty list of arguments, losing the ones that had been specified by the user when creating the trigger in the partitioned table. Repair. This was forgotten in commit 86f575948c77. Author: Patrick McHardy Revi

pgsql: Propagate trigger arguments to partitions

2019-07-09 Thread Alvaro Herrera
Propagate trigger arguments to partitions We were creating the cloned triggers with an empty list of arguments, losing the ones that had been specified by the user when creating the trigger in the partitioned table. Repair. This was forgotten in commit 86f575948c77. Author: Patrick McHardy Revi

pgsql: Propagate trigger arguments to partitions

2019-07-09 Thread Alvaro Herrera
Propagate trigger arguments to partitions We were creating the cloned triggers with an empty list of arguments, losing the ones that had been specified by the user when creating the trigger in the partitioned table. Repair. This was forgotten in commit 86f575948c77. Author: Patrick McHardy Revi

pgsql: Message style improvements

2019-07-09 Thread Peter Eisentraut
Message style improvements Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/48d6d5a2afa59c4cf83cad6719cbbf298ef27c08 Modified Files -- src/bin/initdb/initdb.c| 2 +- src/bin/pg_basebackup/pg_recvlogical.c | 5 ++--- src/bin/pg_checksu

pgsql: Message style improvements

2019-07-09 Thread Peter Eisentraut
Message style improvements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e435c1e7d9d88264453c30f8d1969cb836a60509 Modified Files -- src/bin/initdb/initdb.c| 2 +- src/bin/pg_basebackup/pg_recvlogical.c | 5 ++--- src/bin/pg_checksums/pg_c