pgsql: Refactor logic to remove trailing CR/LF characters from strings

2019-08-08 Thread Michael Paquier
Refactor logic to remove trailing CR/LF characters from strings b654714 has reworked the way trailing CR/LF characters are removed from strings. This commit introduces a new routine in common/string.c and refactors the code so as the logic is in a single place, mostly. Author: Michael Paquier Re

pgsql: Update obsolete tuplesort READTUP() comment.

2019-08-08 Thread Peter Geoghegan
Update obsolete tuplesort READTUP() comment. READTUP() routines do not and cannot use the resettable "tuplecontext" memory context, since it is deleted when merging begins. Update an obsolete comment that claimed otherwise. This was an oversight in commit e94568ecc10. In passing, fix an unrelat

pgsql: Clarify the default partition's role

2019-08-08 Thread Alvaro Herrera
Clarify the default partition's role Reviewed by Tom Lane and Amit Langote Discussion: https://postgr.es/m/20190806222735.GA9535@alvherre.pgsql Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/edc793d374af50df76efb0a7622b78f58f0d8124 Modified Files --

pgsql: Clarify the default partition's role

2019-08-08 Thread Alvaro Herrera
Clarify the default partition's role Reviewed by Tom Lane and Amit Langote Discussion: https://postgr.es/m/20190806222735.GA9535@alvherre.pgsql Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bf6455d4c557ff9ef42985bb4806b251497bdc60 Modified Files --

pgsql: Clarify the default partition's role

2019-08-08 Thread Alvaro Herrera
Clarify the default partition's role Reviewed by Tom Lane and Amit Langote Discussion: https://postgr.es/m/20190806222735.GA9535@alvherre.pgsql Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/956451e8bc9face2241d9a785e0d236a92f8e210 Modified Files -- do

pgsql: Fix certificate subjects in ldap test

2019-08-08 Thread Andrew Dunstan
Fix certificate subjects in ldap test openssl doesn't like lower case subject attribute names. Error observed in buildfarm results. Backpatch to release 11. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4116420baeae614a2711e156f0c4e58adad172ba Modified Fi

pgsql: Fix certificate subjects in ldap test

2019-08-08 Thread Andrew Dunstan
Fix certificate subjects in ldap test openssl doesn't like lower case subject attribute names. Error observed in buildfarm results. Backpatch to release 11. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/15077ab63f29fd85ff519d1c456fda614774d28b Modified Files ---

pgsql: Fix certificate subjects in ldap test

2019-08-08 Thread Andrew Dunstan
Fix certificate subjects in ldap test openssl doesn't like lower case subject attribute names. Error observed in buildfarm results. Backpatch to release 11. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/273e78715a0f92708f6b7b0c99393666e3281f72 Modified Fi

pgsql: Last-minute updates for release notes.

2019-08-08 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2019-10208, CVE-2019-10209 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e3d8c9a5f1014be97150d07b3e5af1d32a45df65 Modified Files -- doc/src/sgml/release-9.5.sgml | 30

pgsql: Last-minute updates for release notes.

2019-08-08 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2019-10208, CVE-2019-10209 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4908df4a609aa1f2b3def968fe5b94a74cfde214 Modified Files -- doc/src/sgml/release-9.4.sgml | 30

pgsql: Last-minute updates for release notes.

2019-08-08 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2019-10208, CVE-2019-10209 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d03c0413343ac5a79bc2f6ee5abc84c873efd863 Modified Files -- doc/src/sgml/release-11.sgml | 56 +

pgsql: Require the schema qualification in pg_temp.type_name(arg).

2019-08-08 Thread Noah Misch
Require the schema qualification in pg_temp.type_name(arg). Commit aa27977fe21a7dfa4da4376ad66ae37cb8f0d0b5 introduced this restriction for pg_temp.function_name(arg); do likewise for types created in temporary schemas. Programs that this breaks should add "pg_temp." schema qualification or switc

pgsql: Require the schema qualification in pg_temp.type_name(arg).

2019-08-08 Thread Noah Misch
Require the schema qualification in pg_temp.type_name(arg). Commit aa27977fe21a7dfa4da4376ad66ae37cb8f0d0b5 introduced this restriction for pg_temp.function_name(arg); do likewise for types created in temporary schemas. Programs that this breaks should add "pg_temp." schema qualification or switc

pgsql: Require the schema qualification in pg_temp.type_name(arg).

2019-08-08 Thread Noah Misch
Require the schema qualification in pg_temp.type_name(arg). Commit aa27977fe21a7dfa4da4376ad66ae37cb8f0d0b5 introduced this restriction for pg_temp.function_name(arg); do likewise for types created in temporary schemas. Programs that this breaks should add "pg_temp." schema qualification or switc

pgsql: Last-minute updates for release notes.

2019-08-08 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2019-10208, CVE-2019-10209 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f61bc0048b6b3a9bac7afd469cb6811d29d29d5d Modified Files -- doc/src/sgml/release-10.sgml | 30 +

pgsql: Last-minute updates for release notes.

2019-08-08 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2019-10208, CVE-2019-10209 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3354bd5e2ba921d8267dbd6cac90b491a4f27cae Modified Files -- doc/src/sgml/release-9.6.sgml | 30

pgsql: Require the schema qualification in pg_temp.type_name(arg).

2019-08-08 Thread Noah Misch
Require the schema qualification in pg_temp.type_name(arg). Commit aa27977fe21a7dfa4da4376ad66ae37cb8f0d0b5 introduced this restriction for pg_temp.function_name(arg); do likewise for types created in temporary schemas. Programs that this breaks should add "pg_temp." schema qualification or switc

pgsql: Fix choice of comparison operators for cross-type hashed subplan

2019-08-08 Thread Tom Lane
Fix choice of comparison operators for cross-type hashed subplans. Commit bf6c614a2 rearranged the lookup of the comparison operators needed in a hashed subplan, and in so doing, broke the cross-type case: it caused the original LHS-vs-RHS operator to be used to compare hash table entries too (whi

pgsql: Fix choice of comparison operators for cross-type hashed subplan

2019-08-08 Thread Tom Lane
Fix choice of comparison operators for cross-type hashed subplans. Commit bf6c614a2 rearranged the lookup of the comparison operators needed in a hashed subplan, and in so doing, broke the cross-type case: it caused the original LHS-vs-RHS operator to be used to compare hash table entries too (whi

pgsql: Require the schema qualification in pg_temp.type_name(arg).

2019-08-08 Thread Noah Misch
Require the schema qualification in pg_temp.type_name(arg). Commit aa27977fe21a7dfa4da4376ad66ae37cb8f0d0b5 introduced this restriction for pg_temp.function_name(arg); do likewise for types created in temporary schemas. Programs that this breaks should add "pg_temp." schema qualification or switc

pgsql: Fix choice of comparison operators for cross-type hashed subplan

2019-08-08 Thread Tom Lane
Fix choice of comparison operators for cross-type hashed subplans. Commit bf6c614a2 rearranged the lookup of the comparison operators needed in a hashed subplan, and in so doing, broke the cross-type case: it caused the original LHS-vs-RHS operator to be used to compare hash table entries too (whi

pgsql: Require the schema qualification in pg_temp.type_name(arg).

2019-08-08 Thread Noah Misch
Require the schema qualification in pg_temp.type_name(arg). Commit aa27977fe21a7dfa4da4376ad66ae37cb8f0d0b5 introduced this restriction for pg_temp.function_name(arg); do likewise for types created in temporary schemas. Programs that this breaks should add "pg_temp." schema qualification or switc

pgsql: Require the schema qualification in pg_temp.type_name(arg).

2019-08-08 Thread Noah Misch
Require the schema qualification in pg_temp.type_name(arg). Commit aa27977fe21a7dfa4da4376ad66ae37cb8f0d0b5 introduced this restriction for pg_temp.function_name(arg); do likewise for types created in temporary schemas. Programs that this breaks should add "pg_temp." schema qualification or switc

pgsql: initdb: Use varargs macro for PG_CMD_PRINTF

2019-08-08 Thread Peter Eisentraut
initdb: Use varargs macro for PG_CMD_PRINTF I left PG_CMD_PUTS around even though it could be handled by PG_CMD_PRINTF since PG_CMD_PUTS is sometimes called with non-literal arguments, and so that would create a potential problem if such a string contained percent signs. Reviewed-by: Tom Lane B