pgsql: Fix typo in commit 82fa3ff8672.

2019-09-19 Thread Amit Kapila
Fix typo in commit 82fa3ff8672. Reported-By: Kuntal Ghosh (off-list) Backpatch-through: 9.4, like 82fa3ff8672 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c53e40a132dca2ea8db73ce705a9019197ec338b Modified Files -- doc/src/sgml/maintenance.sgml | 2 +-

pgsql: Fix typo in commit 82fa3ff8672.

2019-09-19 Thread Amit Kapila
Fix typo in commit 82fa3ff8672. Reported-By: Kuntal Ghosh (off-list) Backpatch-through: 9.4, like 82fa3ff8672 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fea48c57b86584760a1e92bb773e082b7171d231 Modified Files -- doc/src/sgml/maintenance.sgml

pgsql: Fix typo in commit 82fa3ff8672.

2019-09-19 Thread Amit Kapila
Fix typo in commit 82fa3ff8672. Reported-By: Kuntal Ghosh (off-list) Backpatch-through: 9.4, like 82fa3ff8672 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bad51c723e8f342883e047b3845fa177a48111d1 Modified Files -- doc/src/sgml/maintenance.sgml

pgsql: Fix typo in commit 82fa3ff8672.

2019-09-19 Thread Amit Kapila
Fix typo in commit 82fa3ff8672. Reported-By: Kuntal Ghosh (off-list) Backpatch-through: 9.4, like 82fa3ff8672 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2a98eefc1a15dc32e816ced86d1fd768fefb54b0 Modified Files -- doc/src/sgml/maintenance.sgml

pgsql: Fix typo in commit 82fa3ff8672.

2019-09-19 Thread Amit Kapila
Fix typo in commit 82fa3ff8672. Reported-By: Kuntal Ghosh (off-list) Backpatch-through: 9.4, like 82fa3ff8672 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c16eb2d530b7c2987a948c7ed070ad607f58ff43 Modified Files -- doc/src/sgml/maintenance.sgml

pgsql: Fix typo in commit 82fa3ff8672.

2019-09-19 Thread Amit Kapila
Fix typo in commit 82fa3ff8672. Reported-By: Kuntal Ghosh (off-list) Backpatch-through: 9.4, like 82fa3ff8672 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6133c59e17f98420a30197428f881f469c113f32 Modified Files -- doc/src/sgml/maintenance.sgml

pgsql: Fix typo in commit 82fa3ff8672.

2019-09-19 Thread Amit Kapila
Fix typo in commit 82fa3ff8672. Reported-By: Kuntal Ghosh (off-list) Backpatch-through: 9.4, like 82fa3ff8672 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/09f8106b968e10c7855c0a9fd07dd3520d30e4eb Modified Files -- doc/src/sgml/maintenance.sgml

pgsql: Remove unstable KNN SP-GiST test

2019-09-19 Thread Alexander Korotkov
Remove unstable KNN SP-GiST test 6cae9d2c10 introduced test for NULL values in KNN SP-GiST. This test relies on undetermined ordering showing different results on various platforms. This commit removes that test. Will be replaced with better test later. Discussion: https://postgr.es/m/6d51305e

pgsql: Remove unstable KNN SP-GiST test

2019-09-19 Thread Alexander Korotkov
Remove unstable KNN SP-GiST test 6cae9d2c10 introduced test for NULL values in KNN SP-GiST. This test relies on undetermined ordering showing different results on various platforms. This commit removes that test. Will be replaced with better test later. Discussion: https://postgr.es/m/6d51305e

pgsql: Fix freeing old values in index_store_float8_orderby_distances()

2019-09-19 Thread Alexander Korotkov
Fix freeing old values in index_store_float8_orderby_distances() 6cae9d2c10 has added an error in freeing old values in index_store_float8_orderby_distances() function. It looks for old value in scan->xs_orderbynulls[i] after setting a new value there. This commit fixes that. Also it removes sho

pgsql: Fix freeing old values in index_store_float8_orderby_distances()

2019-09-19 Thread Alexander Korotkov
Fix freeing old values in index_store_float8_orderby_distances() 6cae9d2c10 has added an error in freeing old values in index_store_float8_orderby_distances() function. It looks for old value in scan->xs_orderbynulls[i] after setting a new value there. This commit fixes that. Also it removes sho

Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Tom Lane
Alexander Korotkov writes: > Both dromedary and tern, where segfault happened, are 32-bit. Bug > seems related to USE_FLOAT8_BYVAL or something. Yeah, I was just about to write back that there's an independent problem. Look at the logic inside the loop in index_store_float8_orderby_distances:

Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Alexander Korotkov
On Thu, Sep 19, 2019 at 11:43 PM Alexander Korotkov wrote: > On Thu, Sep 19, 2019 at 11:31 PM Alexander Korotkov > wrote: > > > > On Thu, Sep 19, 2019 at 11:13 PM Tom Lane wrote: > >> > >> Erik Rijkers writes: > >> > Oops: > >> > create_index ... ok 634 ms > >> >

Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Alexander Korotkov
On Thu, Sep 19, 2019 at 11:31 PM Alexander Korotkov wrote: > > On Thu, Sep 19, 2019 at 11:13 PM Tom Lane wrote: >> >> Erik Rijkers writes: >> > Oops: >> > create_index ... ok 634 ms >> > create_index_spgist ... FAILED 438 ms >> > create_vi

pgsql: Fix oversight in backpatch of 6cae9d2c10

2019-09-19 Thread Alexander Korotkov
Fix oversight in backpatch of 6cae9d2c10 During backpatch of 6cae9d2c10 Float8GetDatum() was accidentally removed. This commit turns it back. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/6d51305e1159241cabee132f7efc7eff%40xs4all.nl Author: Tom Lane Backpatch-through: from 11 to 9.5

pgsql: Fix oversight in backpatch of 6cae9d2c10

2019-09-19 Thread Alexander Korotkov
Fix oversight in backpatch of 6cae9d2c10 During backpatch of 6cae9d2c10 Float8GetDatum() was accidentally removed. This commit turns it back. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/6d51305e1159241cabee132f7efc7eff%40xs4all.nl Author: Tom Lane Backpatch-through: from 11 to 9.5

pgsql: Fix oversight in backpatch of 6cae9d2c10

2019-09-19 Thread Alexander Korotkov
Fix oversight in backpatch of 6cae9d2c10 During backpatch of 6cae9d2c10 Float8GetDatum() was accidentally removed. This commit turns it back. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/6d51305e1159241cabee132f7efc7eff%40xs4all.nl Author: Tom Lane Backpatch-through: from 11 to 9.5

pgsql: Fix oversight in backpatch of 6cae9d2c10

2019-09-19 Thread Alexander Korotkov
Fix oversight in backpatch of 6cae9d2c10 During backpatch of 6cae9d2c10 Float8GetDatum() was accidentally removed. This commit turns it back. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/6d51305e1159241cabee132f7efc7eff%40xs4all.nl Author: Tom Lane Backpatch-through: from 11 to 9.5

Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Alexander Korotkov
On Thu, Sep 19, 2019 at 11:13 PM Tom Lane wrote: > Erik Rijkers writes: > > Oops: > > create_index ... ok 634 ms > > create_index_spgist ... FAILED 438 ms > > create_view ... ok 329 ms > > I'm betting the issue is

Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Tom Lane
Erik Rijkers writes: > Oops: > create_index ... ok 634 ms > create_index_spgist ... FAILED 438 ms > create_view ... ok 329 ms I'm betting the issue is breaking the Datum abstraction here: - scan-

Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Erik Rijkers
On 2019-09-19 21:11, Alexander Korotkov wrote: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST Oops: create_index ... ok 634 ms create_index_spgist ... FAILED 438 ms create_view ... ok 329 ms

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Alexander Korotkov
Improve handling of NULLs in KNN-GiST and KNN-SP-GiST This commit improves subject in two ways: * It removes ugliness of 02f90879e7, which stores distance values and null flags in two separate arrays after GISTSearchItem struct. Instead we pack both distance value and null flag in IndexOr

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Alexander Korotkov
Improve handling of NULLs in KNN-GiST and KNN-SP-GiST This commit improves subject in two ways: * It removes ugliness of 02f90879e7, which stores distance values and null flags in two separate arrays after GISTSearchItem struct. Instead we pack both distance value and null flag in IndexOr

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Alexander Korotkov
Improve handling of NULLs in KNN-GiST and KNN-SP-GiST This commit improves subject in two ways: * It removes ugliness of 02f90879e7, which stores distance values and null flags in two separate arrays after GISTSearchItem struct. Instead we pack both distance value and null flag in IndexOr

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Alexander Korotkov
Improve handling of NULLs in KNN-GiST and KNN-SP-GiST This commit improves subject in two ways: * It removes ugliness of 02f90879e7, which stores distance values and null flags in two separate arrays after GISTSearchItem struct. Instead we pack both distance value and null flag in IndexOr

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Alexander Korotkov
Improve handling of NULLs in KNN-GiST and KNN-SP-GiST This commit improves subject in two ways: * It removes ugliness of 02f90879e7, which stores distance values and null flags in two separate arrays after GISTSearchItem struct. Instead we pack both distance value and null flag in IndexOr

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Alexander Korotkov
Improve handling of NULLs in KNN-GiST and KNN-SP-GiST This commit improves subject in two ways: * It removes ugliness of 02f90879e7, which stores distance values and null flags in two separate arrays after GISTSearchItem struct. Instead we pack both distance value and null flag in IndexOr

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Alexander Korotkov
Improve handling of NULLs in KNN-GiST and KNN-SP-GiST This commit improves subject in two ways: * It removes ugliness of 02f90879e7, which stores distance values and null flags in two separate arrays after GISTSearchItem struct. Instead we pack both distance value and null flag in IndexOr

pgsql: Doc: improve documentation around jsonpath regular expressions.

2019-09-19 Thread Tom Lane
Doc: improve documentation around jsonpath regular expressions. Provide some documentation about the differences between XQuery regular expressions and those supported by Spencer's regex engine. Since SQL now exposes XQuery regexps with the LIKE_REGEX operator, I made this a standalone section des

pgsql: Doc: improve documentation around jsonpath regular expressions.

2019-09-19 Thread Tom Lane
Doc: improve documentation around jsonpath regular expressions. Provide some documentation about the differences between XQuery regular expressions and those supported by Spencer's regex engine. Since SQL now exposes XQuery regexps with the LIKE_REGEX operator, I made this a standalone section des

pgsql: GSSAPI error message improvements

2019-09-19 Thread Peter Eisentraut
GSSAPI error message improvements Make the error messages around GSSAPI encryption a bit clearer. Tweak some messages to avoid plural problems. Also make a code change for clarity. Using "conf" for "confidential" is quite confusing. Using "conf_state" is perhaps not much better but that's what

pgsql: GSSAPI error message improvements

2019-09-19 Thread Peter Eisentraut
GSSAPI error message improvements Make the error messages around GSSAPI encryption a bit clearer. Tweak some messages to avoid plural problems. Also make a code change for clarity. Using "conf" for "confidential" is quite confusing. Using "conf_state" is perhaps not much better but that's what

pgsql: doc: Improve a release notes item

2019-09-19 Thread Peter Eisentraut
doc: Improve a release notes item Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9c4f20066fb20197dfc20e3cf31aa3c890f3646b Modified Files -- doc/src/sgml/release-12.sgml | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

pgsql: Fix typo in commit 578b229718.

2019-09-19 Thread Amit Kapila
Fix typo in commit 578b229718. Reported-by: Filip Rembiałkowski Author: Filip Rembiałkowski Backpatch-through: 12, where it was introduced Discussion: https://postgr.es/m/CAP_rwwmSNy1=_82rwge3-x4pjwqpsfxtznf43dctgzd7saz...@mail.gmail.com Branch -- master Details --- https://git.postgres

pgsql: Fix typo in commit 578b229718.

2019-09-19 Thread Amit Kapila
Fix typo in commit 578b229718. Reported-by: Filip Rembiałkowski Author: Filip Rembiałkowski Backpatch-through: 12, where it was introduced Discussion: https://postgr.es/m/CAP_rwwmSNy1=_82rwge3-x4pjwqpsfxtznf43dctgzd7saz...@mail.gmail.com Branch -- REL_12_STABLE Details --- https://git.p

pgsql: doc: Some release notes tweaking

2019-09-19 Thread Peter Eisentraut
doc: Some release notes tweaking Improve the LDAP DNS SRV item. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1aaa3ee34466780d6f050b7d4aa5cc69935c08b5 Modified Files -- doc/src/sgml/release-12.sgml | 5 ++--- 1 file changed, 2 insertions(+), 3 d

pgsql: Revert change of ecpglib major version

2019-09-19 Thread Peter Eisentraut
Revert change of ecpglib major version The major version of ecpglib was changed in bd7c95f0c1a38becffceb3ea7234d57167f6d4bf, apparently without justification. Revert this, since nothing has changed in this library except some added functions. Discussion: https://www.postgresql.org/message-id/fl

pgsql: Revert change of ecpglib major version

2019-09-19 Thread Peter Eisentraut
Revert change of ecpglib major version The major version of ecpglib was changed in bd7c95f0c1a38becffceb3ea7234d57167f6d4bf, apparently without justification. Revert this, since nothing has changed in this library except some added functions. Discussion: https://www.postgresql.org/message-id/fl