Re: [COMMITTERS] pgsql: Establish conventions about global object names used in regressi

2019-09-21 Thread Peter Geoghegan
On Sat, Sep 21, 2019 at 11:36 PM Tom Lane wrote: > Hm. So ... how come the buildfarm hasn't been red for the last three > years? We need to figure out what you're doing that's different. I'll try to debug the problem soon. The exact regressions.diffs I get is attached, just in case the exact d

Re: [COMMITTERS] pgsql: Establish conventions about global object names used in regressi

2019-09-21 Thread Tom Lane
Peter Geoghegan writes: > On Sat, Sep 21, 2019 at 11:02 PM Peter Geoghegan wrote: >> It's reliable. Doesn't have to be a Valgrind build, or even a debug build. > I can also confirm that the problem can't have anything to do with the > patch that I happened to be testing -- the master branch is a

Re: [COMMITTERS] pgsql: Establish conventions about global object names used in regressi

2019-09-21 Thread Peter Geoghegan
On Sat, Sep 21, 2019 at 11:02 PM Peter Geoghegan wrote: > It's reliable. Doesn't have to be a Valgrind build, or even a debug build. I can also confirm that the problem can't have anything to do with the patch that I happened to be testing -- the master branch is also affected. -- Peter Geogheg

Re: [COMMITTERS] pgsql: Establish conventions about global object names used in regressi

2019-09-21 Thread Peter Geoghegan
On Sat, Sep 21, 2019 at 10:52 PM Tom Lane wrote: > would work. The naming convention I was putting in didn't allow for > identical DB and user names, and it didn't seem to me that it was > worth overriding that convention to keep this particular test > result the same. The error output still pro

Re: [COMMITTERS] pgsql: Establish conventions about global object names used in regressi

2019-09-21 Thread Tom Lane
Peter Geoghegan writes: > On Sun, Jul 17, 2016 at 3:43 PM Tom Lane wrote: >> Establish conventions about global object names used in regression tests. > I gather that this patch was intended to be cosmetic and mechanical. > Why, then, did it result in a certain amount of seemingly > more-than-co

Re: [COMMITTERS] pgsql: Establish conventions about global object names used in regressi

2019-09-21 Thread Peter Geoghegan
On Sun, Jul 17, 2016 at 3:43 PM Tom Lane wrote: > Establish conventions about global object names used in regression tests. > require some rethinking of exactly what we want to test, whereas the intent > of this patch is just to hit all the cases in which the needed renamings > are cosmetic. I g

pgsql: Remove removed file from nls.mk

2019-09-21 Thread Peter Eisentraut
Remove removed file from nls.mk part of revert "Add DECLARE STATEMENT support to ECPG." Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/72c48c3fc31e3be090b1f70eb6d8222634ba4bde Modified Files -- src/interfaces/ecpg/ecpglib/nls.mk | 2 +- 1 file changed,

pgsql: Remove removed file from nls.mk

2019-09-21 Thread Peter Eisentraut
Remove removed file from nls.mk part of revert "Add DECLARE STATEMENT support to ECPG." Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ee98adede535ed6bd584857d7f5095328a1ce78c Modified Files -- src/interfaces/ecpg/ecpglib/nls.mk | 2 +- 1 file ch

pgsql: Update list of acknowledgments in release notes

2019-09-21 Thread Peter Eisentraut
Update list of acknowledgments in release notes current through 25f9368304e41c8837f59e94b161f07ac4c7d622 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/87b601605467812c48675a0ec127707bf381cda2 Modified Files -- doc/src/sgml/release-12.sgml | 11

pgsql: Straighten out leakproofness markings on text comparison functio

2019-09-21 Thread Tom Lane
Straighten out leakproofness markings on text comparison functions. Since we introduced the idea of leakproof functions, texteq and textne were marked leakproof but their sibling text comparison functions were not. This inconsistency seemed justified because texteq/textne just relied on memcmp()

pgsql: Straighten out leakproofness markings on text comparison functio

2019-09-21 Thread Tom Lane
Straighten out leakproofness markings on text comparison functions. Since we introduced the idea of leakproof functions, texteq and textne were marked leakproof but their sibling text comparison functions were not. This inconsistency seemed justified because texteq/textne just relied on memcmp()

pgsql: Fix up handling of nondeterministic collations with pattern_ops

2019-09-21 Thread Tom Lane
Fix up handling of nondeterministic collations with pattern_ops opclasses. text_pattern_ops and its siblings can't be used with nondeterministic collations, because they use the text_eq operator which will not behave as bitwise equality if applied with a nondeterministic collation. The initial im

pgsql: Fix up handling of nondeterministic collations with pattern_ops

2019-09-21 Thread Tom Lane
Fix up handling of nondeterministic collations with pattern_ops opclasses. text_pattern_ops and its siblings can't be used with nondeterministic collations, because they use the text_eq operator which will not behave as bitwise equality if applied with a nondeterministic collation. The initial im

pgsql: Doc: updates for v12 release notes.

2019-09-21 Thread Tom Lane
Doc: updates for v12 release notes. Remove mention of ECPG's DECLARE STATEMENT, since that was reverted yesterday. Rewrite some other entries per suggestions from Peter Eisentraut. Make a couple of desultory wording and markup adjustments. Discussion: https://postgr.es/m/d4dff575-90ab-9c8c-cc6