pgsql: Suppress warning from older compilers.

2019-11-03 Thread Tom Lane
Suppress warning from older compilers. Commit 8af1624e3 introduced a warning about possibly returning without a value, on compilers that don't realize that ereport(ERROR) doesn't return. Tweak the code to avoid that. Per buildfarm. Back-patch to 9.6, like the aforesaid commit. Branch -- RE

pgsql: Suppress warning from older compilers.

2019-11-03 Thread Tom Lane
Suppress warning from older compilers. Commit 8af1624e3 introduced a warning about possibly returning without a value, on compilers that don't realize that ereport(ERROR) doesn't return. Tweak the code to avoid that. Per buildfarm. Back-patch to 9.6, like the aforesaid commit. Branch -- RE

pgsql: Suppress warning from older compilers.

2019-11-03 Thread Tom Lane
Suppress warning from older compilers. Commit 8af1624e3 introduced a warning about possibly returning without a value, on compilers that don't realize that ereport(ERROR) doesn't return. Tweak the code to avoid that. Per buildfarm. Back-patch to 9.6, like the aforesaid commit. Branch -- RE

pgsql: Suppress warning from older compilers.

2019-11-03 Thread Tom Lane
Suppress warning from older compilers. Commit 8af1624e3 introduced a warning about possibly returning without a value, on compilers that don't realize that ereport(ERROR) doesn't return. Tweak the code to avoid that. Per buildfarm. Back-patch to 9.6, like the aforesaid commit. Branch -- RE

pgsql: Suppress warning from older compilers.

2019-11-03 Thread Tom Lane
Suppress warning from older compilers. Commit 8af1624e3 introduced a warning about possibly returning without a value, on compilers that don't realize that ereport(ERROR) doesn't return. Tweak the code to avoid that. Per buildfarm. Back-patch to 9.6, like the aforesaid commit. Branch -- ma

pgsql: Fix PG_GETARG_SEG_P() definition.

2019-11-03 Thread Tom Lane
Fix PG_GETARG_SEG_P() definition. DatumGetPointer() takes a Datum argument, not a pointer. This is cosmetic given the current definitions of the underlying macros, but it's still formally a type violation. Bug was introduced in commit 389bb2818, but there seems no need to back-patch. Dagfinn Ilm