pgsql: Fix typo in comment.

2019-11-26 Thread Etsuro Fujita
Fix typo in comment. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/47a3c7fa06538c181be815db44b5d7e8efe696ef Modified Files -- src/backend/optimizer/util/relnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2019-11-26 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e429b03cc63b5879b87be6dd96c49c7868febeb1 Modified Files -- src/backend/optimizer/util/relnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2019-11-26 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/304ea5d98ed8c5b4d7ade7524a7d82841d335181 Modified Files -- src/backend/optimizer/util/relnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2019-11-26 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bf3cef24a31966686dfaae3085ce7c545c0019a4 Modified Files -- src/backend/optimizer/util/relnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2019-11-26 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/474cd0931b758f4ee353fbc8cfc38a762b997be1 Modified Files -- src/backend/optimizer/util/relnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2019-11-26 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5f55e4c061d376304f979fef0f9aebae94e286bf Modified Files -- src/backend/optimizer/util/relnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2019-11-26 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c41824c152aba5019cc58b72d6ad5f6761743fab Modified Files -- src/backend/optimizer/util/relnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures

2019-11-26 Thread Michael Paquier
On Tue, Nov 26, 2019 at 09:36:50PM -0500, Andrew Dunstan wrote: > So I'm a bit stuck. Probably the best thing to do for now is revert the > patch and mark the tests that need it in the libpq-sslpassword patch as > TODO (with todo_skip). If somebody whose perl-fu is greater than mine > can

Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures

2019-11-26 Thread Andrew Dunstan
On 11/26/19 5:08 PM, Andrew Dunstan wrote: > On 11/26/19 3:30 PM, Tom Lane wrote: >> Peter Eisentraut writes: >>> On 2019-11-26 05:43, Michael Paquier wrote: This one is causing failures with the TAP tests of initdb on all AIX animals and prairiedog: # Running: initdb --help

Re: pgsql: Use native methods to open input in TestLib::slurp_file on Windo

2019-11-26 Thread Andrew Dunstan
On 11/25/19 11:41 PM, Michael Paquier wrote: > Hi Andrew, > > On Sun, Nov 24, 2019 at 11:53:31PM +, Andrew Dunstan wrote: >> Use native methods to open input in TestLib::slurp_file on Windows. >> >> It is hoped that this will avoid some errors that we have seen before, >> but lately with

Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures

2019-11-26 Thread Andrew Dunstan
On 11/26/19 3:30 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 2019-11-26 05:43, Michael Paquier wrote: >>> This one is causing failures with the TAP tests of initdb on all AIX >>> animals and prairiedog: >>> # Running: initdb --help >>> Can't locate IO/Pty.pm in @INC (@INC contains:

pgsql: Fix closing stdin in TestLib.pm

2019-11-26 Thread Andrew Dunstan
Fix closing stdin in TestLib.pm Commit 9af34f3c6b naively assumed that all non-windows platforms would have pseudoterminals and that perl would have IO::Pty. Such is not the case. Instead of assumung anything, test for the presence of IO::Pty and only use code that might depend on it if it's

Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures

2019-11-26 Thread Tom Lane
Peter Eisentraut writes: > On 2019-11-26 05:43, Michael Paquier wrote: >> This one is causing failures with the TAP tests of initdb on all AIX >> animals and prairiedog: >> # Running: initdb --help >> Can't locate IO/Pty.pm in @INC (@INC contains: ../../../src/test/perl/ >> .

pgsql: Allow access to child table statistics if user can read parent t

2019-11-26 Thread Tom Lane
Allow access to child table statistics if user can read parent table. The fix for CVE-2017-7484 disallowed use of pg_statistic data for planning purposes if the user would not be able to select the associated column and a non-leakproof function is to be applied to the statistics values. That

pgsql: Allow access to child table statistics if user can read parent t

2019-11-26 Thread Tom Lane
Allow access to child table statistics if user can read parent table. The fix for CVE-2017-7484 disallowed use of pg_statistic data for planning purposes if the user would not be able to select the associated column and a non-leakproof function is to be applied to the statistics values. That

pgsql: Allow access to child table statistics if user can read parent t

2019-11-26 Thread Tom Lane
Allow access to child table statistics if user can read parent table. The fix for CVE-2017-7484 disallowed use of pg_statistic data for planning purposes if the user would not be able to select the associated column and a non-leakproof function is to be applied to the statistics values. That

Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures

2019-11-26 Thread Tom Lane
Andrew Dunstan writes: > here's my proposed fix. Looks sane by eyeball (didn't test it). regards, tom lane

Re: pgsql: Use native methods to open input in TestLib::slurp_file on Windo

2019-11-26 Thread Andrew Dunstan
On 11/25/19 11:41 PM, Michael Paquier wrote: > Hi Andrew, > > On Sun, Nov 24, 2019 at 11:53:31PM +, Andrew Dunstan wrote: >> Use native methods to open input in TestLib::slurp_file on Windows. >> >> It is hoped that this will avoid some errors that we have seen before, >> but lately with

Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures

2019-11-26 Thread Andrew Dunstan
On 11/26/19 3:47 AM, Michael Paquier wrote: > On Tue, Nov 26, 2019 at 02:13:50AM -0500, Tom Lane wrote: >> Perhaps the "where possible" caveat needs to include a test whether >> IO::Pty is installed? It's evidently not there by default everywhere. >> >> It's possible that we should just move the

Re: pgsql: Fix unportable printf format introduced in commit 9290ad198.

2019-11-26 Thread Amit Kapila
On Mon, Nov 25, 2019 at 9:18 PM Tom Lane wrote: > > Fix unportable printf format introduced in commit 9290ad198. > Thanks for fixing this. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com

Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures

2019-11-26 Thread Peter Eisentraut
On 2019-11-26 05:43, Michael Paquier wrote: This one is causing failures with the TAP tests of initdb on all AIX animals and prairiedog: # Running: initdb --help Can't locate IO/Pty.pm in @INC (@INC contains: ../../../src/test/perl/ . /usr/local/perl5.8.3/lib/5.8.3/darwin-2level [...] Unexpected

Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures

2019-11-26 Thread Michael Paquier
On Tue, Nov 26, 2019 at 02:13:50AM -0500, Tom Lane wrote: > Perhaps the "where possible" caveat needs to include a test whether > IO::Pty is installed? It's evidently not there by default everywhere. > > It's possible that we should just move the goalposts and say IO::Pty > is required for TAP

pgsql: Use procsignal_sigusr1_handler for auxiliary processes.

2019-11-26 Thread Robert Haas
Use procsignal_sigusr1_handler for auxiliary processes. AuxiliaryProcessMain does ProcSignalInit, so one might expect that auxiliary processes would need to respond to SendProcSignal, but none of the auxiliary processes do that. Change them to use procsignal_sigusr1_handler instead of their own