pgsql: Fix whitespace.

2019-12-03 Thread Etsuro Fujita
Fix whitespace. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4af77aa797d95f9f77d7b88a41b4e02bc62d8975 Modified Files -- src/backend/executor/nodeModifyTable.c | 1 - 1 file changed, 1 deletion(-)

pgsql: Fix whitespace.

2019-12-03 Thread Etsuro Fujita
Fix whitespace. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0e5baa095176cbb77f8ea30054ab4c3a59409da7 Modified Files -- src/backend/executor/nodeModifyTable.c | 1 - 1 file changed, 1 deletion(-)

pgsql: Use carriage returns for data insertion logs in pgbench on termi

2019-12-03 Thread Michael Paquier
Use carriage returns for data insertion logs in pgbench on terminal This is similar to what pg_basebackup and pg_rewind do when reporting cumulative data, and that's more user-friendly. Carriage returns are now used when stderr points to a terminal, and newlines are used in other cases, like a re

pgsql: Remove unnecessary definition of CancelRequested in bin/scripts/

2019-12-03 Thread Michael Paquier
Remove unnecessary definition of CancelRequested in bin/scripts/ This variable is now part of the refactored code for query cancellation in fe_utils. This fixes an oversight in commit a4fd3aa. While on it, improve some header includes in bin/scripts/. Author: Michael Paquier Reviewed-by: Fabien

pgsql: Ensure maxlen is at leat 1 in dict_int

2019-12-03 Thread Tomas Vondra
Ensure maxlen is at leat 1 in dict_int The dict_int text search dictionary template accepts maxlen parameter, which is then used to cap the length of input strings. The value was not properly checked, and the code simply does txt[d->maxlen] = '\0'; to insert a terminator, leading to segfault

pgsql: Ensure maxlen is at leat 1 in dict_int

2019-12-03 Thread Tomas Vondra
Ensure maxlen is at leat 1 in dict_int The dict_int text search dictionary template accepts maxlen parameter, which is then used to cap the length of input strings. The value was not properly checked, and the code simply does txt[d->maxlen] = '\0'; to insert a terminator, leading to segfault

pgsql: Ensure maxlen is at leat 1 in dict_int

2019-12-03 Thread Tomas Vondra
Ensure maxlen is at leat 1 in dict_int The dict_int text search dictionary template accepts maxlen parameter, which is then used to cap the length of input strings. The value was not properly checked, and the code simply does txt[d->maxlen] = '\0'; to insert a terminator, leading to segfault

pgsql: Ensure maxlen is at leat 1 in dict_int

2019-12-03 Thread Tomas Vondra
Ensure maxlen is at leat 1 in dict_int The dict_int text search dictionary template accepts maxlen parameter, which is then used to cap the length of input strings. The value was not properly checked, and the code simply does txt[d->maxlen] = '\0'; to insert a terminator, leading to segfault

pgsql: Ensure maxlen is at leat 1 in dict_int

2019-12-03 Thread Tomas Vondra
Ensure maxlen is at leat 1 in dict_int The dict_int text search dictionary template accepts maxlen parameter, which is then used to cap the length of input strings. The value was not properly checked, and the code simply does txt[d->maxlen] = '\0'; to insert a terminator, leading to segfault

pgsql: Ensure maxlen is at leat 1 in dict_int

2019-12-03 Thread Tomas Vondra
Ensure maxlen is at leat 1 in dict_int The dict_int text search dictionary template accepts maxlen parameter, which is then used to cap the length of input strings. The value was not properly checked, and the code simply does txt[d->maxlen] = '\0'; to insert a terminator, leading to segfault

pgsql: Ensure maxlen is at leat 1 in dict_int

2019-12-03 Thread Tomas Vondra
Ensure maxlen is at leat 1 in dict_int The dict_int text search dictionary template accepts maxlen parameter, which is then used to cap the length of input strings. The value was not properly checked, and the code simply does txt[d->maxlen] = '\0'; to insert a terminator, leading to segfault

pgsql: Further sync postgres_fdw's "Relations" output with the rest of

2019-12-03 Thread Tom Lane
Further sync postgres_fdw's "Relations" output with the rest of EXPLAIN. EXPLAIN generally only adds schema qualifications to table names when VERBOSE is specified. In postgres_fdw's "Relations" output, table names were always so qualified, but that was an implementation restriction: in the origi

pgsql: Fix thinkos from commit 9989d37

2019-12-03 Thread Michael Paquier
Fix thinkos from commit 9989d37 Error messages referring to incorrect WAL segment names could have been generated for a fsync() failure or when creating a new segment at the end of recovery. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/68ab982906187fba3530a01b01e

Re: pgsql: Add a regression test for allow_system_table_mods

2019-12-03 Thread Peter Eisentraut
On 2019-12-03 05:12, Michael Paquier wrote: On Mon, Dec 02, 2019 at 10:11:40AM -0500, Tom Lane wrote: One way would be to provide a variant expected-file, but that's not going to be fun for future maintenance of the test script. Another simple answer is to crank up client_min_messages for this

pgsql: Fix alter_system_table test

2019-12-03 Thread Peter Eisentraut
Fix alter_system_table test Add workaround for disabling ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS warning for the test that tries to create a tablespace with a reserved name. Discussion: https://www.postgresql.org/message-id/flat/E1iacW7-0003h6-6U%40gemulon.postgresql.org Branch -- master