pgsql: Fix edge case leading to agg transitions skipping ExecAggTransRe

2020-01-20 Thread Andres Freund
Fix edge case leading to agg transitions skipping ExecAggTransReparent() calls. The code checking whether an aggregate transition value needs to be reparented into the current context has always only compared the transition return value with the previous transition value by datum, i.e. without reg

pgsql: Fix edge case leading to agg transitions skipping ExecAggTransRe

2020-01-20 Thread Andres Freund
Fix edge case leading to agg transitions skipping ExecAggTransReparent() calls. The code checking whether an aggregate transition value needs to be reparented into the current context has always only compared the transition return value with the previous transition value by datum, i.e. without reg

pgsql: Fix edge case leading to agg transitions skipping ExecAggTransRe

2020-01-20 Thread Andres Freund
Fix edge case leading to agg transitions skipping ExecAggTransReparent() calls. The code checking whether an aggregate transition value needs to be reparented into the current context has always only compared the transition return value with the previous transition value by datum, i.e. without reg

pgsql: Fix edge case leading to agg transitions skipping ExecAggTransRe

2020-01-20 Thread Andres Freund
Fix edge case leading to agg transitions skipping ExecAggTransReparent() calls. The code checking whether an aggregate transition value needs to be reparented into the current context has always only compared the transition return value with the previous transition value by datum, i.e. without reg

pgsql: Fix edge case leading to agg transitions skipping ExecAggTransRe

2020-01-20 Thread Andres Freund
Fix edge case leading to agg transitions skipping ExecAggTransReparent() calls. The code checking whether an aggregate transition value needs to be reparented into the current context has always only compared the transition return value with the previous transition value by datum, i.e. without reg

pgsql: Fix edge case leading to agg transitions skipping ExecAggTransRe

2020-01-20 Thread Andres Freund
Fix edge case leading to agg transitions skipping ExecAggTransReparent() calls. The code checking whether an aggregate transition value needs to be reparented into the current context has always only compared the transition return value with the previous transition value by datum, i.e. without reg

pgsql: Fix edge case leading to agg transitions skipping ExecAggTransRe

2020-01-20 Thread Andres Freund
Fix edge case leading to agg transitions skipping ExecAggTransReparent() calls. The code checking whether an aggregate transition value needs to be reparented into the current context has always only compared the transition return value with the previous transition value by datum, i.e. without reg

pgsql: Add GUC variables for stat tracking and timeout as PGDLLIMPORT

2020-01-20 Thread Michael Paquier
Add GUC variables for stat tracking and timeout as PGDLLIMPORT This helps integration of extensions with Windows. The following parameters are changed: - idle_in_transaction_session_timeout (9.6 and newer versions) - lock_timeout - statement_timeout - track_activities - track_counts - track_funct

pgsql: Add GUC variables for stat tracking and timeout as PGDLLIMPORT

2020-01-20 Thread Michael Paquier
Add GUC variables for stat tracking and timeout as PGDLLIMPORT This helps integration of extensions with Windows. The following parameters are changed: - idle_in_transaction_session_timeout (9.6 and newer versions) - lock_timeout - statement_timeout - track_activities - track_counts - track_funct

pgsql: Add GUC variables for stat tracking and timeout as PGDLLIMPORT

2020-01-20 Thread Michael Paquier
Add GUC variables for stat tracking and timeout as PGDLLIMPORT This helps integration of extensions with Windows. The following parameters are changed: - idle_in_transaction_session_timeout (9.6 and newer versions) - lock_timeout - statement_timeout - track_activities - track_counts - track_funct

pgsql: Add GUC variables for stat tracking and timeout as PGDLLIMPORT

2020-01-20 Thread Michael Paquier
Add GUC variables for stat tracking and timeout as PGDLLIMPORT This helps integration of extensions with Windows. The following parameters are changed: - idle_in_transaction_session_timeout (9.6 and newer versions) - lock_timeout - statement_timeout - track_activities - track_counts - track_funct

pgsql: Add GUC variables for stat tracking and timeout as PGDLLIMPORT

2020-01-20 Thread Michael Paquier
Add GUC variables for stat tracking and timeout as PGDLLIMPORT This helps integration of extensions with Windows. The following parameters are changed: - idle_in_transaction_session_timeout (9.6 and newer versions) - lock_timeout - statement_timeout - track_activities - track_counts - track_funct

pgsql: Add GUC variables for stat tracking and timeout as PGDLLIMPORT

2020-01-20 Thread Michael Paquier
Add GUC variables for stat tracking and timeout as PGDLLIMPORT This helps integration of extensions with Windows. The following parameters are changed: - idle_in_transaction_session_timeout (9.6 and newer versions) - lock_timeout - statement_timeout - track_activities - track_counts - track_funct

pgsql: Add GUC variables for stat tracking and timeout as PGDLLIMPORT

2020-01-20 Thread Michael Paquier
Add GUC variables for stat tracking and timeout as PGDLLIMPORT This helps integration of extensions with Windows. The following parameters are changed: - idle_in_transaction_session_timeout (9.6 and newer versions) - lock_timeout - statement_timeout - track_activities - track_counts - track_funct

pgsql: Further tweaking of jsonb_set_lax().

2020-01-20 Thread Tom Lane
Further tweaking of jsonb_set_lax(). Some buildfarm members were still warning about this, because in 9c679a08f I'd missed decorating one of the ereport() code paths with a dummy return. Also, adjust the error messages to be more in line with project style guide. Branch -- master Details --

pgsql: Fix pg_dump's sigTermHandler() to use _exit() not exit().

2020-01-20 Thread Tom Lane
Fix pg_dump's sigTermHandler() to use _exit() not exit(). sigTermHandler() tried to be careful to invoke only operations that are safe to do in a signal handler. But for some reason we forgot that exit(3) is not among those, because it calls atexit handlers that might do various random things. (

pgsql: Fix pg_dump's sigTermHandler() to use _exit() not exit().

2020-01-20 Thread Tom Lane
Fix pg_dump's sigTermHandler() to use _exit() not exit(). sigTermHandler() tried to be careful to invoke only operations that are safe to do in a signal handler. But for some reason we forgot that exit(3) is not among those, because it calls atexit handlers that might do various random things. (

pgsql: Fix pg_dump's sigTermHandler() to use _exit() not exit().

2020-01-20 Thread Tom Lane
Fix pg_dump's sigTermHandler() to use _exit() not exit(). sigTermHandler() tried to be careful to invoke only operations that are safe to do in a signal handler. But for some reason we forgot that exit(3) is not among those, because it calls atexit handlers that might do various random things. (

pgsql: Fix pg_dump's sigTermHandler() to use _exit() not exit().

2020-01-20 Thread Tom Lane
Fix pg_dump's sigTermHandler() to use _exit() not exit(). sigTermHandler() tried to be careful to invoke only operations that are safe to do in a signal handler. But for some reason we forgot that exit(3) is not among those, because it calls atexit handlers that might do various random things. (

pgsql: Fix pg_dump's sigTermHandler() to use _exit() not exit().

2020-01-20 Thread Tom Lane
Fix pg_dump's sigTermHandler() to use _exit() not exit(). sigTermHandler() tried to be careful to invoke only operations that are safe to do in a signal handler. But for some reason we forgot that exit(3) is not among those, because it calls atexit handlers that might do various random things. (

pgsql: Fix pg_dump's sigTermHandler() to use _exit() not exit().

2020-01-20 Thread Tom Lane
Fix pg_dump's sigTermHandler() to use _exit() not exit(). sigTermHandler() tried to be careful to invoke only operations that are safe to do in a signal handler. But for some reason we forgot that exit(3) is not among those, because it calls atexit handlers that might do various random things. (

pgsql: Fix pg_dump's sigTermHandler() to use _exit() not exit().

2020-01-20 Thread Tom Lane
Fix pg_dump's sigTermHandler() to use _exit() not exit(). sigTermHandler() tried to be careful to invoke only operations that are safe to do in a signal handler. But for some reason we forgot that exit(3) is not among those, because it calls atexit handlers that might do various random things. (

pgsql: Fix crash in BRIN inclusion op functions, due to missing datum c

2020-01-20 Thread Heikki Linnakangas
Fix crash in BRIN inclusion op functions, due to missing datum copy. The BRIN add_value() and union() functions need to make a longer-lived copy of the argument, if they want to store it in the BrinValues struct also passed as argument. The functions for the "inclusion operator classes" used with

pgsql: Fix crash in BRIN inclusion op functions, due to missing datum c

2020-01-20 Thread Heikki Linnakangas
Fix crash in BRIN inclusion op functions, due to missing datum copy. The BRIN add_value() and union() functions need to make a longer-lived copy of the argument, if they want to store it in the BrinValues struct also passed as argument. The functions for the "inclusion operator classes" used with

pgsql: Fix crash in BRIN inclusion op functions, due to missing datum c

2020-01-20 Thread Heikki Linnakangas
Fix crash in BRIN inclusion op functions, due to missing datum copy. The BRIN add_value() and union() functions need to make a longer-lived copy of the argument, if they want to store it in the BrinValues struct also passed as argument. The functions for the "inclusion operator classes" used with

pgsql: Fix crash in BRIN inclusion op functions, due to missing datum c

2020-01-20 Thread Heikki Linnakangas
Fix crash in BRIN inclusion op functions, due to missing datum copy. The BRIN add_value() and union() functions need to make a longer-lived copy of the argument, if they want to store it in the BrinValues struct also passed as argument. The functions for the "inclusion operator classes" used with

pgsql: Fix crash in BRIN inclusion op functions, due to missing datum c

2020-01-20 Thread Heikki Linnakangas
Fix crash in BRIN inclusion op functions, due to missing datum copy. The BRIN add_value() and union() functions need to make a longer-lived copy of the argument, if they want to store it in the BrinValues struct also passed as argument. The functions for the "inclusion operator classes" used with

pgsql: Fix crash in BRIN inclusion op functions, due to missing datum c

2020-01-20 Thread Heikki Linnakangas
Fix crash in BRIN inclusion op functions, due to missing datum copy. The BRIN add_value() and union() functions need to make a longer-lived copy of the argument, if they want to store it in the BrinValues struct also passed as argument. The functions for the "inclusion operator classes" used with