Re: pgsql: Prevent running pg_basebackup as root

2020-02-05 Thread Michael Paquier
On Wed, Feb 05, 2020 at 12:22:59PM -0500, Stephen Frost wrote: > In any case, sorry for not responding on this sooner (was traveling for > FOSDEM and such), but I'm not really convinced this is something we want > and it certainly breaks at least somewhat reasonable use-cases when you > think about

pgsql: Fix bug in LWLock statistics mechanism.

2020-02-05 Thread Fujii Masao
Fix bug in LWLock statistics mechanism. Previously PostgreSQL built with -DLWLOCK_STATS could report more than one LWLock statistics entries for the same backend process and the same LWLock. This is strange and only one statistics should be output in that case, instead. The cause of this issue is

pgsql: Fix bug in LWLock statistics mechanism.

2020-02-05 Thread Fujii Masao
Fix bug in LWLock statistics mechanism. Previously PostgreSQL built with -DLWLOCK_STATS could report more than one LWLock statistics entries for the same backend process and the same LWLock. This is strange and only one statistics should be output in that case, instead. The cause of this issue is

pgsql: Fix bug in LWLock statistics mechanism.

2020-02-05 Thread Fujii Masao
Fix bug in LWLock statistics mechanism. Previously PostgreSQL built with -DLWLOCK_STATS could report more than one LWLock statistics entries for the same backend process and the same LWLock. This is strange and only one statistics should be output in that case, instead. The cause of this issue is

pgsql: Fix bug in LWLock statistics mechanism.

2020-02-05 Thread Fujii Masao
Fix bug in LWLock statistics mechanism. Previously PostgreSQL built with -DLWLOCK_STATS could report more than one LWLock statistics entries for the same backend process and the same LWLock. This is strange and only one statistics should be output in that case, instead. The cause of this issue is

pgsql: Add leader_pid to pg_stat_activity

2020-02-05 Thread Michael Paquier
Add leader_pid to pg_stat_activity This new field tracks the PID of the group leader used with parallel query. For parallel workers and the leader, the value is set to the PID of the group leader. So, for the group leader, the value is the same as its own PID. Note that this reflects what PGPRO

pgsql: Force tuple conversion when the source has missing attributes.

2020-02-05 Thread Andrew Gierth
Force tuple conversion when the source has missing attributes. Tuple conversion incorrectly concluded that no conversion was needed as long as all the attributes lined up. But if the source tuple has a missing attribute (from addition of a column with default), then the destination tupdesc might n

pgsql: Force tuple conversion when the source has missing attributes.

2020-02-05 Thread Andrew Gierth
Force tuple conversion when the source has missing attributes. Tuple conversion incorrectly concluded that no conversion was needed as long as all the attributes lined up. But if the source tuple has a missing attribute (from addition of a column with default), then the destination tupdesc might n

pgsql: Force tuple conversion when the source has missing attributes.

2020-02-05 Thread Andrew Gierth
Force tuple conversion when the source has missing attributes. Tuple conversion incorrectly concluded that no conversion was needed as long as all the attributes lined up. But if the source tuple has a missing attribute (from addition of a column with default), then the destination tupdesc might n

pgsql: Make vacuum buffer counters 64 bits wide

2020-02-05 Thread Alvaro Herrera
Make vacuum buffer counters 64 bits wide Using 32 bit counters means they can now realistically wrap around when vacuuming extremely large tables. Because they're signed integers, stats printed by vacuum look very odd when they do. We'd love to backpatch this, but refrain because the variables a

pgsql: ALTER SUBSCRIPTION / REFRESH docs: explain copy_data

2020-02-05 Thread Alvaro Herrera
ALTER SUBSCRIPTION / REFRESH docs: explain copy_data The docs are ambiguous as to which tables would be copied over when the copy_data parameter is true in ALTER SUBSCRIPTION ... REFRESH PUBLICATION. Make it clear that it only applies to tables which are new in the publication. Author: David Chri

pgsql: ALTER SUBSCRIPTION / REFRESH docs: explain copy_data

2020-02-05 Thread Alvaro Herrera
ALTER SUBSCRIPTION / REFRESH docs: explain copy_data The docs are ambiguous as to which tables would be copied over when the copy_data parameter is true in ALTER SUBSCRIPTION ... REFRESH PUBLICATION. Make it clear that it only applies to tables which are new in the publication. Author: David Chri

pgsql: ALTER SUBSCRIPTION / REFRESH docs: explain copy_data

2020-02-05 Thread Alvaro Herrera
ALTER SUBSCRIPTION / REFRESH docs: explain copy_data The docs are ambiguous as to which tables would be copied over when the copy_data parameter is true in ALTER SUBSCRIPTION ... REFRESH PUBLICATION. Make it clear that it only applies to tables which are new in the publication. Author: David Chri

pgsql: ALTER SUBSCRIPTION / REFRESH docs: explain copy_data

2020-02-05 Thread Alvaro Herrera
ALTER SUBSCRIPTION / REFRESH docs: explain copy_data The docs are ambiguous as to which tables would be copied over when the copy_data parameter is true in ALTER SUBSCRIPTION ... REFRESH PUBLICATION. Make it clear that it only applies to tables which are new in the publication. Author: David Chri

Re: pgsql: Prevent running pg_basebackup as root

2020-02-05 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > Prevent running pg_basebackup as root > > Similarly to pg_upgrade, pg_ctl and initdb, a root user is able to use > --version and --help, but cannot execute the actual operation to avoid > the creation of files with permissions incompatib

pgsql: When a TAP file has non-zero exit status, retain temporary direc

2020-02-05 Thread Noah Misch
When a TAP file has non-zero exit status, retain temporary directories. PostgresNode already retained base directories in such cases. Stop using $SIG{__DIE__}, which is redundant with the exit status check, in lieu of proliferating it to TestLib. Back-patch to 9.6, where commit 88802e068017bee8c

pgsql: When a TAP file has non-zero exit status, retain temporary direc

2020-02-05 Thread Noah Misch
When a TAP file has non-zero exit status, retain temporary directories. PostgresNode already retained base directories in such cases. Stop using $SIG{__DIE__}, which is redundant with the exit status check, in lieu of proliferating it to TestLib. Back-patch to 9.6, where commit 88802e068017bee8c

pgsql: When a TAP file has non-zero exit status, retain temporary direc

2020-02-05 Thread Noah Misch
When a TAP file has non-zero exit status, retain temporary directories. PostgresNode already retained base directories in such cases. Stop using $SIG{__DIE__}, which is redundant with the exit status check, in lieu of proliferating it to TestLib. Back-patch to 9.6, where commit 88802e068017bee8c

pgsql: When a TAP file has non-zero exit status, retain temporary direc

2020-02-05 Thread Noah Misch
When a TAP file has non-zero exit status, retain temporary directories. PostgresNode already retained base directories in such cases. Stop using $SIG{__DIE__}, which is redundant with the exit status check, in lieu of proliferating it to TestLib. Back-patch to 9.6, where commit 88802e068017bee8c

pgsql: When a TAP file has non-zero exit status, retain temporary direc

2020-02-05 Thread Noah Misch
When a TAP file has non-zero exit status, retain temporary directories. PostgresNode already retained base directories in such cases. Stop using $SIG{__DIE__}, which is redundant with the exit status check, in lieu of proliferating it to TestLib. Back-patch to 9.6, where commit 88802e068017bee8c