pgsql: Clean up some code, comments and docs referring to Windows 2000

2020-02-18 Thread Michael Paquier
Clean up some code, comments and docs referring to Windows 2000 and older This fixes and updates a couple of comments related to outdated Windows versions. Particularly, src/common/exec.c had a fallback implementation to read a file's line from a pipe because stdin/stdout/stderr does not exist in

pgsql: Stop demanding that top xact must be seen before subxact in deco

2020-02-18 Thread Amit Kapila
Stop demanding that top xact must be seen before subxact in decoding. Manifested as ERROR: subtransaction logged without previous top-level txn record this check forbids legit behaviours like - First xl_xact_assignment record is beyond reading, i.e. earlier restart_lsn. - After restart_lsn

pgsql: Stop demanding that top xact must be seen before subxact in deco

2020-02-18 Thread Amit Kapila
Stop demanding that top xact must be seen before subxact in decoding. Manifested as ERROR: subtransaction logged without previous top-level txn record this check forbids legit behaviours like - First xl_xact_assignment record is beyond reading, i.e. earlier restart_lsn. - After restart_lsn

pgsql: Stop demanding that top xact must be seen before subxact in deco

2020-02-18 Thread Amit Kapila
Stop demanding that top xact must be seen before subxact in decoding. Manifested as ERROR: subtransaction logged without previous top-level txn record this check forbids legit behaviours like - First xl_xact_assignment record is beyond reading, i.e. earlier restart_lsn. - After restart_lsn

pgsql: Stop demanding that top xact must be seen before subxact in deco

2020-02-18 Thread Amit Kapila
Stop demanding that top xact must be seen before subxact in decoding. Manifested as ERROR: subtransaction logged without previous top-level txn record this check forbids legit behaviours like - First xl_xact_assignment record is beyond reading, i.e. earlier restart_lsn. - After restart_lsn

pgsql: Stop demanding that top xact must be seen before subxact in deco

2020-02-18 Thread Amit Kapila
Stop demanding that top xact must be seen before subxact in decoding. Manifested as ERROR: subtransaction logged without previous top-level txn record this check forbids legit behaviours like - First xl_xact_assignment record is beyond reading, i.e. earlier restart_lsn. - After restart_lsn

pgsql: Stop demanding that top xact must be seen before subxact in deco

2020-02-18 Thread Amit Kapila
Stop demanding that top xact must be seen before subxact in decoding. Manifested as ERROR: subtransaction logged without previous top-level txn record this check forbids legit behaviours like - First xl_xact_assignment record is beyond reading, i.e. earlier restart_lsn. - After restart_lsn

pgsql: Remove obsolete _bt_compare() comment.

2020-02-18 Thread Peter Geoghegan
Remove obsolete _bt_compare() comment. btbuild() has nothing to say about how NULL values compare in nbtree. Besides, there are _bt_compare() header comments that describe how NULL values are handled. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fe9b92854e7d5f66d

Re: pgsql: Logical Tape Set: lazily allocate read buffer.

2020-02-18 Thread Jeff Davis
On Sun, 2020-02-16 at 10:51 -0500, Tom Lane wrote: > Is there a reason for that to be coded in such an obscure and fragile > fashion, rather than having the test be say "if (lt->buffer == > NULL)"? I did that to match the original behavior, which is to only allocate the read buffer if the tape is