Re: pgsql: Add deduplication to nbtree.

2020-02-28 Thread Peter Geoghegan
On Thu, Feb 27, 2020 at 9:26 AM Peter Geoghegan wrote: > > Are no changes to the "pageinspect" contrib required? > > There are. Those will be pushed either today or tomorrow. Attached is a draft patch for this, with updated documentation. I'd like to push this tomorrow (Saturday), but if you coul

pgsql: Avoid failure if autovacuum tries to access a just-dropped temp

2020-02-28 Thread Tom Lane
Avoid failure if autovacuum tries to access a just-dropped temp namespace. Such an access became possible when commit 246a6c8f7 added more aggressive cleanup of orphaned temp relations by autovacuum. Since autovacuum's snapshot might be slightly stale, it could attempt to access an already-dropped

pgsql: Avoid failure if autovacuum tries to access a just-dropped temp

2020-02-28 Thread Tom Lane
Avoid failure if autovacuum tries to access a just-dropped temp namespace. Such an access became possible when commit 246a6c8f7 added more aggressive cleanup of orphaned temp relations by autovacuum. Since autovacuum's snapshot might be slightly stale, it could attempt to access an already-dropped

pgsql: Avoid failure if autovacuum tries to access a just-dropped temp

2020-02-28 Thread Tom Lane
Avoid failure if autovacuum tries to access a just-dropped temp namespace. Such an access became possible when commit 246a6c8f7 added more aggressive cleanup of orphaned temp relations by autovacuum. Since autovacuum's snapshot might be slightly stale, it could attempt to access an already-dropped

Re: pgsql: Revert "initdb: Change authentication defaults"

2020-02-28 Thread Tom Lane
Magnus Hagander writes: > On Mon, Jul 22, 2019 at 10:29 AM Peter Eisentraut > wrote: >> Revert "initdb: Change authentication defaults" >> This reverts commit 09f08930f0f6fd4a7350ac02f29124b919727198. >> The buildfarm client needs some adjustments first. > What ended up happening with this? Did

Re: pgsql: Revert "initdb: Change authentication defaults"

2020-02-28 Thread Magnus Hagander
On Mon, Jul 22, 2019 at 10:29 AM Peter Eisentraut wrote: > > Revert "initdb: Change authentication defaults" > > This reverts commit 09f08930f0f6fd4a7350ac02f29124b919727198. > > The buildfarm client needs some adjustments first. What ended up happening with this? Did we end up somewhere deciding

pgsql: Fix commit c11cb17d.

2020-02-28 Thread Jeff Davis
Fix commit c11cb17d. I neglected to update copyfuncs/outfuncs/readfuncs. Discussion: https://postgr.es/m/12491.1582833409%40sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/32bb4535a0be892f4a2794a26ba429032f4ae51e Modified Files -- src/bac

pgsql: Doc: correct thinko in pg_buffercache documentation.

2020-02-28 Thread Tom Lane
Doc: correct thinko in pg_buffercache documentation. Access to this module is granted to the pg_monitor role, not pg_read_all_stats. (Given the view's performance impact, it seems wise to be restrictive, so I think this was the correct decision --- and anyway it was clearly intentional.) Per bug

pgsql: Doc: correct thinko in pg_buffercache documentation.

2020-02-28 Thread Tom Lane
Doc: correct thinko in pg_buffercache documentation. Access to this module is granted to the pg_monitor role, not pg_read_all_stats. (Given the view's performance impact, it seems wise to be restrictive, so I think this was the correct decision --- and anyway it was clearly intentional.) Per bug

pgsql: Doc: correct thinko in pg_buffercache documentation.

2020-02-28 Thread Tom Lane
Doc: correct thinko in pg_buffercache documentation. Access to this module is granted to the pg_monitor role, not pg_read_all_stats. (Given the view's performance impact, it seems wise to be restrictive, so I think this was the correct decision --- and anyway it was clearly intentional.) Per bug

pgsql: Doc: correct thinko in pg_buffercache documentation.

2020-02-28 Thread Tom Lane
Doc: correct thinko in pg_buffercache documentation. Access to this module is granted to the pg_monitor role, not pg_read_all_stats. (Given the view's performance impact, it seems wise to be restrictive, so I think this was the correct decision --- and anyway it was clearly intentional.) Per bug

pgsql: Add comments on avoid reuse of parse-time snapshot

2020-02-28 Thread Alvaro Herrera
Add comments on avoid reuse of parse-time snapshot Apparently, reusing the parse-time query snapshot for later steps (execution) is a frequently considered optimization ... but it doesn't work, for reasons discovered in thread [1]. Adding some comments about why it doesn't really work can relieve

pgsql: Add PostgreSQL home page to --help output

2020-02-28 Thread Peter Eisentraut
Add PostgreSQL home page to --help output Per emerging standard in GNU programs and elsewhere. Autoconf already has support for specifying a home page, so we can just that. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8d389c5f-7fb5-8e48-9a4a-68cec44786f

pgsql: Refer to bug report address by symbol rather than hardcoding

2020-02-28 Thread Peter Eisentraut
Refer to bug report address by symbol rather than hardcoding Use the PACKAGE_BUGREPORT macro that is created by Autoconf for referring to the bug reporting address rather than hardcoding it everywhere. This makes it easier to change the address and it reduces translation work. Reviewed-by: Danie