pgsql: Rename connection parameters to control min/max SSL protocol ver

2020-04-29 Thread Michael Paquier
Rename connection parameters to control min/max SSL protocol version in libpq The libpq parameters ssl{max|min}protocolversion are renamed to use underscores, to become ssl_{max|min}_protocol_version. The related environment variables still use the names introduced in commit ff8ca5f that added

pgsql: Doc: re-re-revise markup for tables of functions.

2020-04-29 Thread Tom Lane
Doc: re-re-revise markup for tables of functions. Make the markup a bit less ad-hoc. A function-table cell now contains several units, and we label the ones that contain function signatures with role="func_signature". The CSS or FO stylesheets then key off of that to decide how to set the

pgsql: Remove redundant _bt_killitems() buffer check.

2020-04-29 Thread Peter Geoghegan
Remove redundant _bt_killitems() buffer check. _bt_getbuf() cannot return an invalid buffer. Oversight in commit 2ed5b87f96d. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ab2343d4cb806c43e8a7269d38b3bdddea185213 Modified Files --

pgsql: Fix check for conflicting SSL min/max protocol settings

2020-04-29 Thread Michael Paquier
Fix check for conflicting SSL min/max protocol settings Commit 79dfa8a has introduced a check to catch when the minimum protocol version was set higher than the maximum version, however an error was getting generated when both bounds are set even if they are able to work, causing a backend to not

pgsql: Fix checkpoint signalling

2020-04-29 Thread Alvaro Herrera
Fix checkpoint signalling Checkpointer uses its MyLatch to wake up when a checkpoint request is received. But before commit c6550776394e the latch was not used for anything else, so the code could just go to sleep after each loop without rechecking the sleeping condition. That commit added a

Re: pgsql: Remove some code for old unsupported versions of MSVC

2020-04-29 Thread Amit Kapila
On Wed, Apr 29, 2020 at 3:19 PM Peter Eisentraut wrote: > > On 2020-04-29 09:05, Amit Kapila wrote: > > On Tue, Oct 8, 2019 at 2:23 PM Peter Eisentraut > > wrote: > >> > >> Remove some code for old unsupported versions of MSVC > >> > >> As of d9dd406fe281d22d5238d3c26a7182543c711e74, we require

Re: pgsql: Remove some code for old unsupported versions of MSVC

2020-04-29 Thread Peter Eisentraut
On 2020-04-29 09:05, Amit Kapila wrote: On Tue, Oct 8, 2019 at 2:23 PM Peter Eisentraut wrote: Remove some code for old unsupported versions of MSVC As of d9dd406fe281d22d5238d3c26a7182543c711e74, we require MSVC 2013, which means _MSC_VER >= 1800. This means that conditionals about older

pgsql: Fix typo

2020-04-29 Thread Peter Eisentraut
Fix typo from 927474ce1a2 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fef819ac534d6efb9608fa0bbb93c6fe6c87440e Modified Files -- src/bin/pg_rewind/pg_rewind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: pgsql: Remove some code for old unsupported versions of MSVC

2020-04-29 Thread Amit Kapila
On Tue, Oct 8, 2019 at 2:23 PM Peter Eisentraut wrote: > > Remove some code for old unsupported versions of MSVC > > As of d9dd406fe281d22d5238d3c26a7182543c711e74, we require MSVC 2013, > which means _MSC_VER >= 1800. This means that conditionals about > older versions of _MSC_VER can be