pgsql: Make COPY TO keep locks until the transaction end.

2020-05-14 Thread Amit Kapila
Make COPY TO keep locks until the transaction end. COPY TO released the ACCESS SHARE lock immediately when it was done rather than holding on to it until the end of the transaction. This breaks the case where a REPEATABLE READ transaction could see an empty table if it repeats a COPY statement an

pgsql: docs: PG 13 relnotes: add links and SGML formatting

2020-05-14 Thread Bruce Momjian
docs: PG 13 relnotes: add links and SGML formatting Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/39e7bcbbff82e25441529349134bf41fc336169b Modified Files -- doc/src/sgml/README.links|8 +- doc/src/sgml/release-13.sgml | 4462 ++

pgsql: Remove duplicated comment block in event_trigger.c

2020-05-14 Thread Michael Paquier
Remove duplicated comment block in event_trigger.c The reasons why event triggers are disabled in standalone mode are documented in the code path of ddl_command_start, and other places checking if standalone mode is enabled or not mention to refer to the comment for ddl_command_start, except for t

pgsql: Doc: hack on table 26.1 till it fits in PDF format.

2020-05-14 Thread Tom Lane
Doc: hack on table 26.1 till it fits in PDF format. I abbreviated the heck out of the column headings, and made a few small wording changes, to get it to build warning-free. I can't say that the result is pretty, but it's probably better than removing this table entirely. As of this commit, we h

pgsql: Doc: tweak examples to silence line-too-long PDF build warnings.

2020-05-14 Thread Tom Lane
Doc: tweak examples to silence line-too-long PDF build warnings. In one or two places it seemed reasonable to modify the example so as to shorten its output slightly; but for the most part I just added a &zwsp; after 67 characters, which is the most we can fit on a line of monospace text in A4 for

pgsql: Initial pgindent and pgperltidy run for v13.

2020-05-14 Thread Tom Lane
Initial pgindent and pgperltidy run for v13. Includes some manual cleanup of places that pgindent messed up, most of which weren't per project style anyway. Notably, it seems some people didn't absorb the style rules of commit c9d297751, because there were a bunch of new occurrences of function c

pgsql: doc: PG 13 relnotes: move docbook version change to doc sect.

2020-05-14 Thread Bruce Momjian
doc: PG 13 relnotes: move docbook version change to doc sect. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1255466f8358ecac29581aa5ecec76628dc2e33c Modified Files -- doc/src/sgml/release-13.sgml | 18 +- 1 file changed, 9 insertions(+

pgsql: Collect built-in LWLock tranche names statically, not dynamicall

2020-05-14 Thread Tom Lane
Collect built-in LWLock tranche names statically, not dynamically. There is little point in using the LWLockRegisterTranche mechanism for built-in tranche names. It wastes cycles, it creates opportunities for bugs (since failing to register a tranche name is a very hard-to-detect problem), and th

pgsql: Doc: Fix some inconsistencies with markups

2020-05-14 Thread Michael Paquier
Doc: Fix some inconsistencies with markups This addresses some whitespace issues with programlisting, and corrects the spelling of "Enter PEM pass phrase" to be consistent with the code. Author: Daniel Gustafsson Discussion: https://postgr.es/m/401f9024-20ea-4239-83c4-6b7ad35f9...@yesql.se Branc

pgsql: Fix typo in comment on OpenSSL PEM password callback type name.

2020-05-14 Thread Heikki Linnakangas
Fix typo in comment on OpenSSL PEM password callback type name. The type is called "pem_password_cb", not "pem_passwd_cb". Author: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/22108cf6-228b-45cf-9cda-5c5f658dc...@yesql.se Branch -- master Details --- https://git.

pgsql: Fix amcheck for page checks concurrent to replay of btree page d

2020-05-14 Thread Alexander Korotkov
Fix amcheck for page checks concurrent to replay of btree page deletion amcheck expects at least hikey to always exist on leaf page even if it is deleted page. But replica reinitializes page during replay of page deletion, causing deleted page to have no items. Thus, replay of page deletion can

pgsql: Fix amcheck for page checks concurrent to replay of btree page d

2020-05-14 Thread Alexander Korotkov
Fix amcheck for page checks concurrent to replay of btree page deletion amcheck expects at least hikey to always exist on leaf page even if it is deleted page. But replica reinitializes page during replay of page deletion, causing deleted page to have no items. Thus, replay of page deletion can

pgsql: Fix amcheck for page checks concurrent to replay of btree page d

2020-05-14 Thread Alexander Korotkov
Fix amcheck for page checks concurrent to replay of btree page deletion amcheck expects at least hikey to always exist on leaf page even if it is deleted page. But replica reinitializes page during replay of page deletion, causing deleted page to have no items. Thus, replay of page deletion can