pgsql: Fix some comments in xlogreader.h

2020-05-28 Thread Michael Paquier
Fix some comments in xlogreader.h segment_open and segment_close were mentioned with incorrect names. Discussion: https://postgr.es/m/20200525234944.ga1...@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f93bb0ce64005c84e1d1d431eed31e0da4835078 Modifie

pgsql: Fix typo in test comment.

2020-05-28 Thread Heikki Linnakangas
Fix typo in test comment. The same comment was copied to a few different places, with the same typo. Backpatch down to v11, where this typo was introduced. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/169a6588a71724e7932ece91d844b810b0dbed67 Modified File

pgsql: Add missing error code to "cannot attach index ..." error.

2020-05-28 Thread Heikki Linnakangas
Add missing error code to "cannot attach index ..." error. ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE was used in an ereport with the same message but different errdetail a few lines earlier, so use that here as well. Backpatch-through: 11 Branch -- master Details --- https://git.postgres

pgsql: Fix typo in test comment.

2020-05-28 Thread Heikki Linnakangas
Fix typo in test comment. The same comment was copied to a few different places, with the same typo. Backpatch down to v11, where this typo was introduced. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0099db4ce1a19038d0d837bf82a35c989332cc58 Modified Files -

pgsql: Fix typo in test comment.

2020-05-28 Thread Heikki Linnakangas
Fix typo in test comment. The same comment was copied to a few different places, with the same typo. Backpatch down to v11, where this typo was introduced. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/25fc24ba90df99d3c331627f3e4efb795a440dd0 Modified File

pgsql: Add missing error code to "cannot attach index ..." error.

2020-05-28 Thread Heikki Linnakangas
Add missing error code to "cannot attach index ..." error. ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE was used in an ereport with the same message but different errdetail a few lines earlier, so use that here as well. Backpatch-through: 11 Branch -- REL_11_STABLE Details --- https://git.p

pgsql: Add missing error code to "cannot attach index ..." error.

2020-05-28 Thread Heikki Linnakangas
Add missing error code to "cannot attach index ..." error. ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE was used in an ereport with the same message but different errdetail a few lines earlier, so use that here as well. Backpatch-through: 11 Branch -- REL_12_STABLE Details --- https://git.p

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

2020-05-28 Thread Joe Conway
Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

2020-05-28 Thread Joe Conway
Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

2020-05-28 Thread Joe Conway
Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

2020-05-28 Thread Joe Conway
Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

2020-05-28 Thread Joe Conway
Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

2020-05-28 Thread Joe Conway
Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Initialize dblink remoteConn struct in all cases

2020-05-28 Thread Joe Conway
Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: Initialize dblink remoteConn struct in all cases

2020-05-28 Thread Joe Conway
Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: Initialize dblink remoteConn struct in all cases

2020-05-28 Thread Joe Conway
Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: Initialize dblink remoteConn struct in all cases

2020-05-28 Thread Joe Conway
Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: Initialize dblink remoteConn struct in all cases

2020-05-28 Thread Joe Conway
Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: Initialize dblink remoteConn struct in all cases

2020-05-28 Thread Joe Conway
Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: llvmjit: Fix building against LLVM 11 by removing unnecessary in

2020-05-28 Thread Andres Freund
llvmjit: Fix building against LLVM 11 by removing unnecessary include. LLVM has removed this header, in the branch that will become llvm 11. But as it turns out we didn't actually need it, so just remove it. Author: Jesse Zhang Discussion: https://postgr.es/m/CAGf+fX7bvtP0YXMu7pOsu_NwhxW6dArTkx

pgsql: llvmjit: Fix building against LLVM 11 by removing unnecessary in

2020-05-28 Thread Andres Freund
llvmjit: Fix building against LLVM 11 by removing unnecessary include. LLVM has removed this header, in the branch that will become llvm 11. But as it turns out we didn't actually need it, so just remove it. Author: Jesse Zhang Discussion: https://postgr.es/m/CAGf+fX7bvtP0YXMu7pOsu_NwhxW6dArTkx

pgsql: llvmjit: Fix building against LLVM 11 by removing unnecessary in

2020-05-28 Thread Andres Freund
llvmjit: Fix building against LLVM 11 by removing unnecessary include. LLVM has removed this header, in the branch that will become llvm 11. But as it turns out we didn't actually need it, so just remove it. Author: Jesse Zhang Discussion: https://postgr.es/m/CAGf+fX7bvtP0YXMu7pOsu_NwhxW6dArTkx