pgsql: Update snowball

2020-06-07 Thread Peter Eisentraut
Update snowball Update to snowball tag v2.0.0. Major changes are new stemmers for Basque, Catalan, and Hindi. Discussion: https://www.postgresql.org/message-id/flat/a8eeabd6-2be1-43fe-401e-a97594c38478%402ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commit

pgsql: Fix locking bugs that could corrupt pg_control.

2020-06-07 Thread Thomas Munro
Fix locking bugs that could corrupt pg_control. The redo routines for XLOG_CHECKPOINT_{ONLINE,SHUTDOWN} must acquire ControlFileLock before modifying ControlFile->checkPointCopy, or the checkpointer could write out a control file with a bad checksum. Likewise, XLogReportParameters() must acquire

pgsql: Fix locking bugs that could corrupt pg_control.

2020-06-07 Thread Thomas Munro
Fix locking bugs that could corrupt pg_control. The redo routines for XLOG_CHECKPOINT_{ONLINE,SHUTDOWN} must acquire ControlFileLock before modifying ControlFile->checkPointCopy, or the checkpointer could write out a control file with a bad checksum. Likewise, XLogReportParameters() must acquire

pgsql: Fix locking bugs that could corrupt pg_control.

2020-06-07 Thread Thomas Munro
Fix locking bugs that could corrupt pg_control. The redo routines for XLOG_CHECKPOINT_{ONLINE,SHUTDOWN} must acquire ControlFileLock before modifying ControlFile->checkPointCopy, or the checkpointer could write out a control file with a bad checksum. Likewise, XLogReportParameters() must acquire

pgsql: Fix locking bugs that could corrupt pg_control.

2020-06-07 Thread Thomas Munro
Fix locking bugs that could corrupt pg_control. The redo routines for XLOG_CHECKPOINT_{ONLINE,SHUTDOWN} must acquire ControlFileLock before modifying ControlFile->checkPointCopy, or the checkpointer could write out a control file with a bad checksum. Likewise, XLogReportParameters() must acquire

pgsql: Fix locking bugs that could corrupt pg_control.

2020-06-07 Thread Thomas Munro
Fix locking bugs that could corrupt pg_control. The redo routines for XLOG_CHECKPOINT_{ONLINE,SHUTDOWN} must acquire ControlFileLock before modifying ControlFile->checkPointCopy, or the checkpointer could write out a control file with a bad checksum. Likewise, XLogReportParameters() must acquire

pgsql: Fix locking bugs that could corrupt pg_control.

2020-06-07 Thread Thomas Munro
Fix locking bugs that could corrupt pg_control. The redo routines for XLOG_CHECKPOINT_{ONLINE,SHUTDOWN} must acquire ControlFileLock before modifying ControlFile->checkPointCopy, or the checkpointer could write out a control file with a bad checksum. Likewise, XLogReportParameters() must acquire

pgsql: Fix locking bugs that could corrupt pg_control.

2020-06-07 Thread Thomas Munro
Fix locking bugs that could corrupt pg_control. The redo routines for XLOG_CHECKPOINT_{ONLINE,SHUTDOWN} must acquire ControlFileLock before modifying ControlFile->checkPointCopy, or the checkpointer could write out a control file with a bad checksum. Likewise, XLogReportParameters() must acquire

pgsql: Doc: Update example symptom of systemd misconfiguration.

2020-06-07 Thread Thomas Munro
Doc: Update example symptom of systemd misconfiguration. In PostgreSQL 10, we stopped using System V semaphores on Linux systems. Update the example we give of an error message from a misconfigured system to show what people are most likely to see these days. Back-patch to 10, where PREFERRED_SE

pgsql: Doc: Update example symptom of systemd misconfiguration.

2020-06-07 Thread Thomas Munro
Doc: Update example symptom of systemd misconfiguration. In PostgreSQL 10, we stopped using System V semaphores on Linux systems. Update the example we give of an error message from a misconfigured system to show what people are most likely to see these days. Back-patch to 10, where PREFERRED_SE

pgsql: Doc: Update example symptom of systemd misconfiguration.

2020-06-07 Thread Thomas Munro
Doc: Update example symptom of systemd misconfiguration. In PostgreSQL 10, we stopped using System V semaphores on Linux systems. Update the example we give of an error message from a misconfigured system to show what people are most likely to see these days. Back-patch to 10, where PREFERRED_SE

pgsql: Doc: Update example symptom of systemd misconfiguration.

2020-06-07 Thread Thomas Munro
Doc: Update example symptom of systemd misconfiguration. In PostgreSQL 10, we stopped using System V semaphores on Linux systems. Update the example we give of an error message from a misconfigured system to show what people are most likely to see these days. Back-patch to 10, where PREFERRED_SE

pgsql: Doc: Update example symptom of systemd misconfiguration.

2020-06-07 Thread Thomas Munro
Doc: Update example symptom of systemd misconfiguration. In PostgreSQL 10, we stopped using System V semaphores on Linux systems. Update the example we give of an error message from a misconfigured system to show what people are most likely to see these days. Back-patch to 10, where PREFERRED_SE

pgsql: Fix crash in WAL sender when starting physical replication

2020-06-07 Thread Michael Paquier
Fix crash in WAL sender when starting physical replication Since database connections can be used with WAL senders in 9.4, it is possible to use physical replication. This commit fixes a crash when starting physical replication with a WAL sender using a database connection, caused by the refactor

pgsql: Fix crash in WAL sender when starting physical replication

2020-06-07 Thread Michael Paquier
Fix crash in WAL sender when starting physical replication Since database connections can be used with WAL senders in 9.4, it is possible to use physical replication. This commit fixes a crash when starting physical replication with a WAL sender using a database connection, caused by the refactor

pgsql: MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS

2020-06-07 Thread Noah Misch
MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS. Commit 7be5d8df1f74b78620167d3abf32ee607e728919 surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch

pgsql: MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS

2020-06-07 Thread Noah Misch
MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS. Commit 7be5d8df1f74b78620167d3abf32ee607e728919 surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch

pgsql: MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS

2020-06-07 Thread Noah Misch
MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS. Commit 7be5d8df1f74b78620167d3abf32ee607e728919 surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch

pgsql: MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS

2020-06-07 Thread Noah Misch
MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS. Commit 7be5d8df1f74b78620167d3abf32ee607e728919 surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch

pgsql: MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS

2020-06-07 Thread Noah Misch
MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS. Commit 7be5d8df1f74b78620167d3abf32ee607e728919 surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch

pgsql: MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS

2020-06-07 Thread Noah Misch
MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS. Commit 7be5d8df1f74b78620167d3abf32ee607e728919 surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch

pgsql: MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS

2020-06-07 Thread Noah Misch
MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS. Commit 7be5d8df1f74b78620167d3abf32ee607e728919 surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch

pgsql: Branch REL_13_STABLE was created

2020-06-07 Thread noreply
Branch REL_13_STABLE was created. View: https://git.postgresql.org/pg/shortlog/refs/heads/REL_13_STABLE

pgsql: Stamp HEAD as 14devel.

2020-06-07 Thread Tom Lane
Stamp HEAD as 14devel. Let the hacking begin ... Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d10b19e224c2ead10b59382f695f0c2bd65039fa Modified Files -- configure| 18 +- configure.in |2 +- doc/src/sgml/fileli

pgsql: pgindent run prior to branching v13.

2020-06-07 Thread Tom Lane
pgindent run prior to branching v13. pgperltidy and reformat-dat-files too, though those didn't find anything to change. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b5d69b7c22ee4c44b8bb99cfa0466ffaf3b5fab9 Modified Files -- src/backend/jit/llvm/llvm

pgsql: Try to read data from the socket in pqSendSome's write_failed pa

2020-06-07 Thread Tom Lane
Try to read data from the socket in pqSendSome's write_failed paths. Even when we've concluded that we have a hard write failure on the socket, we should continue to try to read data. This gives us an opportunity to collect any final error message that the backend might have sent before closing t

pgsql: Try to read data from the socket in pqSendSome's write_failed pa

2020-06-07 Thread Tom Lane
Try to read data from the socket in pqSendSome's write_failed paths. Even when we've concluded that we have a hard write failure on the socket, we should continue to try to read data. This gives us an opportunity to collect any final error message that the backend might have sent before closing t

pgsql: Rethink definition of cancel.c's CancelRequested flag.

2020-06-07 Thread Tom Lane
Rethink definition of cancel.c's CancelRequested flag. As it stands, this flag is only set when we've successfully sent a cancel request, not if we get SIGINT and then fail to send a cancel. However, for almost all callers, that's the Wrong Thing: we'd prefer to abort processing after control-C ev

pgsql: Fix platform-specific performance regression in logtape.c.

2020-06-07 Thread Jeff Davis
Fix platform-specific performance regression in logtape.c. Commit 24d85952 made a change that indirectly caused a performance regression by triggering a change in the way GCC optimizes memcpy() on some platforms. The behavior seemed to contradict a GCC document, so I filed a report: https://gcc.

pgsql: psql: Format \? output a little better

2020-06-07 Thread Peter Eisentraut
psql: Format \? output a little better Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/aa7927698acb813283d21aa6a47a67cd3c5a8b0c Modified Files -- src/bin/psql/help.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

pgsql: Fix message translatability

2020-06-07 Thread Peter Eisentraut
Fix message translatability Two parts of the same message shouldn't be split across two function calls. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1e8ada0c8a448891971faf71f48125439ee07023 Modified Files -- src/bin/psql/help.c | 4 ++-- 1 file change

pgsql: Spelling adjustments

2020-06-07 Thread Peter Eisentraut
Spelling adjustments Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0fd2a79a637f9f96b9830524823df0454e962f96 Modified Files -- doc/src/sgml/config.sgml| 8 src/backend/commands/async.c| 2 +- src/back

pgsql: doc: Fix man page whitespace issues

2020-06-07 Thread Peter Eisentraut
doc: Fix man page whitespace issues Whitespace between tags is significant, and in some cases it creates extra vertical space in man pages. The fix is either to remove some newlines or in some cases to reword slightly to avoid the awkward markup layout. Branch -- master Details --- http

pgsql: Formatting and punctuation improvements in postgresql.conf.sampl

2020-06-07 Thread Peter Eisentraut
Formatting and punctuation improvements in postgresql.conf.sample Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f4c88ce1a20e8e944d74cb964926781d6ca4cb18 Modified Files -- src/backend/utils/misc/postgresql.conf.sample | 24 1 fil

pgsql: doc: Move options on man pages into more alphabetical order

2020-06-07 Thread Peter Eisentraut
doc: Move options on man pages into more alphabetical order Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b25da866152347109943f998b66b1a320a9de3e0 Modified Files -- doc/src/sgml/ref/dropdb.sgml| 16 +++--- doc/src/sgml/ref/pg_basebackup.sgml |

pgsql: doc: Fix up spacing around verbatim DocBook elements

2020-06-07 Thread Peter Eisentraut
doc: Fix up spacing around verbatim DocBook elements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9ac0a26210901a5869fd7ea83ab1c59489c1aeef Modified Files -- doc/src/sgml/hstore.sgml | 4 ++-- doc/src/sgml/release-13.sgml | 6 +++--- 2 files changed,

pgsql: doc: Language review

2020-06-07 Thread Peter Eisentraut
doc: Language review Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4c6f70cd33ac395dea1acca7dabf4cb8556235e7 Modified Files -- doc/src/sgml/libpq.sgml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

pgsql: doc: Trim trailing whitespace

2020-06-07 Thread Peter Eisentraut
doc: Trim trailing whitespace Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b79cb8a919c2614c81ae7578b863b7f582a9baf2 Modified Files -- doc/src/sgml/ref/drop_database.sgml | 4 ++-- doc/src/sgml/ref/pg_checksums.sgml| 2 +- doc/src/sgml/ref/pg_rec

pgsql: doc: Clean up title case use

2020-06-07 Thread Peter Eisentraut
doc: Clean up title case use Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a00222f07b142484fb2d36e6e2343db7c9f96d69 Modified Files -- doc/src/sgml/features.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: doc: Clean up title case use

2020-06-07 Thread Peter Eisentraut
doc: Clean up title case use Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b3c2412e70f2be25ac70f7e9b2f12dbe4efd2a8b Modified Files -- doc/src/sgml/features.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: doc: Remove line breaks after

2020-06-07 Thread Peter Eisentraut
doc: Remove line breaks after This creates unnecessary rendering problem risks, and it's inconsistent and gets copied around. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ab5b55505ec4bf08a9f93810e1bfada93bc63bb5 Modified Files -- doc/src/sgml/featur

pgsql: Doc: Clean up references to obsolete OS versions.

2020-06-07 Thread Thomas Munro
Doc: Clean up references to obsolete OS versions. Remove obsolete instructions for old operating system versions, and update the text to reflect the defaults on modern systems. Reviewed-by: Tom Lane Reviewed-by: Peter Eisentraut Reviewed-by: Magnus Hagander Discussion: https://postgr.es/m/CA%

pgsql: doc: Fix incorrect link target

2020-06-07 Thread Peter Eisentraut
doc: Fix incorrect link target Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c14a98032b17d514a195e4e76073ebc98a6521be Modified Files -- doc/src/sgml/func.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: doc: Fix incorrect link target

2020-06-07 Thread Peter Eisentraut
doc: Fix incorrect link target Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8414f41d3485aaed2985cf06cea9a07c50eec262 Modified Files -- doc/src/sgml/func.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)