pgsql: Fix typo

2020-07-08 Thread Magnus Hagander
Fix typo Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/98f0eba5b7840197ee43f52833ef08f9090fbc44 Modified Files -- src/backend/postmaster/pgstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Remove junk in test file

2020-07-08 Thread Peter Eisentraut
Remove junk in test file Remove a redundant and failing command, probably a typo. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eb2c8a8f816b6c411047eeab7a326e8356a2c0a8 Modified Files -- src/test/modules/unsafe_tests/expected/rolenames.out | 2 -- src/

pgsql: Fix incorrect variable datatype.

2020-07-08 Thread Fujii Masao
Fix incorrect variable datatype. Since slot_keep_segs indicates the number of WAL segments not LSN, its datatype should not be XLogRecPtr. Back-patch to v13 where this issue was added. Reported-by: Atsushi Torikoshi Author: Atsushi Torikoshi, tweaked by Fujii Masao Discussion: https://postgr.es/

pgsql: Fix incorrect variable datatype.

2020-07-08 Thread Fujii Masao
Fix incorrect variable datatype. Since slot_keep_segs indicates the number of WAL segments not LSN, its datatype should not be XLogRecPtr. Back-patch to v13 where this issue was added. Reported-by: Atsushi Torikoshi Author: Atsushi Torikoshi, tweaked by Fujii Masao Discussion: https://postgr.es/

pgsql: Add test coverage for pg_current_logfile() function.

2020-07-08 Thread Tom Lane
Add test coverage for pg_current_logfile() function. There has been no coverage at all up to now. Given Thomas Kellerer's recent report, I suspect this may fail on (some?) Windows machines, but let's find out. Discussion: https://postgr.es/m/412ae8da-76bb-640f-039a-f3513499e...@gmx.net Branch -

pgsql: Don't treat DumpOptions->dump_inserts like a boolean

2020-07-08 Thread Alvaro Herrera
Don't treat DumpOptions->dump_inserts like a boolean This has been an integer count since 7e413a0f82c8 so treat it explicitly like an integer. No backpatch since this is just cosmetic. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2661a793ff59149af1d844d6be504e42

pgsql: code: replace 'master' with 'primary' where appropriate.

2020-07-08 Thread Andres Freund
code: replace 'master' with 'primary' where appropriate. Also changed "in the primary" to "on the primary", and added a few "the" before "primary". Author: Andres Freund Reviewed-By: David Steele Discussion: https://postgr.es/m/20200615182235.x7lch5n6kcjq4...@alap3.anarazel.de Branch -- mas

pgsql: code: replace 'master' with 'leader' where appropriate.

2020-07-08 Thread Andres Freund
code: replace 'master' with 'leader' where appropriate. Leader already is the more widely used terminology, but a few places didn't get the message. Author: Andres Freund Reviewed-By: David Steele Discussion: https://postgr.es/m/20200615182235.x7lch5n6kcjq4...@alap3.anarazel.de Branch -- ma

pgsql: tap tests: replace 'master' with 'primary'.

2020-07-08 Thread Andres Freund
tap tests: replace 'master' with 'primary'. We've largely replaced master with primary in docs etc, but tap test still widely used master. Author: Andres Freund Reviewed-By: David Steele Discussion: https://postgr.es/m/20200615182235.x7lch5n6kcjq4...@alap3.anarazel.de Branch -- master Deta

pgsql: docs: replace 'master' with 'primary' where appropriate.

2020-07-08 Thread Andres Freund
docs: replace 'master' with 'primary' where appropriate. Also changed "in the primary" to "on the primary", and added a few "the" before "primary". Author: Andres Freund Reviewed-By: David Steele Discussion: https://postgr.es/m/20200615182235.x7lch5n6kcjq4...@alap3.anarazel.de Branch -- mas

pgsql: docs: replace 'master' with 'root' where appropriate.

2020-07-08 Thread Andres Freund
docs: replace 'master' with 'root' where appropriate. These uses of 'master' refer to partitioning / inheritance. 'root' seems more descriptive than 'master'. Author: Andres Freund Reviewed-By: David Steele Discussion: https://postgr.es/m/20200615182235.x7lch5n6kcjq4...@alap3.anarazel.de Branch

pgsql: docs: replace 'master process' with 'supervisor process' where a

2020-07-08 Thread Andres Freund
docs: replace 'master process' with 'supervisor process' where appropriate. Author: Andres Freund Reviewed-By: David Steele Discussion: https://postgr.es/m/20200615182235.x7lch5n6kcjq4...@alap3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7c89f8a5b81

pgsql: code: replace most remaining uses of 'master'.

2020-07-08 Thread Andres Freund
code: replace most remaining uses of 'master'. Author: Andres Freund Reviewed-By: David Steele Discussion: https://postgr.es/m/20200615182235.x7lch5n6kcjq4...@alap3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a9a4a7ad565b136cbee735d4bb505d98d06da522

pgsql: Fix whitespace in HashAgg EXPLAIN ANALYZE

2020-07-08 Thread David Rowley
Fix whitespace in HashAgg EXPLAIN ANALYZE The Sort node does not put a space between the number of kilobytes and the "kB" of memory or disk space used, but HashAgg does. Here we align HashAgg to do the same as Sort. Sort has been displaying this information for longer than HashAgg, so it makes s

pgsql: Fix whitespace in HashAgg EXPLAIN ANALYZE

2020-07-08 Thread David Rowley
Fix whitespace in HashAgg EXPLAIN ANALYZE The Sort node does not put a space between the number of kilobytes and the "kB" of memory or disk space used, but HashAgg does. Here we align HashAgg to do the same as Sort. Sort has been displaying this information for longer than HashAgg, so it makes s

pgsql: Tighten up Windows CRLF conversion in our TAP test scripts.

2020-07-08 Thread Tom Lane
Tighten up Windows CRLF conversion in our TAP test scripts. The previous approach was to search-and-destroy all \r occurrences no matter what. That seems more likely to hide bugs than anything else; indeed it seems to be hiding one now. Fix things so that we only transform \r\n to \n. Side effe

pgsql: doc: Correct the description about the length of pg_stat_activit

2020-07-08 Thread Fujii Masao
doc: Correct the description about the length of pg_stat_activity.query. pg_stat_activity.query text is truncated at 1024 bytes. But previously the document described that it's truncated at 1024 characters. This was not accurate when considering multibyte characters. Back-patch to v10 where this

pgsql: doc: Correct the description about the length of pg_stat_activit

2020-07-08 Thread Fujii Masao
doc: Correct the description about the length of pg_stat_activity.query. pg_stat_activity.query text is truncated at 1024 bytes. But previously the document described that it's truncated at 1024 characters. This was not accurate when considering multibyte characters. Back-patch to v10 where this

pgsql: doc: Correct the description about the length of pg_stat_activit

2020-07-08 Thread Fujii Masao
doc: Correct the description about the length of pg_stat_activity.query. pg_stat_activity.query text is truncated at 1024 bytes. But previously the document described that it's truncated at 1024 characters. This was not accurate when considering multibyte characters. Back-patch to v10 where this

pgsql: doc: Correct the description about the length of pg_stat_activit

2020-07-08 Thread Fujii Masao
doc: Correct the description about the length of pg_stat_activity.query. pg_stat_activity.query text is truncated at 1024 bytes. But previously the document described that it's truncated at 1024 characters. This was not accurate when considering multibyte characters. Back-patch to v10 where this

pgsql: doc: Correct the description about the length of pg_stat_activit

2020-07-08 Thread Fujii Masao
doc: Correct the description about the length of pg_stat_activity.query. pg_stat_activity.query text is truncated at 1024 bytes. But previously the document described that it's truncated at 1024 characters. This was not accurate when considering multibyte characters. Back-patch to v10 where this