pgsql: Fix the logical streaming test.

2020-08-07 Thread Amit Kapila
Fix the logical streaming test. Commit 7259736a6e added the capability to stream changes in ReorderBuffer which has some tests to test the streaming mode. It is quite possible that while this test is running a parallel transaction could be logged by autovacuum. Such a transaction won't perform any

Re: pgsql: Implement streaming mode in ReorderBuffer.

2020-08-07 Thread Amit Kapila
On Sat, Aug 8, 2020 at 11:03 AM Amit Kapila wrote: > > On Sat, Aug 8, 2020 at 7:59 AM Amit Kapila wrote: > > > > Implement streaming mode in ReorderBuffer. > > > > There is one failure [1] due to this commit. Looking into same. > The problem seems to be due to some parallel transactions (like a

pgsql: Add some const decorations

2020-08-07 Thread Peter Eisentraut
Add some const decorations Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a13421c96c0e8ffa34310f92d03d0e6f3bfa27f8 Modified Files -- src/backend/replication/logical/logical.c | 6 +++--- src/include/replication/logical.h | 2 +- 2 files changed, 4

Re: pgsql: Implement streaming mode in ReorderBuffer.

2020-08-07 Thread Amit Kapila
On Sat, Aug 8, 2020 at 7:59 AM Amit Kapila wrote: > > Implement streaming mode in ReorderBuffer. > There is one failure [1] due to this commit. Looking into same. [1] - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tern&dt=2020-08-08%2004%3A26%3A04 -- With Regards, Amit Kapila.

pgsql: Implement streaming mode in ReorderBuffer.

2020-08-07 Thread Amit Kapila
Implement streaming mode in ReorderBuffer. Instead of serializing the transaction to disk after reaching the logical_decoding_work_mem limit in memory, we consume the changes we have in memory and invoke stream API methods added by commit 45fdc9738b. However, sometimes if we have incomplete toast

pgsql: Make nbtree split REDO locking match original execution.

2020-08-07 Thread Peter Geoghegan
Make nbtree split REDO locking match original execution. Make the nbtree page split REDO routine consistent with original execution in its approach to acquiring and releasing buffer locks (at least for pages on the tree level of the page being split). This brings btree_xlog_split() in line with b

pgsql: Remove PROC_IN_ANALYZE and derived flags

2020-08-07 Thread Alvaro Herrera
Remove PROC_IN_ANALYZE and derived flags These flags are unused and always have been. Discussion: https://postgr.es/m/20200805235549.GA8118@alvherre.pgsql Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cea3d55898655582e3a3835a7bed2c3a1b002fef Modified Files -

pgsql: Add list of acknowledgments to release notes

2020-08-07 Thread Peter Eisentraut
Add list of acknowledgments to release notes This contains all individuals mentioned in the commit messages during PostgreSQL 13 development. current through 79a3ab1e98d6b5952e29ad91e07c0e9fc777cc0b Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f1c3a41bd69

pgsql: Support testing of cases where table schemas change after planni

2020-08-07 Thread Tom Lane
Support testing of cases where table schemas change after planning. We have various cases where we allow DDL on tables to be performed with less than full AccessExclusiveLock. This requires concurrent queries to be able to cope with the DDL change mid-flight, but up to now we had no repeatable wa

pgsql: Rename nbtree split REDO routine variables.

2020-08-07 Thread Peter Geoghegan
Rename nbtree split REDO routine variables. Make the nbtree page split REDO routine variable names consistent with _bt_split() (which handles the original execution of page splits). These names make the code easier to follow by making the distinction between the original page and the left half of